March 2020 - Koha-bugs - lists.koha-community.org

[Bug 22860] New: Selenium tests authentication.t does not remove all data it created
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '20

09 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860 Bug ID: 22860 Summary: Selenium tests authentication.t does not remove all data it created Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 19181 Target Milestone: --- 1 patron will remain in the DB after the tests ran. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19181 [Bug 19181] Intranet and OPAC authentication selenium test -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 13305] Fix tab order in cataloguing/item editor
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '20

09 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 Lucas Gass <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas(a)bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Lucas Gass <lucas(a)bywatersolutions.com> --- backported to 19.05.x for 19.05.09 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16719] New: LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '20

09 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 Bug ID: 16719 Summary: LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Authentication Assignee: gmcharlt(a)gmail.com Reporter: oliver.bock(a)aei.mpg.de QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Created attachment 52316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52316&action=ed… Patch: proper NULL mapping LDAP attributes with empty values are currently mapped as empty strings, which is described as 'failsafe'. This defeats the existing database constraints (NULL and UNIQUE) without an apparent need. If some kind of empty default is required, it should be set in the mapping config itself, not the code. Please note that this is not just a semantic issue since mapping empty LDAP values as an empty string does indeed cause a constraint violation (read: database error, hence our severity) when such an attribute bears a UNIQUE constraint. This is due to the fact that an empty string is an actual value validated by the constraint (NULL isn't). I don't know the reasoning behind the empty-string mapping but should a NULL-mapping have been the original intention then please note that this behavior is database-dependent. The correct way to map NULL in a database-agnostic way is to use "undef" (see my patch). Thanks -- You are receiving this mail because: You are watching all bug changes.

1 24

[Bug 23784] New: Show subtitle, number and parts in course reserves list of items
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '20

09 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23784 Bug ID: 23784 Summary: Show subtitle, number and parts in course reserves list of items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org It would be nice if the subtitle and number/part information (MARC21: 245$b$n$p) showed in the course reserves list of records. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 24410] New: Multi holds broken
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '20

09 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410 Bug ID: 24410 Summary: Multi holds broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Hold requests Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Depends on: 19618 Bug 19618 replaces the call to placerequest.pl with a REST API /holds That is wrong as it does not support multi holds. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 [Bug 19618] Add 'Club Holds' feature -- You are receiving this mail because: You are watching all bug changes.

1 24

[Bug 13420] Holdings table sorting on volume information incorrect
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '20

09 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Lucas Gass <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas(a)bywatersolutions.com Version(s)|20.05.00, 19.11.04 |20.05.00, 19.11.04, released in| |19.05.09 --- Comment #31 from Lucas Gass <lucas(a)bywatersolutions.com> --- backported to 19.05.x for 19.05.09 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24052] Koha::XSLT housekeeping for bug 23290 (follow-up)
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '20

09 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 --- Comment #15 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 100409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100409&action=e… Bug 24052: Add koha_xslt_security to koha-conf.xml The line for enabling the unsafe expand_entities option is commented and includes a warning to keep it like that ;) Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24052] Koha::XSLT housekeeping for bug 23290 (follow-up)
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '20

09 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 --- Comment #14 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 100408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100408&action=e… Bug 24052: Catch warning between test 5 and 6 Resolve: ok 5 - Engine returns error on undefined text XSLT::Base: Empty String at /usr/share/koha/Koha/XSLT/Base.pm line 214. ok 6 - Engine returns error on empty string Test plan: Run perl Base.t and verify that this warning is no longer printed. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24052] Koha::XSLT housekeeping for bug 23290 (follow-up)
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '20

09 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 --- Comment #13 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 100407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100407&action=e… Bug 24052: Fix Koha/XSLT/Base.t Moving the separate small attachments into the test script. Creating them now as temporary files or code fragments. Deleting original files. Since Breeding.t also used one of these files, a similar change was made in that script. Test plan: Run t/db_dependent/Koha/XSLT/Base.t. Should pass now. Run t/db_dependent/Breeding.t again. Git grep on XSLT_Handler. You should only find release notes. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24052] Koha::XSLT housekeeping for bug 23290 (follow-up)
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '20

09 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100371|0 |1 is obsolete| | Attachment #100372|0 |1 is obsolete| | Attachment #100373|0 |1 is obsolete| | Attachment #100374|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 100406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100406&action=e… Bug 24052: Rename XSLT_Handler Should be XSLT::Base now. Removes old XSLT_Handler stub too (from bug 23290). Result of a git grep | sed statement. Test plan: Run qa tools (so modules compile). Run t/db_dependent/Breeding.t Run t/db_dependent/Koha/XSLT/Base.t (This test fails when only this patch has been applied; see subsequent patch.) Enable XSLT use on results and details display. Check search results and detail view on OPAC and staff. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0