March 2020 - Koha-bugs - lists.koha-community.org

[Bug 24052] Koha::XSLT housekeeping for bug 23290 (follow-up)
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '20

09 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24052] Koha::XSLT housekeeping for bug 23290 (follow-up)
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '20

09 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99688|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24052] Koha::XSLT housekeeping for bug 23290 (follow-up)
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '20

09 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24052] Koha::XSLT housekeeping for bug 23290 (follow-up)
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '20

09 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99689|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 100374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100374&action=e… Bug 24052: Add koha_xslt_security to koha-conf.xml The line for enabling the unsafe expand_entities option is commented and includes a warning to keep it like that ;) Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24052] Koha::XSLT housekeeping for bug 23290 (follow-up)
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '20

09 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 --- Comment #10 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 100373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100373&action=e… Bug 24052: Catch warning between test 5 and 6 Resolve: ok 5 - Engine returns error on undefined text XSLT::Base: Empty String at /usr/share/koha/Koha/XSLT/Base.pm line 214. ok 6 - Engine returns error on empty string Test plan: Run perl Base.t and verify that this warning is no longer printed. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24052] Koha::XSLT housekeeping for bug 23290 (follow-up)
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '20

09 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99687|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 100372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100372&action=e… Bug 24052: Fix Koha/XSLT/Base.t Moving the separate small attachments into the test script. Creating them now as temporary files or code fragments. Deleting original files. Since Breeding.t also used one of these files, a similar change was made in that script. Test plan: Run t/db_dependent/Koha/XSLT/Base.t. Should pass now. Run t/db_dependent/Breeding.t again. Git grep on XSLT_Handler. You should only find release notes. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24052] Koha::XSLT housekeeping for bug 23290 (follow-up)
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '20

09 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99686|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 100371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100371&action=e… Bug 24052: Rename XSLT_Handler Should be XSLT::Base now. Removes old XSLT_Handler stub too (from bug 23290). Result of a git grep | sed statement. Test plan: Run qa tools (so modules compile). Run t/db_dependent/Breeding.t Run t/db_dependent/Koha/XSLT/Base.t (This test fails when only this patch has been applied; see subsequent patch.) Enable XSLT use on results and details display. Check search results and detail view on OPAC and staff. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '20

09 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #62 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 100343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100343&action=e… Bug 13897: Surround columns with backticks We have some column's names that need to be surrounded by ` as they are protected keywords ('rows' for instance) Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '20

09 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #61 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 100342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100342&action=e… Bug 13897: Process description, multiline values and SQL statements in YAML files This patch adds 3 features: 1) Display description of YAML files at install time for frameworks, and fixes it's encoding. 2) Enable use of multiline values, field required 3) Process SQL statements declared in YAML files With this features we can process files with the following generic YAML strucure: --- description: - "File description" tables: - table_name: translatable: [ title, content ] multiline: [ content ] rows: - title: "Example title" content: - "Content:" - "" - "This is the content." id: 1 value: ~ sql_statements: - "UPDATE table_name SET value ='empty' WHERE value IS NULL" ... * file description is now inside the YAML, can have multiple lines. This attribute is expected in all YAML files. * translatable attribute in table declare fields that can be translated * multiline attribute in table declare fields that can have multiple lines of content, they are joined using '\r\n' before insert into database. This is useful to express fields like 'news' content, and to simplify it's translation. '\r\n' is used for correct display in Windows clients. * sql_statements allows to add multiple SQL sentences, not insertions normally, that are executed in order. This features are not needed for the example file of this patch, but will be used in new bugs. To test: 1) Use the same test plan of first patch. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '20

09 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #60 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 100341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100341&action=e… Bug 13897: Catch the error and warn it Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0