April 2020 - Koha-bugs - lists.koha-community.org

[Bug 14708] The patron set as the anonymous patron should not be deletable.
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '20

29 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #13 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #11) > This technically works, but: > - When merging patrons, I am able to merge another patron into my anonymous > patron. Is this what we want? Could be, just wanted to make sure it'd been > considered. Fixed with the latest patch! > - When I try to merge my anonymous patron into someone else, it fails as > desired but the error given is "No valid patrons to merge were found." Would > be nice to have something more specific about why the action cannot be > completed. That would definitely be a nice enhancement, but it out of the scope of this bug. Can you file a followup bug report for that? > - When attempting to include the anonymous patron in a batch delete, Koha > does not delete them and does not tell you why. This is really a larger > issue, as that's standard batch patron delete behavior. I'm really just > taking this opportunity to stump for bug 24483, which suggests adding some > feedback about who wasn't batch deleted and why. Also agreed, but is of course outside the scope of this bug report. I will make 14708 depend on this bug so the feedback can include anonymous borrower issues when merging. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14708] The patron set as the anonymous patron should not be deletable.
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '20

29 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #12 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 103922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103922&action=e… Bug 14708: Don't allow merging of other patron records into Anonymous Patron -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '20

29 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #87 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #77) > % koha-sip --restart > > and I get: > > [2020/04/23 11:23:27] [ERROR] [undef]@[undef]: Argument "0.33_01" isn't > numeric in numeric lt (<) at /usr/share/perl5/Net/Server/Log/Sys/Syslog.pm > line 42. > C4::SIP::Trapper::PRINT /kohadevbox/koha/C4/SIP/Trapper.pm (24) > > > Why "ERROR" when it's a warning? > The [undef]@[undef] seems wrong here. During normal SIP use, that will show the sip account used and the incoming ip address. For unit tests and such they appear as undefs. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '20

29 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #86 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 103921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103921&action=e… Bug 15253: Add POD to C4/SIP/Logger.pm and C4/SIP/Trapper.pm -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '20

29 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #85 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 103920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103920&action=e… Bug 15253: Convert all tabs into 4 spaces in affected files -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '20

29 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #84 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 103919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103919&action=e… Bug 15253: Log trapped errors as log level 'warn' instead of 'error' -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '20

29 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #83 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 103918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103918&action=e… Bug 15253: Add log4perl conf updates for Debian packages * Add log4perl conf updates for Debian packages * Rename sip2.log to sip.log -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '20

29 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #82 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 103917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103917&action=e… Bug 15253: Rename syslog() to siplog() -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '20

29 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #81 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 103916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103916&action=e… Bug 15253: Move subs to a new module, allow unit tests to function -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '20

29 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103499|0 |1 is obsolete| | Attachment #103500|0 |1 is obsolete| | Attachment #103501|0 |1 is obsolete| | Attachment #103502|0 |1 is obsolete| | Attachment #103503|0 |1 is obsolete| | Attachment #103599|0 |1 is obsolete| | --- Comment #80 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 103915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103915&action=e… Bug 15253: Add Koha::Logger based logging for SIP2 Now that we have Koha::Logger, we should use it in our SIP server. This has the potential to make debugging SIP issue much easier. We should add the userid for the sipuser to the namespace so we can allow for separate files per sip user if wanted. Test Plan: 1) Apply this patch set 2) Update the modififed log4perl.conf to your system 3) Restart your sip server 4) Tail your sip2.log, run some queries 5) Note you still get the same output messages as before, with the addition of the ip address and username ( if available ) prefixing the message. Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0