April 2020 - Koha-bugs - lists.koha-community.org

[Bug 24013] New: Transferring a checked out item gives a software error
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '20

30 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013 Bug ID: 24013 Summary: Transferring a checked out item gives a software error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To reproduce: 1. check out an item 2. Go to circulation -> transfer and put in the barcode of the item you just checked out 3. error: Can't call method "borrowernumber" on unblessed reference at /home/vagrant/kohaclone/C4/Circulation.pm line 350 This occurs in the C4::Circulation::transferbook subroutine. It happens because Bug 18276 accidentally reintroduces an old subroutine (GetOpenIssue) that returns an unblessed reference. This line should use Koha Objects instead. Code causing an error: my $issue = GetOpenIssue($itemnumber); # check if it is still issued to someone, return it... if ( $issue ) { AddReturn( $barcode, $fbr ); $messages->{'WasReturned'} = $issue->borrowernumber; } Suggested fix: my $issue = Koha::Checkouts->find({ itemnumber => $itemnumber }); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 12722] bulkmarcimport.pl: Should we move the old 001 to 035 ?
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '20

30 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722 --- Comment #13 from Heather <heather_hernandez(a)nps.gov> --- (In reply to Katrin Fischer from comment #12) > We are not an OCLC library, but our workflow is tied to 001 being the ID > from our union catlalog, so in a similar situation. At the moment it seems > not easy to match well on 035 or at least more error prone with a lot of > different prefixes? In a MARC21 catalog, the 035 would contain a lot of different prefixes, c.f. examples at https://www.loc.gov/marc/bibliographic/bd035.html, e.g. these: 035 ##$a(CaOTULAS)41063988 035 ##$a(WaOLN)wln7986864 035 ##$a(DNLM)S30545600(s) The standard formatting of the required prefixes as stored in the 035 are formatted very differently from how the number would be formatted in the 001, so moving the data from an 001 into a correctly formatted 035 would be rather complicated. It's not something I'd want as default behavior in my Koha catalog at all, for either my authority or my bibliographic records. For authority records, we would always want to match on the 010 Library of Congress Control number, since that's stable no matter where the authority record comes from. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 25329] New: Bug on code for video
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '20

30 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25329 Bug ID: 25329 Summary: Bug on code for video Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: iacob.diana.f(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 13388] Add library pages to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '20

30 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103923|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 104042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104042&action=e… Bug 13388: Add library pages to the OPAC This patch adds a script and a template for showing library information pages in the OPAC. A "libraries" page lists all the libraries in the system, linking to individual pages for each library showing more information.. If there is only one library in the system the page shows all of that library's information. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staf…) - Go to /cgi-bin/koha/opac-library.pl in the OPAC. - Verify that all the correct information is displayed for the libraries in your system. - Verify that page title and breadcrumbs look correct. - Click to view details for a library. - The details page should show the full contents of branches.opac_info - A menu should show links to other libraries' detail pages. EDIT: This revised patch adds a "Libraries" link to the links under the search bar; Corrects encoding in the breadcrumb link; Makes the page title more specific when viewing an individual library. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12388] IssueSlip output should be sorted by date_due, not timestamp
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '20

30 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12388 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel(a)gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12388] IssueSlip output should be sorted by date_due, not timestamp
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '20

30 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12388 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102977|0 |1 is obsolete| | --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 104034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104034&action=e… Bug 12388: Adjust tests To test, prove t/db_dependent/Members/IssueSlip.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12388] IssueSlip output should be sorted by date_due, not timestamp
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '20

30 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12388 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91766|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 104033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104033&action=e… Bug 12388: IssueSlip output should be sorted by date_due, not timestamp Sponsored-by: Koha-Suomi Oy Signed-off-by: Emmi Takkinen <emmi.takkinen(a)outlook.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 25326] New: Hii
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '20

30 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25326 Bug ID: 25326 Summary: Hii Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: lanang.gaming06(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Created attachment 104019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104019&action=e… GoldGanz Is here!! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '20

30 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #89 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #87) > (In reply to Jonathan Druart from comment #77) > > % koha-sip --restart > > > > and I get: > > > > [2020/04/23 11:23:27] [ERROR] [undef]@[undef]: Argument "0.33_01" isn't > > numeric in numeric lt (<) at /usr/share/perl5/Net/Server/Log/Sys/Syslog.pm > > line 42. > > C4::SIP::Trapper::PRINT /kohadevbox/koha/C4/SIP/Trapper.pm (24) > > > > > > Why "ERROR" when it's a warning? > > The [undef]@[undef] seems wrong here. > > During normal SIP use, that will show the sip account used and the incoming > ip address. For unit tests and such they appear as undefs. I was missing that they were variables defined in SIPServer.pm: + # Flush previous MDCs to prevent accidentally leaking incorrect MDC-entries + Log::Log4perl::MDC->put( "accountid", undef ); + Log::Log4perl::MDC->put( "peeraddr", undef ); Is that correct to use directly Log::Log4perl here? Should not it be a Koha::Logger method instead? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '20

30 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #88 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 104016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104016&action=e… Bug 15253: Remove unused use of Scalar::Util -- You are receiving this mail because: You are watching all bug changes.

1 0