April 2020 - Koha-bugs - lists.koha-community.org

[Bug 5087] Option to not show CSV profiles in OPAC
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '20

21 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98779|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 103437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103437&action=e… Bug 5087: Ability to define whether CSV profile shows in OPAC To test: 1) Update database 2) Update schema 3) In staff side, go to Tools -> CSV profiles 4) Make a CSV profile with profile type = MARC and usage = Export records 5) Leave 'Show option in OPAC' unchecked and save 6) Go to OPAC and add an item to your cart 7) Click Cart, click Download, confirm that your newly created CSV profile does not show as an option 8) Go back and edit CSV profile on staff side 9) Check the 'Show option in OPAC' checkbox and save 10) Go back to download cart in OPAC 11) Confirm the CSV profile now shows in the dropdown Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard <maryse.simard(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5087] Option to not show CSV profiles in OPAC
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '20

21 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 13345] Choose the format when sending a basket/list by email
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '20

21 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel(a)gmail.com --- Comment #32 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- (In reply to Katrin Fischer from comment #28) > This is quite an old patch that changes more files than you'd think at first > glance. We got a sign-off from Nicole here, but it's from March 2015. Hope > it's ok, but I'd like to ask for a new sign off here. > > Tests pass and QA script too - I like to see the amount of 'red' (removed > code) too. Signed both patches, but sending a list by email fails because there is a forgotten call to GetMember, follow-up added -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13345] Choose the format when sending a basket/list by email
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '20

21 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 --- Comment #31 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 103435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103435&action=e… Bug 13345: follow-up remove call to GetMember This followup removes a forgotten call to GetMember -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13345] Choose the format when sending a basket/list by email
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '20

21 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101999|0 |1 is obsolete| | --- Comment #30 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 103434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103434&action=e… Bug 13345: Fix BuildBiblioDataForExport tests Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13345] Choose the format when sending a basket/list by email
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '20

21 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101998|0 |1 is obsolete| | --- Comment #29 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 103433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103433&action=e… Bug 13345: Allow patrons to choose format on sending basket/list by email It is already possible to download a basket(cart) or a list using different format. But by email, only iso2709 is possible. This patch adds the ability to select a format for the file attached to the email when sending the basket/list content. Test plan: 1/ At the OPAC, add some records to your basket and send it by email using different formats (RIS, BibTeX, MARC and the CSV profiles defined). 2/ At the OPAC, add some records to a list and send it by email using the different formats. 3/ Redo step 1 at the intranet 4/ Redo step 2 at the intranet Note that subtitles are not displayed in all these cases. Note for QA: This patch refactors 3 main things: 1/ Template side: the dropdown list to select the format is now in an include file (indeed, this list is used in 4 templates, this will make easier further changes). The include files are named 'download-export-available-formats.inc', feel free to suggest something better. The are used in: [opac-]sendbasket.tt, [opac-]sendshelf.tt, [opac-]downloadbasket.tt and [opac-]downloadshelf.tt. 2/ Build records data and the records file This job was done in 4 scripts: - opac/opac-sendbasket.pl - opac/opac-sendshelf.pl - basket/sendbasket.pl - virtualshelves/sendshelf.pl Now it's done in C4::Biblio::BuildBiblioDataForExport and tests are provided in t/db_dependent/Biblio/BuildBiblioDataForExport.t Not that a similar job is done in [opac-]downloadcart.pl and [opac-]downloadshelf.pl 3/ Build the subject and body of the email sent Same as before, the job was done at the same places. Now it's done in Koha::Email->fill_body_for_sending (feel free to suggestion a better name) and tests are provided in t/Koha_Email.t Sponsored-by: Mines Paristech Signed-off-by: Nicole C. Engard <nengard(a)bywatersolutions.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Test pass and mail sent, no errors. But a follow-up to remove useless call to GetMember is needed for email list to work. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14866] Make high holds work with different item types and number of open days
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '20

21 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103323|0 |1 is obsolete| | --- Comment #12 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 103427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103427&action=e… Bug 14866: Make high holds work with different item types To test: 1) Apply patch, update database, restart services 2) Enable decreaseLoanHighHolds sysprefs if not already active 3) Go to circulation rules and set a value under 'Decrease loan holds (day)' that is DIFFERENT from decreaseLoanHighHoldsDuration 4) Check out an item with holds and confirm that the value from the rule is used instead of the system preference 5) Confirm tests pass before and after the patch t/db_dependent/DecreaseLoanHighHolds.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '20

21 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92961|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '20

21 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92960|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '20

21 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92959|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0