April 2020 - Koha-bugs - lists.koha-community.org

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '20

20 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #290 from David Cook <dcook(a)prosentient.com.au> --- I've looked more at Bug 22417, and it's got me thinking. The OAI-PMH harvester has a few core needs: 1. Instant communication between Web UI and OAI-PMH harvester to coordinate harvesting tasks 2. Ability to schedule tasks 3. Ability to execute and repeat download tasks in parallel in the background 4. Ability to save downloaded records 5. Ability to import records into Koha The first is achieved by exchanging JSON messages over a Unix socket. (I'd actually like to change this to a TCP socket and use JSON messages over a HTTP API. Using HTTP would make it easier to communicate over a network, simplify the client code using standard communications mechanisms, and has authentication methods which could help to secure the OAI-PMH harvester. I could also provide a Docker image that contains the OAI-PMH harvester in a separate Docker container from the Koha application server.) This works fairly well and is easy enough to achieve. The second is provided by a bespoke scheduler using POE timers built into the OAI-PMH harvester. Given the granularity of the scheduling, I don't see this changing any time soon. In theory, a generic Koha task scheduler could replace this functionality, but that seems unlikely any time soon. This is arguably one of the most complex parts of the OAI-PMH harvester. Currently, the OAI-PMH uses an in-memory queue for download tasks, and a database queue for import tasks. I thought a lot about how RabbitMQ might be used to replace these queues. It could be useful to replace the in-memory download queue, and the download workers could be split out of the existing OAI-PMH harvester. As for the import tasks, the download workers need to save the records and enqueue an import task ASAP. At the moment, they save the records to disk, and add an import task to the database with a pointer to the records on disk. It works well enough, but it assumes that you have the disk space, and that the import worker has access to the local disk. I've been thinking it would be better to either 1) save the records to the database and enqueue a RabbitMQ message with a pointer to the database, or 2) send the records in a RabbitMQ message. I think the 1st option is probably better, because there is increased visibility. You can't see all the messages in a RabbitMQ queue. That all said, saving to disk is going to be faster than sending the data over a network. (However, in the past I think that I've sent individual records over the network. In this case, I'd be sending whole batches of records at once.) But for a download worker to send records, it would need credentials for either the database or RabbitMQ... so I'm thinking that perhaps it would be better to use an import API with an API key, although that would involve receiving all the data over the network and then sending it to the database. Also slow. But haven't tested the actual speeds. The import API would save the data to the database, and then enqueue an import task. Of course, this would just be a re-working of what's already here. The benefits of re-working the queues and workers are arguable at this point, although there is certainly benefits of changing from a bespoke client/server communication protocol to HTTP over TCP. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24614] New: Can't edit reports if not using cache
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '20

20 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24614 Bug ID: 24614 Summary: Can't edit reports if not using cache Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org To test: Enable strict mode Disable/stop memcached Create a report (note you don't see the cache expiry option) Try to edit the report It fails Enable memcached You get the cache expiry option back You can edit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 24760] New: BackgroundJob tests fail with latest versions of YAML or YAML::Syck
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '20

20 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24760 Bug ID: 24760 Summary: BackgroundJob tests fail with latest versions of YAML or YAML::Syck Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org YAML 1.30 and YAML::Syck 1.32 introduce a breaking change : they won't bless loaded objects by default, and t/db_dependent/BackgroundJob.t fail when this feature is disabled. I don't know this module very well, but I think that the tests are broken. C4::BackgroundJob::fetch already bless the object returned from $session->param, so we don't need to test that $session->param returns a blessed object. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 23383] New: IdRef link appears even with syspref is off
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '20

20 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23383 Bug ID: 23383 Summary: IdRef link appears even with syspref is off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org IdRef link is displayed via XSLT. There is a test of syspref with just if value is defined. But in installer/data/mysql/sysprefs.sql you see this pref will be 0 by default, which is true in XPATH. We should test that pref is 1. -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 24851] New: No sample libraries for UNIMARC installations
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '20

20 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24851 Bug ID: 24851 Summary: No sample libraries for UNIMARC installations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org I am trying to make koha-testing-docker UNIMARC compabible. In order to have koha-misc4dev insert all the data correctly (users, etc.) we need at least 1 library. I am suggesting to reuse the usual library list for UNIMARC. -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 24518] New: Partner filtering does not work in IE11
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '20

20 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518 Bug ID: 24518 Summary: Partner filtering does not work in IE11 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com We're doing something like this to hide options that are not applicable to the current filtering string: $('#my_select_option').hide(); This applies the following CSS rule to the <option> element: display: none It turns out that IE won't hide option elements. So, that's annoying. We have a couple of choices here. We could either clone the entire list of partners, filter out the ones that don't match the search string and then use the remainder to repopulate the <option> elements. Or we could wrap the <options> in something that IE11 will apply display:none to, such as a <span> or something. However, this will lead to something that is semantically incorrect for HTML5, since a <select> can only have <option> or <optgroup> as it's children. Despite the first option feeling a bit gnarly, I'm going to go for that as it will fix the problem and not lead to broken markup. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 23411] New: SMS messages should not fall back to 'email'
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '20

20 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23411 Bug ID: 23411 Summary: SMS messages should not fall back to 'email' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Bug 15967 ensured that an email notice that falls back to print when the patron has no email will send a print notice using the email template if there is no print template. When SMS and fallback were added this means that an SMS message where there is no SMS template will use the email template - it shouldn't as SMS messages need to be shorter, we should instead fail sending SMS if no SMS template defined -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 24250] New: SIP2 returns debarred comment twice in patron screen message AF field
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '20

20 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24250 Bug ID: 24250 Summary: SIP2 returns debarred comment twice in patron screen message AF field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com To recreate: 1 - Setup SIP in your testing environment https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 2 - Set a patron to have a restriction 3 - Send a patron status request or patron information command via the SIP cli emulator (see link above) 4 - Note the comment on the restriction is sent twice -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 24324] New: delete_records_via_leader.pl cron error with item
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '20

20 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24324 Bug ID: 24324 Summary: delete_records_via_leader.pl cron error with item Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: danielle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz This cron gives the following error when run with the -i option but not without. /usr/share/koha/bin/cronjobs/delete_records_via_leader.pl -c -i -v > /var/lib/koha/redacted/d_leader_deleted_bib.log The method Koha::Items->itemnumber is not covered by tests! Trace begun at /usr/share/koha/lib/Koha/Objects.pm line 389 Koha::Objects::AUTOLOAD('Koha::Items=HASH(0x7c1ce60)') called at /usr/share/koha/bin/cronjobs/delete_records_via_leader.pl line 100 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 14369] Only show 'Create labels' link on staged records import when status is 'Imported'
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '20

19 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14369 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103204|0 |1 is obsolete| | --- Comment #7 from David Nind <david(a)davidnind.com> --- Created attachment 103225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103225&action=e… Bug 14369: Only show 'Create labels' link on staged records import when status is imported The label creator won't be able to add a batch for items, if they are not imported into the database (missing itemnumber). This patch hides the link, when the status is not imported to avoid the error situation. To test: - Export a record with items from your Koha installation - Delete record and items - Stage the record with the items - the "Create labels" link should be showing - Try to create the labels - note error - Apply patch - Retry - the link should no longer show - Import the records - the should show now - Crate labels again - a new batch should have been created - Verify the link on the batch # leads to the batch in the labels module Bonus: Moves the message from the .pl file to the template to make it translatable. Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0