April 2020 - Koha-bugs - lists.koha-community.org

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '20

08 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #36 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Many thanks everyone! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '20

08 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #35 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '20

08 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23435] New: Add multiple copies of an item when receiving in serials
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '20

08 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23435 Bug ID: 23435 Summary: Add multiple copies of an item when receiving in serials Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com This feature would only be available for subscriptions that have been configured to create an item record when receiving a serial. When receiving or editing a serial (serials-edit.pl), there is currently a link 'Click to add item'. When saving the serial, an item record is also created with the details entered in the item form. We would like to add a feature that allows multiple (a specified number of) item records to be created when receiving a serial. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '20

08 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #34 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Hi Jonathan, Ah OK yes that makes sense. Many thanks for rebasing my patches and adding that follow up to pre-fill the renew form! Thanks, Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '20

08 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #33 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Hello Alex, I squashed your patches for readability (sub renamed, etc.). Also the follow-up restores a previous behaviour, we need to pre-fill the renew form with info from the previous renew. (In reply to Jonathan Druart from comment #30) > I am working on this, I do not think it works correctly. It did, apart from the pre-fill, it was my follow-up! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '20

08 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #32 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 102538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102538&action=e… Bug 7046: Preselect dropdown option and prefill input With previous renew values Bug 7046: Simplify dropdown list construction Bug 7046: Remove "earlier declaration in same scope" "my" variable $numberpattern masks earlier declaration in same scope at /kohadevbox/koha/serials/subscription-add.pl line 437. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '20

08 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102427|0 |1 is obsolete| | Attachment #102428|0 |1 is obsolete| | Attachment #102429|0 |1 is obsolete| | Attachment #102430|0 |1 is obsolete| | Attachment #102535|0 |1 is obsolete| | Attachment #102536|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 102537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102537&action=e… Bug 7046: Implemented subscription renewal dropdown sub length element To make this work I moved the _get_sub_length function from subscription-add.pl to C4/Serials.pm so that the subscription-renew.pl script could also call it to store the sublength for the appropriate field of the subscriptions database table. Test plan: 1. Create a subscription and notice that there is a dropdown box for sub length containing the values: issues, weeks, months 2. Renew the subscription and notice that there are 3 input text boxes: 'number of num', 'number of weeks' and 'number of months' 3. Input a 'Number of weeks' value of 2 4. Query the subscription database table and notice that the value of 2 has been stored in the weeklength field for the subscription record you just renewed 5. Apply the patch 6. Renew the subscription and notice that there is now a sublength dropdown box containing issues, weeks and months 7. Set the month value to 3 8. Query the database and notice that 3 was stored in the monthlength field for the subscription record 9. Create a new subscription and select the sub length values of issues and 3 10. Query the database and notice that the numberlength field for the subscription you just created is set to 3 showing that the sublength dropbox is still working for creating a new subscription Sponsored-By: Catalyst IT Patch applies and functions as expected in line with test plan. Signed-off-by: Dilan Johnpullé <dilan(a)calyx.net.au> Signed-off-by: David Nind <david(a)davidnind.com> Bug 7046: (follow-up) Tidy up to address test feedback * Removed underscores from start of subroutine * Removed tabs in subscription-renew.tt * Added test for C4/Serials/getsublength() in t/db_dependen/Serials/ReNewSubscription.t * Added missing filters Sponsored-By: Catalyst IT Signed-off-by: David Nind <david(a)davidnind.com> Bug 7046: (follow-up) Changed subroutine name and added unit tests * Fixed uninitialised value in $subtype in C4/Serials.pm line 1468 * Fixed sub routine name to 'GetSubscriptionLength' * Removed sublength param from being in value of sublength HTML input field * Added more unit tests to include bad params: undef, letters and special characters Test plan: Please follow test plan in first patch Sponsored-By: Catalyst IT Signed-off-by: David Nind <david(a)davidnind.com> Bug 7046: (follow-up) Update function call in subscription-add.pl Also removed border around Subscription length in subscription-renew.tt Test plan: Please follow test plan in first patch Sponsored-By: Catalyst IT Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '20

08 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '20

08 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|josef.moravec(a)gmail.com | Status|Signed Off |BLOCKED --- Comment #30 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I am working on this, I do not think it works correctly. -- You are receiving this mail because: You are watching all bug changes.

1 0