April 2020 - Koha-bugs - lists.koha-community.org

[Bug 25018] New: Jenkins is not running the test with $ENV{_} eq 'prove'
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '20

06 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25018 Bug ID: 25018 Summary: Jenkins is not running the test with $ENV{_} eq 'prove' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org In some tests we want to know if we are in a testing environment. When run the usual way, our trick works, the perl interpreter matches 'prove': $ENV{_} eq 'prove' In other situations, we have the KOHA_NO_TABLE_LOCKS environment variables, for the SendCirculationAlert race conditions (see bug 15854 and bug 18364). For unknown reasons, Jenkins runs the tests with /usr/bin/perl. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '20

06 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #26 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Thank you very much David! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '20

06 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102425|0 |1 is obsolete| | --- Comment #25 from David Nind <david(a)davidnind.com> --- Created attachment 102430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102430&action=e… Bug 7046: (follow-up) Update function call in subscription-add.pl Also removed border around Subscription length in subscription-renew.tt Test plan: Please follow test plan in first patch Sponsored-By: Catalyst IT Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '20

06 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102278|0 |1 is obsolete| | --- Comment #24 from David Nind <david(a)davidnind.com> --- Created attachment 102429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102429&action=e… Bug 7046: (follow-up) Changed subroutine name and added unit tests * Fixed uninitialised value in $subtype in C4/Serials.pm line 1468 * Fixed sub routine name to 'GetSubscriptionLength' * Removed sublength param from being in value of sublength HTML input field * Added more unit tests to include bad params: undef, letters and special characters Test plan: Please follow test plan in first patch Sponsored-By: Catalyst IT Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '20

06 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102276|0 |1 is obsolete| | --- Comment #23 from David Nind <david(a)davidnind.com> --- Created attachment 102428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102428&action=e… Bug 7046: (follow-up) Tidy up to address test feedback * Removed underscores from start of subroutine * Removed tabs in subscription-renew.tt * Added test for C4/Serials/getsublength() in t/db_dependen/Serials/ReNewSubscription.t * Added missing filters Sponsored-By: Catalyst IT Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '20

06 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102275|0 |1 is obsolete| | --- Comment #22 from David Nind <david(a)davidnind.com> --- Created attachment 102427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102427&action=e… Bug 7046: Implemented subscription renewal dropdown sub length element To make this work I moved the _get_sub_length function from subscription-add.pl to C4/Serials.pm so that the subscription-renew.pl script could also call it to store the sublength for the appropriate field of the subscriptions database table. Test plan: 1. Create a subscription and notice that there is a dropdown box for sub length containing the values: issues, weeks, months 2. Renew the subscription and notice that there are 3 input text boxes: 'number of num', 'number of weeks' and 'number of months' 3. Input a 'Number of weeks' value of 2 4. Query the subscription database table and notice that the value of 2 has been stored in the weeklength field for the subscription record you just renewed 5. Apply the patch 6. Renew the subscription and notice that there is now a sublength dropdown box containing issues, weeks and months 7. Set the month value to 3 8. Query the database and notice that 3 was stored in the monthlength field for the subscription record 9. Create a new subscription and select the sub length values of issues and 3 10. Query the database and notice that the numberlength field for the subscription you just created is set to 3 showing that the sublength dropbox is still working for creating a new subscription Sponsored-By: Catalyst IT Patch applies and functions as expected in line with test plan. Signed-off-by: Dilan Johnpullé <dilan(a)calyx.net.au> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '20

06 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20674] New: One off report
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '20

06 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20674 Bug ID: 20674 Summary: One off report Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: tlamannajr(a)chplnj.org QA Contact: testopia(a)bugs.koha-community.org Right now the only way to create and run a report is to save it to a list, but there are plenty of times I just need a one-off report and it's a bit of a pain to have to create and name a report then delete in when I'm done. This clutters up the reports list a lot. Not a massive problem, but I'm hoping we can streamline one off reports. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '20

06 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #21 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Hi David, That should now be fixed up. I also removed the border around the subscription length in subscription-renew.tt so that it is centered on the page along with the other labels and inputs. Can you please re-test? Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 06 Apr '20

06 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #20 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 102425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102425&action=e… Bug 7046: (follow-up) Update function call in subscription-add.pl Also removed border around Subscription length in subscription-renew.tt Test plan: Please follow test plan in first patch Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0