April 2020 - Koha-bugs - lists.koha-community.org

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '20

01 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #122 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 102195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102195&action=e… Bug 4461: Use our local_referer instead of HTTP_REFERER Cannot remember why exactly, but it seems that we should not use HTTP_REFERER directly. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '20

01 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #121 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 102194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102194&action=e… Bug 4461: Use KohaAdminEmailAddress pref as 'from' We usually do not specify the from_address on enqueuing the notice, but when sending it (from _send_message_by_email). That way a) the code is centralized (as we must use $patron->notice_email_address) and b) the email used is the one that is in the DB when the letter is effectively sent. Here I guess you need to give it when the notice is enqueued as you want to default to the koha admin address. I do not think it's a good idea, we should not send an email with "from" if not really sent by the user. We have the borrowernumber anyway to know who filled the form. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '20

01 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #120 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 102193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102193&action=e… Bug 4461: Rename report date with created_on And make it a timestamp type column Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '20

01 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #119 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 102192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102192&action=e… Bug 4461: (follow-up) Creating sample notice and other fixes - filters - capitalisation - atomic update Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '20

01 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #118 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 102191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102191&action=e… Bug 4461: (follow-up) Redirect to 404 if OPACProblemReport not enabled Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '20

01 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #117 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 102190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102190&action=e… Bug 4461: Submit a problem report To test: 1) Apply patch, update database, rebuild schema file 2) Restart koha-common and memcached 3) Confirm that your user has an email address. 4) Confirm that your library does NOT have an email address. 5) Confirm that syspref KohaAdminEmailAddress and syspref ReplytoDefault are not filled. Enable the OPACReportProblem syspref. 6) Log into OPAC 7) Click the 'Report a problem' link at the bottom of whatever page you're on 8) Notice that there is no form is and there is an error message alerting that reports cannot be submitted 9) Add an email address for your library (in either the email field or the replyto field). Refresh the OPAC problem report page. The form should now show, and the recipient field should say 'library'. 10) Complete the form and submit. Check the message_queue in the database and confirm the to_address is correct. Confirm there is a success message. 11) Add an email address for the syspref KohaAdminEmailAddress and refresh the OPAC problem report page again. The recipient field should now be a dropdown. Select the Koha Administrator option. 12) Complete the form and submit. Check the message_queue in the database and confirm the to_address is the value in KohaAdminEmailAddress. Confirm there is a success message. 13) Ensure all details in the message_queue are correct. 14) Log out of the OPAC 15) Click the Report a problem link again and confirm you are forced to log in Sponsored-by: Catalyst IT Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '20

01 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #116 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 102189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102189&action=e… Bug 4461: Problem Report Koha objects Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '20

01 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100506|0 |1 is obsolete| | Attachment #100507|0 |1 is obsolete| | Attachment #100508|0 |1 is obsolete| | Attachment #100509|0 |1 is obsolete| | Attachment #100510|0 |1 is obsolete| | Attachment #100511|0 |1 is obsolete| | Attachment #100512|0 |1 is obsolete| | Attachment #100513|0 |1 is obsolete| | Attachment #100514|0 |1 is obsolete| | Attachment #100515|0 |1 is obsolete| | Attachment #100516|0 |1 is obsolete| | Attachment #100517|0 |1 is obsolete| | Attachment #100518|0 |1 is obsolete| | Attachment #100519|0 |1 is obsolete| | Attachment #100520|0 |1 is obsolete| | Attachment #100521|0 |1 is obsolete| | Attachment #100522|0 |1 is obsolete| | Attachment #100523|0 |1 is obsolete| | Attachment #100524|0 |1 is obsolete| | Attachment #100619|0 |1 is obsolete| | Attachment #100989|0 |1 is obsolete| | Attachment #100990|0 |1 is obsolete| | --- Comment #115 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 102188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102188&action=e… Bug 4461: Database and syspref changes adding problem_reports table and OPACReportProblem syspref Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '20

01 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '20

01 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david(a)davidnind.com --- Comment #114 from David Nind <david(a)davidnind.com> --- Patch no longer applies 8-(: root@9512ab8ec1bb:koha(bz4461)$ git bz apply 4461 Bug 4461 - Context-sensitive report a problem screen 100506 - Bug 4461: Database and syspref changes 100507 - Bug 4461: Problem Report Koha objects 100508 - Bug 4461: Submit a problem report 100509 - Bug 4461: (follow-up) Redirect to 404 if OPACProblemReport not enabled 100510 - Bug 4461: (follow-up) Creating sample notice and other fixes 100511 - Bug 4461: Rename report date with created_on 100512 - Bug 4461: Use KohaAdminEmailAddress pref as 'from' 100513 - Bug 4461: Use our local_referer instead of HTTP_REFERER 100514 - Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined 100515 - Bug 4461: Simplify recipients code 100516 - Bug 4461: Better error handling 100517 - Bug 4461: Remove hard requirement on OpacKohaUrl 100518 - Bug 4461: Drop 'from_address' use 'reply_address' 100519 - Bug 4461: Use get_effective_email from bug 22823 100520 - Bug 4461: Adding user flags for managing OPAC problem reports 100521 - Bug 4461: Add problem reports link to mainpage and admin home 100522 - Bug 4461: Manage problem reports on the staff client 100523 - Bug 4461: (follow-up) Add missing relationship accessor 100524 - Bug 4461: DBIC Schema Files 100619 - Bug 4461: Update license statements 100989 - Bug 4461: Fix status and borrowernumber fields in problem_reports and more 100990 - Bug 4461: Checks on library email before enqueuing letter Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 4461: Database and syspref changes error: sha1 information is lacking or useless (installer/data/mysql/kohastructure.sql). error: could not build fake ancestor Patch failed at 0001 Bug 4461: Database and syspref changes -- You are receiving this mail because: You are watching all bug changes.

1 0