April 2020 - Koha-bugs - lists.koha-community.org

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '20

01 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #116 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 102189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102189&action=e… Bug 4461: Problem Report Koha objects Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '20

01 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100506|0 |1 is obsolete| | Attachment #100507|0 |1 is obsolete| | Attachment #100508|0 |1 is obsolete| | Attachment #100509|0 |1 is obsolete| | Attachment #100510|0 |1 is obsolete| | Attachment #100511|0 |1 is obsolete| | Attachment #100512|0 |1 is obsolete| | Attachment #100513|0 |1 is obsolete| | Attachment #100514|0 |1 is obsolete| | Attachment #100515|0 |1 is obsolete| | Attachment #100516|0 |1 is obsolete| | Attachment #100517|0 |1 is obsolete| | Attachment #100518|0 |1 is obsolete| | Attachment #100519|0 |1 is obsolete| | Attachment #100520|0 |1 is obsolete| | Attachment #100521|0 |1 is obsolete| | Attachment #100522|0 |1 is obsolete| | Attachment #100523|0 |1 is obsolete| | Attachment #100524|0 |1 is obsolete| | Attachment #100619|0 |1 is obsolete| | Attachment #100989|0 |1 is obsolete| | Attachment #100990|0 |1 is obsolete| | --- Comment #115 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 102188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102188&action=e… Bug 4461: Database and syspref changes adding problem_reports table and OPACReportProblem syspref Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '20

01 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '20

01 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david(a)davidnind.com --- Comment #114 from David Nind <david(a)davidnind.com> --- Patch no longer applies 8-(: root@9512ab8ec1bb:koha(bz4461)$ git bz apply 4461 Bug 4461 - Context-sensitive report a problem screen 100506 - Bug 4461: Database and syspref changes 100507 - Bug 4461: Problem Report Koha objects 100508 - Bug 4461: Submit a problem report 100509 - Bug 4461: (follow-up) Redirect to 404 if OPACProblemReport not enabled 100510 - Bug 4461: (follow-up) Creating sample notice and other fixes 100511 - Bug 4461: Rename report date with created_on 100512 - Bug 4461: Use KohaAdminEmailAddress pref as 'from' 100513 - Bug 4461: Use our local_referer instead of HTTP_REFERER 100514 - Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined 100515 - Bug 4461: Simplify recipients code 100516 - Bug 4461: Better error handling 100517 - Bug 4461: Remove hard requirement on OpacKohaUrl 100518 - Bug 4461: Drop 'from_address' use 'reply_address' 100519 - Bug 4461: Use get_effective_email from bug 22823 100520 - Bug 4461: Adding user flags for managing OPAC problem reports 100521 - Bug 4461: Add problem reports link to mainpage and admin home 100522 - Bug 4461: Manage problem reports on the staff client 100523 - Bug 4461: (follow-up) Add missing relationship accessor 100524 - Bug 4461: DBIC Schema Files 100619 - Bug 4461: Update license statements 100989 - Bug 4461: Fix status and borrowernumber fields in problem_reports and more 100990 - Bug 4461: Checks on library email before enqueuing letter Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 4461: Database and syspref changes error: sha1 information is lacking or useless (installer/data/mysql/kohastructure.sql). error: could not build fake ancestor Patch failed at 0001 Bug 4461: Database and syspref changes -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '20

01 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102067|0 |1 is obsolete| | --- Comment #34 from David Nind <david(a)davidnind.com> --- Created attachment 102175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102175&action=e… Bug 14367: (follow-up) Rebasing to make patch work on master Run through test plan and confirm everything still works as expected. Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '20

01 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102066|0 |1 is obsolete| | --- Comment #33 from David Nind <david(a)davidnind.com> --- Created attachment 102174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102174&action=e… Bug 14367: (follow-up) Fixing merge conflicts... ...and other fixes to make patch work. Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '20

01 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102065|0 |1 is obsolete| | --- Comment #32 from David Nind <david(a)davidnind.com> --- Created attachment 102173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102173&action=e… Bug 14367: Add MARC record history This is a proof-of-concept implementation for adding history support to MARC records. Every time a change is made a complete copy of the record is stored along with the date/time and user identity. The changes are listed under each field in the MARC record editor and can be reverted with a click. The changes are stored as a JSON array in a new column named 'history' in the database. The array is re-read from the database before updating the record to prevent old data lingering in the session from overwriting newer changes made by other users. If we decide to implement this feature it might be better to simply create a new table altogether and link it rather than the clumsy JSON solution. That would eliminate a lot of bulky code that transforms MARC-KOHA-JSON and back while ensuring data integrity. Also, there are plans to add permissions to the MARC records; this likely requires more complex interactions that will scale badly with the current JSON solution. At present, the history is hardcoded to 10 entries. This can easily be made into a syspref. The current implementation should probably be refactored into a 'BiblioHistory' class before deploying. Documentation of the functions/methods are also needed. Icon is ugly and needs to be improved. Sponsored-By: Halland County Library & Catalyst IT Test plan: * Run updatedatabase.pl * Log into Staff interface, search for a title, choose to edit it's MARC record. * Chose a MARC field and modify it, press Save. * Open the MARC editor again for the same title. * Next to the edited field a new icon should appear, looking like a clock face with a encircling arrow; the history icon. * Clicking the icon should open a table showing all changes done to the record, including value change, date/time and user name. * Clicking a record in the history log should revert that field to the clicked value (a previous value) * Run prove t/db_dependent/BiblioHistory.t and confirm all tests pass Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '20

01 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5158] Koha needs its own cookie, ice cream, and fudge flavors
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '20

01 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5158 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #10 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Martin Renvoize from comment #9) > My submission is the wonderfully weird and tasty Peanut butter, Chocolate > chip and Bacon cookie > > https://www.google.com/amp/s/www.foodnetwork.com/recipes/food-network- > kitchen/peanut-butter-chocolate-chip-bacon-cookies-recipe-1973911.amp I'm not much of a baker, but that sounds fun. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 12469] Add more information to the ILS-DI results
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '20

01 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12469 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from David Nind <david(a)davidnind.com> --- Sorry Arthur, now that I'm a bit more familiar with ILS-DI I've retested and found some issues 8-(: 1) Showing the call number works fine. 2) The branch shows, but is incorrect when the item is checked out. In the ILS-DI results below item 21 belongs to Centerville and item 22 belongs to Fairview, but Centerville is shown for both. 3) The tests now fail: root@d3e7d16216fc:koha(bz12469)$ prove t/db_dependent/ILSDI_Services.t t/db_dependent/ILSDI_Services.t .. 7/10 Use of uninitialized value $charge in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 3007. t/db_dependent/ILSDI_Services.t .. 9/10 # Looks like you planned 10 tests but ran 11. t/db_dependent/ILSDI_Services.t .. Dubious, test returned 255 (wstat 65280, 0xff00) All 10 subtests passed Test Summary Report ------------------- t/db_dependent/ILSDI_Services.t (Wstat: 65280 Tests: 11 Failed: 1) Failed test: 11 Non-zero exit status: 255 Parse errors: Bad plan. You planned 10 tests but ran 11. Files=1, Tests=11, 12 wallclock secs ( 0.04 usr 0.00 sys + 8.52 cusr 1.08 csys = 9.64 CPU) Result: FAIL 4) Adding due dates: this seems to only show the current date and time - for a record with 2 items, I checked both out (item 21 and 22 - due date 6 April 2020 for both); with the URL cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=21+22&id_type=item I get the ILS-DI results returned below - availability status is 'available' and 'dateavailable' is the currentt date for both. ILS-DI Results -------------- <dlf:collection xmlns:dlf="http://diglib.org/ilsdi/1.1" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://diglib.org/ilsdi/1.1 http://diglib.org/architectures/ilsdi/schemas/1.1/dlfexpanded.xsd"> <dlf:record> <dlf:bibliographic id="7"/> <dlf:items> <dlf:item id="21"> <dlf:simpleavailability> <dlf:identifier>21</dlf:identifier> <dlf:availabilitystatus>available</dlf:availabilitystatus> <dlf:location>Centerville</dlf:location> <dlf:callnumber>947.084/1092 B</dlf:callnumber> <dlf:dateavailable>2020-04-01T06:35:10</dlf:dateavailable> </dlf:simpleavailability> </dlf:item> </dlf:items> </dlf:record> <dlf:record> <dlf:bibliographic id="7"/> <dlf:items> <dlf:item id="22"> <dlf:simpleavailability> <dlf:identifier>22</dlf:identifier> <dlf:availabilitystatus>available</dlf:availabilitystatus> <dlf:location>Centerville</dlf:location> <dlf:callnumber>947.084/1092 B</dlf:callnumber> <dlf:dateavailable>2020-04-01T06:35:10</dlf:dateavailable> </dlf:simpleavailability> </dlf:item> </dlf:items> </dlf:record> </dlf:collection> -- You are receiving this mail because: You are watching all bug changes.

1 0