May 2020 - Koha-bugs - lists.koha-community.org

[Bug 11446] Authority not searching full corporate name with and (&) symbol
by bugzilla-daemon＠bugs.koha-community.org 15 May '20

15 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11446 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11446] Authority not searching full corporate name with and (&) symbol
by bugzilla-daemon＠bugs.koha-community.org 15 May '20

15 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11446 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103886|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 104924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104924&action=e… Bug 11446: Use encodeURIComponent on search terms in authority lookup plugin While adding the data from the existing field to the auth_finder URI, we're using encodeURI(), which is meant for an entire URI and thus doesn't escape &. Things that are going into a querystring need encodeURIComponent() instead. Test plan: 1. Enable the system preference EnableAdvancedCatalogingEditor 2. Clear your browser cache, even a shift+reload won't get you a fresh marc-editor.js for the advanced editor 3. Create a Topical Term authority with 150 $aThis & That$xStuff & Junk 4. In the Basic editor, use the authority plugin on the 650 field to select that authority. 5. Click the authority plugin again, verify that the popup contains This & That and Stuff & Junk rather than just This and Stuff 6. From the Cataloging home page choose Advanced editor 7. In a new line paste 650 _ _ ‡aThis & That‡xStuff & Junk 8. Type ctrl+shift+L and verify the popup shows both words in both fields 9. When you remember the plugin exists there too, edit your Stuff & Junk authority, and in a 550 tag type One & Two in $a and Three & Four in $x and click the plugin link, verify that the search window has your search terms not cut off. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11446] Authority not searching full corporate name with and (&) symbol
by bugzilla-daemon＠bugs.koha-community.org 15 May '20

15 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11446 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24700] New: Improve Mojo startup speed for REST APIs
by bugzilla-daemon＠bugs.koha-community.org 15 May '20

15 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700 Bug ID: 24700 Summary: Improve Mojo startup speed for REST APIs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: ere.maijala(a)helsinki.fi Currently the API spec is validated multiple times, and the whole spec loaded so far is re-validated for each (if any) REST API plugin. Coming up with a patch to avoid multiple validation unless the complete spec doesn't validate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 15 May '20

15 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 [Bug 25510] Typo in koha-common.postinst causing shell errors -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 25339] Validate biblionumber on opac-basket.pl and opac-review.pl
by bugzilla-daemon＠bugs.koha-community.org 15 May '20

15 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25339 --- Comment #7 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Jonathan Druart from comment #6) > Why did you pick those 2 scripts? And why only biblionumber? > Wise questions. They were flagged by a security consultant, so I fixed them locally, and posted the patches here to be upstreamed. > If you want to fix this problem (it is not really an issue imo), you should > do it all over the place, where we retrieve a variable that is supposed to > be an id and we send it back to the template. I am pretty sure there are > others. > As you say, it's not really a (critical) issue, as we've got the XSS risk handled by the templates. Imho, it's just a bit embarrassing that we don't validate the data more - but not problematic per se. That said, I don't see an issue with patching it in some places and not all places. (After all, previous efforts by Jared seem to have only patched it in some places and not all places.) I agree that there are certainly other places where this happens too. > That being said, I don't see biblionumber passed to the template from > opac-review.pl. Good catch! The reason is actually rather amusing. It appears Bug 25340 (a bug I reported the same day as this one but Owen fixed) removed the biblionumber issue from opac-review.pl as well. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8338] Fines not cleared with dropbox mode
by bugzilla-daemon＠bugs.koha-community.org 15 May '20

15 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #24 from Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> --- Oh, I should mention that in the course of your test plan I ran into an unrelated error. Confirmed it happens without your patch, filed bug 25508 for it. At step 5 of test 2, when you pay off the fine, Koha gets weird about whether or not it should renew the overdue item. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10337] Add a script to insert all sample data automatically
by bugzilla-daemon＠bugs.koha-community.org 15 May '20

15 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337 --- Comment #18 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Jonathan Druart from comment #17) > Related bug removed it Thanks, Jonathan. I was looking at a slightly out of date 19.11 😅 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 25072] New: Printing details.tt is broken
by bugzilla-daemon＠bugs.koha-community.org 15 May '20

15 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25072 Bug ID: 25072 Summary: Printing details.tt is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com When printing the details.tt page on the staff client there is a large amount of white space on the left side. Looking at print.css, we hide #menu but it (or something else) still looks to be taking up space on the left. TO RECREATE: -Search for something in the catalog and go to the details page. -Try to print either for the Print button in Koha or File->Print... -Notice the large amount of whitespace on the left -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 25300] New: Edit details in "Library use" section uses bad $op for Expiration Date
by bugzilla-daemon＠bugs.koha-community.org 15 May '20

15 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25300 Bug ID: 25300 Summary: Edit details in "Library use" section uses bad $op for Expiration Date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com In the "Library use" section on the Details page for a patron for an expired/epiring patron, the "Edit details" link uses op=modify], which looks like it works (ie it doesn't explode), but it doesn't work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11