May 2020 - Koha-bugs - lists.koha-community.org

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 15 May '20

15 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93487|0 |1 is obsolete| | --- Comment #293 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 104932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104932&action=e… Bug 11708: Fix PDF export Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 15 May '20

15 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93485|0 |1 is obsolete| | --- Comment #292 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 104931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104931&action=e… Bug 11708: Use bootstrap grid instead of yui Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 15 May '20

15 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93484|0 |1 is obsolete| | --- Comment #291 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 104930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104930&action=e… Bug 11708: Add missing POD in Koha::Acquisition::Basket Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 15 May '20

15 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93483|0 |1 is obsolete| | --- Comment #290 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 104929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104929&action=e… Bug 11708: New page for basket groups This patch moves the code responsible for displaying a list of basket groups into its own Perl script (acqui/basketgroups.pl), making the code in basketgroup.pl and basketgroup.tt a little bit easier to read. basketgroups.pl displays all basket groups in a single table (as bug 13371 for vendors) where rows are grouped by bookseller. This patch also adds 3 columns: - No. of ordered titles - No. of received titles - Date closed It also adds a wrapper around the new DataTable() constructor to be able to use it with the same defaults than the previous dataTable() constructor Test plan: 0. Create a bunch of booksellers and basketgroups 1. Go back to acquisitions home page and click on "Basket groups" link on the left 2. Play with the table (sort, filter) and try every possible actions (Edit, Close and export as PDF, View, Reopen, Export as CSV) 3. Go to a specific vendor page and click on "Basket groups" tab 4. Check that only the vendor's basket groups are displayed 5. prove t/db_dependent/Koha/Acquisition/Basket.t Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 15 May '20

15 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93482|0 |1 is obsolete| | --- Comment #289 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 104928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104928&action=e… Bug 11708: Change aqbasketgroups.closed to closeddate Signed-off-by: juliette levast <juliette.levast(a)iepg.fr> Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 25339] Validate biblionumber on opac-basket.pl and opac-review.pl
by bugzilla-daemon＠bugs.koha-community.org 15 May '20

15 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25339 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #8 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- + $biblionumber = int($biblionumber); I think we have a few places where we do that. And it is really ugly imo. If you dont pass a valid biblionumber, you should not get a valid response. Furthermore int does not like strings. We will have warnings like: Argument "3abc" isn't numeric in int I would rather get rid of the other places.. Changing status: ID or FQA ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11446] Authority not searching full corporate name with and (&) symbol
by bugzilla-daemon＠bugs.koha-community.org 15 May '20

15 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11446 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11446] Authority not searching full corporate name with and (&) symbol
by bugzilla-daemon＠bugs.koha-community.org 15 May '20

15 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11446 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103886|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 104924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104924&action=e… Bug 11446: Use encodeURIComponent on search terms in authority lookup plugin While adding the data from the existing field to the auth_finder URI, we're using encodeURI(), which is meant for an entire URI and thus doesn't escape &. Things that are going into a querystring need encodeURIComponent() instead. Test plan: 1. Enable the system preference EnableAdvancedCatalogingEditor 2. Clear your browser cache, even a shift+reload won't get you a fresh marc-editor.js for the advanced editor 3. Create a Topical Term authority with 150 $aThis & That$xStuff & Junk 4. In the Basic editor, use the authority plugin on the 650 field to select that authority. 5. Click the authority plugin again, verify that the popup contains This & That and Stuff & Junk rather than just This and Stuff 6. From the Cataloging home page choose Advanced editor 7. In a new line paste 650 _ _ ‡aThis & That‡xStuff & Junk 8. Type ctrl+shift+L and verify the popup shows both words in both fields 9. When you remember the plugin exists there too, edit your Stuff & Junk authority, and in a 550 tag type One & Two in $a and Three & Four in $x and click the plugin link, verify that the search window has your search terms not cut off. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11446] Authority not searching full corporate name with and (&) symbol
by bugzilla-daemon＠bugs.koha-community.org 15 May '20

15 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11446 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24700] New: Improve Mojo startup speed for REST APIs
by bugzilla-daemon＠bugs.koha-community.org 15 May '20

15 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24700 Bug ID: 24700 Summary: Improve Mojo startup speed for REST APIs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: ere.maijala(a)helsinki.fi Currently the API spec is validated multiple times, and the whole spec loaded so far is re-validated for each (if any) REST API plugin. Coming up with a patch to avoid multiple validation unless the complete spec doesn't validate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20