May 2020 - Koha-bugs - lists.koha-community.org

[Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #48 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Not sure this is a In discussion or a Failed QA. But the report dates from 2011 and the patch from 2013, so there must be a reason why this took so long. The first comments says "This may require a pref" too. Since we are used now to the current behavior since 2011/2013, I think we cannot revert behavior without a pref. Changing status -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #80 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #79) > "If an item is the last one of a biblio that have biblio-level hold > placed on it, we should block the deletion." > > Well, this is quite arguable. Imo probably cleanup_database could remove > holds that make no sense like biblio level holds when there are no items. > The same commit says: > "Note that there is something a bit weird as we are blocking items > from a biblio that has biblio-level holds on it (not found), but we > do not blocking the deletion of an item with a waiting item-level hold." > > Lets not push inconsistency but resolve it? Additional thought: Note that the user also has the choice to delete a biblio. If he wants to delete the biblio, the biblio level hold will be deleted too. So you could say that a choice to not delete the biblio, is a choice to keep the hold. Perhaps new items are to be expected here and the hold can be filled later. So delete the item. If you choose delete biblio too, we should not block the deletion of the hold. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #79 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- "If an item is the last one of a biblio that have biblio-level hold placed on it, we should block the deletion." Well, this is quite arguable. Imo probably cleanup_database could remove holds that make no sense like biblio level holds when there are no items. The same commit says: "Note that there is something a bit weird as we are blocking items from a biblio that has biblio-level holds on it (not found), but we do not blocking the deletion of an item with a waiting item-level hold." Lets not push inconsistency but resolve it? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #78 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Bit weird that sub safe_to_delete returns 1 or a string. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #77 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QAing -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #76 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt FAIL filters missing_filter at line 127 ( <td><input type="checkbox" name="itemnumber" value="[% item_loo.itemnumber | html %]" id="row[% item_loo.itemnumber | html %]" disabled="disabled" title="[% cannot_delete_reason %]"/></td>) missing_filter at line 261 ( [% cannot_delete_reason %]) -- You are receiving this mail because: You are watching all bug changes.

1 0