May 2020 - Koha-bugs - lists.koha-community.org

[Bug 13388] Add library pages to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104084|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 104096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104096&action=e… Bug 13388: (follow-up) Remove display of email address Since the email address configured for a library may not be the email address libraries want to use as a contact email address the email should not be displayed by default. This patch removes display of the email address. Libraries may choose to add the information to the opac_info column, so there is already a built-in alternative. To test, apply the patch and view the detail page for a library in your system which has an email address configured. The email address should not display on the page. Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13388] Add library pages to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104083|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 104095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104095&action=e… Bug 13388: Add library pages to the OPAC This patch adds a script and a template for showing library information pages in the OPAC. A "libraries" page lists all the libraries in the system, linking to individual pages for each library showing more information.. If there is only one library in the system the page shows all of that library's information. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staf…) - Go to /cgi-bin/koha/opac-library.pl in the OPAC. - Verify that all the correct information is displayed for the libraries in your system. - Verify that page title and breadcrumbs look correct. - Click to view details for a library. - The details page should show the full contents of branches.opac_info - A menu should show links to other libraries' detail pages. EDIT: This revised patch adds a "Libraries" link to the links under the search bar; Corrects encoding in the breadcrumb link; Makes the page title more specific when viewing an individual library. Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10910] Add a warn when deleting a patron with pending suggestions
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10910 Victor Grousset/tuxayo <victor(a)tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor(a)tuxayo.net Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 10910] Add a warn when deleting a patron with pending suggestions
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10910 Victor Grousset/tuxayo <victor(a)tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103903|0 |1 is obsolete| | --- Comment #9 from Victor Grousset/tuxayo <victor(a)tuxayo.net> --- Created attachment 104094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104094&action=e… Bug 10910: Add a warning when deleting a patron with pending suggestions Test plan: >From the OPAC, add a suggestion >From the staff interface, try to delete the patron who created the suggestion => You get a warning message Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 13388] Add library pages to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22823 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13388] Add library pages to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388 --- Comment #14 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Hmm.. I agree branchemail is probably incorrect as they may, in reality, want the reply-to address instead. I think this is pretty good as is, but a future enhancement would be nice to have behind a system preference for displaying email or not and then that should use the new method in Koha::Library. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13388] Add library pages to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388 Victor Grousset/tuxayo <victor(a)tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104081|0 |1 is obsolete| | --- Comment #13 from Victor Grousset/tuxayo <victor(a)tuxayo.net> --- Created attachment 104084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104084&action=e… Bug 13388: (follow-up) Remove display of email address Since the email address configured for a library may not be the email address libraries want to use as a contact email address the email should not be displayed by default. This patch removes display of the email address. Libraries may choose to add the information to the opac_info column, so there is already a built-in alternative. To test, apply the patch and view the detail page for a library in your system which has an email address configured. The email address should not display on the page. Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13388] Add library pages to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388 Victor Grousset/tuxayo <victor(a)tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104052|0 |1 is obsolete| | --- Comment #12 from Victor Grousset/tuxayo <victor(a)tuxayo.net> --- Created attachment 104083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104083&action=e… Bug 13388: Add library pages to the OPAC This patch adds a script and a template for showing library information pages in the OPAC. A "libraries" page lists all the libraries in the system, linking to individual pages for each library showing more information.. If there is only one library in the system the page shows all of that library's information. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staf…) - Go to /cgi-bin/koha/opac-library.pl in the OPAC. - Verify that all the correct information is displayed for the libraries in your system. - Verify that page title and breadcrumbs look correct. - Click to view details for a library. - The details page should show the full contents of branches.opac_info - A menu should show links to other libraries' detail pages. EDIT: This revised patch adds a "Libraries" link to the links under the search bar; Corrects encoding in the breadcrumb link; Makes the page title more specific when viewing an individual library. Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #85 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #84) > (In reply to Jonathan Druart from comment #83) > > (In reply to Marcel de Rooy from comment #82) > > > (In reply to Jonathan Druart from comment #81) > > > > What do you suggest? > > > > > > Maybe we should stick to the scope that the title suggests. Do not delete > > > items with holds. Biblio level holds are out of scope. > > > > No, it's the main point of this bug report. > > > > We want to prevent deletion of the last item of a bibliographic record with > > a biblio-level hold on it. > > Sorry, I can't agree on that reading comments and patches. See comment 0: """ I don't think it always did this - but I tested today on 3.8 and it deleted an item and a bib record (cause I checked that box) that had holds on it. """ Then comment 1: """ This is how you end up with phantom holds that can never be deleted. """ And comment 20. I can confirm that I wrote those patches to prevent such deletion, and so phantom holds. That's why I rebuilt a bit the interface to display the why an item cannot be deleted, and so introduced the new "last_item_for_hold" error code. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 01 May '20

01 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #84 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #83) > (In reply to Marcel de Rooy from comment #82) > > (In reply to Jonathan Druart from comment #81) > > > What do you suggest? > > > > Maybe we should stick to the scope that the title suggests. Do not delete > > items with holds. Biblio level holds are out of scope. > > No, it's the main point of this bug report. > > We want to prevent deletion of the last item of a bibliographic record with > a biblio-level hold on it. Sorry, I can't agree on that reading comments and patches. -- You are receiving this mail because: You are watching all bug changes.

1 0