June 2020 - Koha-bugs - lists.koha-community.org

[Bug 8338] Fines not cleared with dropbox mode
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '20

23 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #41 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106209&action=e… Bug 8338: (QA follow-up) Clean up warning This patch moves the accountline->store call below the FinesLog code such that we return the same 'thing' from _FixOverduesOnReturn as the other clauses of the routine. We also take the oportunity to clean up the warning thrown by an errant call to the routine such that we output the actual itemnumber rather than a HASH reference marker. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8338] Fines not cleared with dropbox mode
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '20

23 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #40 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Hmm... not it's not.. we already check for defined in the relevant line.. bit confused -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8338] Fines not cleared with dropbox mode
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '20

23 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #39 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Aha.. it's because with this patch the return of _FixAccountOnReturn is '0' as opposed to a result object.. but as the note says in the routine that doesn't signify an error. I'll add a little followup to clean up the warning.. not really even sure we need it at all now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8338] Fines not cleared with dropbox mode
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '20

23 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #38 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- The nasty looking warn is actually introduced with Bug 21206: Replace C4::Items::GetItem where `->{itemnumber}` is replaced with `->itemnumber`. You say the warning doesn't appear at all prior to the patch.. that feels odd.. I'll investigate that. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13961] Option to include patron's total amount of fines in notices
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '20

23 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Sally <sally.healey(a)cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13961] Option to include patron's total amount of fines in notices
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '20

23 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98821|0 |1 is obsolete| | --- Comment #25 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 106194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106194&action=e… Bug 13961: Add unit test Sponsored-by: Koha-Suomi Oy Signed-off-by: Sally <sally.healey(a)cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13961] Option to include patron's total amount of fines in notices
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '20

23 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98820|0 |1 is obsolete| | --- Comment #24 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 106193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106193&action=e… Bug 13961: Add currency format handling Sponsored-by: Koha-Suomi Oy Signed-off-by: Sally <sally.healey(a)cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13961] Option to include patron's total amount of fines in notices
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '20

23 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98819|0 |1 is obsolete| | --- Comment #23 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 106192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106192&action=e… Bug 13961: Option to include patron's total amount of fines in notices Possibility to show patrons's total amount of fines in notices. Test plan: 1. Apply patch 2. Modify some notice in Tools -> notices & slips 3. See that in the left side of where one can edit message's body is now also a new attribute that one can include to the text: borrowers.totalfine 4. Include that to the text and see it showing the patron's total amount of fines. Sponsored-by: Vaara-kirjastot Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Sally <sally.healey(a)cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22571] New: Bug in Perl module "Koha::SimpleMARC::field_equals"
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '20

23 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22571 Bug ID: 22571 Summary: Bug in Perl module "Koha::SimpleMARC::field_equals" Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: mik(a)adminkuhn.ch QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- After successfully creating a MARC modification template in Koha menu "Tools > Batch record modification" with the following action: Add new field 041$a with value ger if 008 matches RegEx m/^...................................ger..$/ the action is run over a given record and Koha says that the bibliographic record has successfully been modified - but in fact nothing has changed, thus no new MARC 041$a is created. According to Jonathan Druart (in mailinglist "Koha", 21.03.2019 17:12) this is a bug in Perl module "Koha::SimpleMARC::field_equals". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21

[Bug 23825] New: Object.t is failing - Exception not caught
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '20

23 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Bug ID: 23825 Summary: Object.t is failing - Exception not caught Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Something weird here: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Koha/Object.t t/db_dependent/Koha/Object.t .. 3/11 # Failed test 'Exception thrown correctly' # at t/db_dependent/Koha/Object.t line 359. # expecting: Koha::Exceptions::Object::BadValue # found: DBIx::Class::Exception (DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect datetime value: 'wrong_value' for column `koha_kohadev`.`borrowers`.`lastseen` at row 1 at /home/vagrant/kohaclone/Koha/Object.pm line 156 # ) # Looks like you failed 1 test of 1. # Failed test 'Bad value tests' # at t/db_dependent/Koha/Object.t line 363. # Looks like you failed 1 test of 16. Not on Jenkins It's the following exception's message that is not caught correctly by the regex: DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect datetime value: 'wrong_value' for column `koha_kohadev`.`borrowers`.`lastseen` at row 1 at /home/vagrant/kohaclone/Koha/Object.pm line 156 Note the backticks. -- You are receiving this mail because: You are watching all bug changes.

1 47