June 2020 - Koha-bugs - lists.koha-community.org

[Bug 15563] Add option to regularly delete patroncard and label batches to cleanup_database.pl cronjob
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '20

22 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15563 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Andrew, (In reply to Andrew Fuerste-Henry from comment #3) > Deleting batches is complicated a bit by the table structure. There's no > table for batches, it's just a column in the table that holds the individual > items. So there's no timestamp for a given batch, just a bunch of timestamps > for individual items. I've sidestepped that by deleting items rather than > batches. If all items in a given batch are gone, the batch is gone. This > does mean you could have a batch where items were added at different times > and therefore part of the batch is deleted and part remains. I understand the issue - that's complicating things. May I make a suggestion for a slightly different approach? We could delete batches that have not been changed in x days instead, by using something like: SELECT batch_id from creator_batches WHERE MAX(timestamp) ... (older than x days) GROUP BY batch_id; And then DELETE all the entries with the batch_ids of our result set. What do you think? I am feeling a bit uneasy about the possibility that the batches will keep 'changing' in the GUI in number and what's in them. It would feel a bit more consistent to me to delete the whole thing or not. Otherwise I had a bit of trouble understanding the wording of the new options. Could you maybe try and clear that up a bit? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8338] Fines not cleared with dropbox mode
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '20

22 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8338] Fines not cleared with dropbox mode
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '20

22 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #36 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106155&action=e… Bug 8338: (QA follow-up) Fix perlcritic error -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8338] Fines not cleared with dropbox mode
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '20

22 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105498|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106154&action=e… Bug 8338: (follow-up) Fix test This patch moves the previous test introduced with bug 24075 into the same block as the rest of the AddReturn tests and updates it to test for the new 'remove accountline' behaviour as well as the reduce and refund behaviour. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8338] Fines not cleared with dropbox mode
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '20

22 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105497|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106153&action=e… Bug 8338: Remove zero amount overdues on backdated returns where appropriate This patch removes any overdues which would be reversed on a backdated return if CalcFineOnBackdate is enabled and the user has not already attempted to pay off the accruing fine. Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8338] Fines not cleared with dropbox mode
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '20

22 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105496|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106152&action=e… Bug 8338: Unit Tests Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22539] New: Fines charged on back-dated checkin when item has been renewed
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '20

22 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 Bug ID: 22539 Summary: Fines charged on back-dated checkin when item has been renewed Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- In a certain niche situation, a patron can end up with an unexpected fine due to renewing a book just prior to returning it. Here's the situation: - Patron has a book due on a Saturday and doesn't return it - On Sunday, the library is closed - Early Sunday morning, the fines cron generates an accruing fine on the item - Patron puts the item in the bookdrop on Sunday - Patron renews the item via the OPAC on Sunday - At renewal, the fine changes from FU to F - Monday morning, the item is checked in via bookdrop mode, which back-dates the checkin to Saturday According to the old_issues table, the item was checked in before any fine was charged, but the fine remains on the patron's account. If the patron had not renewed the item, the fine would have remained FU and would have been forgiven on checkin. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 50

[Bug 10910] Add a warn when deleting a patron with pending suggestions
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '20

21 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10910 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha(a)catalyst.net.nz --- Comment #20 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12093] Add CSS classes to item statuses in detail view
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '20

21 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha(a)catalyst.net.nz --- Comment #17 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24405] New: Links in facets are styled differently than other links on the results page in OPAC
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '20

21 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24405 Bug ID: 24405 Summary: Links in facets are styled differently than other links on the results page in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org A small thing I've been wondering about: The links in the facets are shown underlined, but other links, like the links on each search result (title, place holds etc.) or navigation bar are not. Why are some links underlined and others not? There is a specific style causing this: #search-facets a { font-weight: 400; text-decoration: underline; } -- You are receiving this mail because: You are watching all bug changes.

1 11