July 2020 - Koha-bugs - lists.koha-community.org

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '20

15 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101944|0 |1 is obsolete| | --- Comment #136 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106923&action=e… Bug 15522: (follow-up) Fix circulation rules interface title inconsistency Follow-up to "Bug 15522: Remove old circulation rules interface" Instead of: "Circulation, fines and holds rules", use "Circulation, fines, and holds rules" for consistency Latter form already used in commit Bug 15522: New interface for updated circulation rules as follows koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc:37: <li><a href="/cgi-bin/koha/admin/policy.pl">Circulation, fines, and holds rules</a></li> koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt:88: <dt><a href="/cgi-bin/koha/admin/policy.pl">Circulation, fines, and holds rules</a></dt> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '20

15 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101943|0 |1 is obsolete| | --- Comment #135 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106922&action=e… Bug 15522: (follow-up) Handle deprecated rules Previous use of inArray was wrong. Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> Signed-off-by: Lari Taskula <lari.taskula(a)hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '20

15 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101942|0 |1 is obsolete| | --- Comment #134 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106921&action=e… Bug 15522: Handle deprecated rules For upgraded installs. Also add a log in the console if it happens. Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> Signed-off-by: Lari Taskula <lari.taskula(a)hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '20

15 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101941|0 |1 is obsolete| | --- Comment #133 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106920&action=e… Bug 15522: Replace the obsoleted fixFloat occurrence to use Sticky Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> Signed-off-by: Lari Taskula <lari.taskula(a)hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '20

15 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101940|0 |1 is obsolete| | --- Comment #132 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106919&action=e… Bud 15522: Restore categories filtering Mimicking what is done for Branches Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> Signed-off-by: Lari Taskula <lari.taskula(a)hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '20

15 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101939|0 |1 is obsolete| | --- Comment #131 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106918&action=e… Bug 15522: Fix permission name manage_circ_rules_from_any_libraries On 15520 followups have been provided to not use a negative permission. Note that two api tests are failing (get 400). I would like some help to investigate here why 400 is returned instead of 403. Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '20

15 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101938|0 |1 is obsolete| | --- Comment #130 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106917&action=e… Bug 15522: Add yarn.lock (autogenerated) Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> Signed-off-by: Lari Taskula <lari.taskula(a)hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '20

15 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101937|0 |1 is obsolete| | --- Comment #129 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106916&action=e… Bug 15522: Remove old circulation rules interface Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '20

15 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101936|0 |1 is obsolete| | --- Comment #128 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106915&action=e… Bug 15522: New interface for updated circulation rules Test plan: 1) Make sure all dependencies are applied, and that their DB upgrades have been applied. 2) Build JS (see previous patches for HOWTO). 3) Load .../cgi-bin/koha/admin/policy.pl . 4) Try changing an existing rule (one with a textbox or dropdown). Hit "Save rules", ensure that your changes are saved. 5) Until changes are saved, all cells that are changed or affected by your changes should be highlighted in yellow. 6) Same as above, but deleting a rule by hitting the "x" next to it. 7) Add rows and columns using the "Choose rule..." and "Choose category/item type..." dropdowns. 8) Add rules by clicking the pencil in a currently unset rule cell. Ensure changes are saved. 9) Hit "Cleanup rules"; all redundant rules should be removed. As this only removes rules that are the same as the defaults, this should not change any effective rules. 10) Use the filters at the top right ("Circulation", "Holds" and "Fines") to filter the kinds of rules that are shown. 11) Ensure that any desired library can be shown, including (if selected) all at the same time. JD edits: Removed the changes to filtered categories, will be done in a follow-up Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '20

15 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101935|0 |1 is obsolete| | --- Comment #127 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106914&action=e… Bug 15522: Add JS build pipeline This is not directly testable, but can be either used through the Makefile: $ make js-build (This will automatically install all dependencies.) Or by manually installing yarn: $ sudo apt install nodejs npm $ sudo npm install -g yarn $ yarn install $ yarn build (There is also `make js-watch` and `yarn watch`, which automatically recompile when files are changed.) JD note: the make rule does not work Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.

1 0