August 2020 - Koha-bugs - lists.koha-community.org

[Bug 13535] Table alert is missing FK and not deleted with the patron
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '20

14 Aug '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13535 --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 108272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108272&action=e… Bug 13535: Add FK constraint on borrowrnumber to alert table When a patron is deleted, we should clean up the data connected to the patron. This includes subscriptions to 'new issue arrived' arrive messages from the serials module. To test: Part1: - Before applying the patch - Add a subscription and select a notice template for patron notification - Go to the OPAC and subscribe to the email alert - Log in as any other patron (not yourself) and subscribe with that patron too - Verfiy on the subscription detail page, that the patrons are subscribed - Note the borrowernumber of your patrons - Delete the second patron - Note borrowernumber and delete patron - Run: SELECT * from alert; in a report - Despite the patron being deleted, you will see entries for both - Apply patch - Run updatedatabase - verify no error message - Run updatedatabase again - verify still no error message - There should no longer be an entry with the deleted borrowernumber, but only the entry for your own patron account Part 2: - Start fresh with the web installer, verify there are no errors on creating the database tables -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13535] Table alert is missing FK and not deleted with the patron
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '20

14 Aug '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13535 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19780] New: Actual price is not updated after it has been amended post receiving an order
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '20

14 Aug '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19780 Bug ID: 19780 Summary: Actual price is not updated after it has been amended post receiving an order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: alexbuckley(a)catalyst.net.nz Reporter: alexbuckley(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org The steps to replicate this bug are as follows: 1. Create an order and set the actual price to 9.00 2. Receieve the order changing the actual price value to 10.00. This is to represent the librarian accidentally entering in a different actual price value at receival. 3. Modify the actual value by clicking on the order line. The order page will appear and notice the actual price of 10.00 is displayed. Change this actual price value to 9.00 and save. 4.View invoices and notice that the actual price displayed for the order is still 10.00 (set in step 2) when it should be 9.00 -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 14825] Accounts Rewrite Omnibus
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '20

14 Aug '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26210 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26210 [Bug 26210] issue_id should be consistently set for Lost item handling -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21231] New: BlockReturnofLostItems does not prevent lost items being found
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '20

14 Aug '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21231 Bug ID: 21231 Summary: BlockReturnofLostItems does not prevent lost items being found Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When the syspref BlockReturnOfLostItems is set to Block, the item is blocked from being returned, but is still considered found -- it's set to lost=0 and a refund is applied to the patron (if circ rules allow). The item can then be checked in a second time and returned as it is no longer lost. To test: - set an item to lost - set BlockReturnOfLostItems to Block - check the lost item in - Koha says item cannot be returned but also item was lost, is now found - check the item in again -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 32

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '20

14 Aug '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #44 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 108247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108247&action=e… Bug 11889: [FOLLOW-UP] Tests and new get_shared_shelves subroutine To test: 1) prove t/db_dependent/Virtualshelves.t 2) prove t/db_dependent/Koha/Patrons.t Sponsored-by: Catalyst IT Signed-off-by: Cédric Vita <cedric.vita(a)dracenie.com> Signed-off-by: Cédric Vita <cedric.vita(a)dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '20

14 Aug '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #43 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 108246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108246&action=e… Bug 11889: [QA Follow-up] Add entry to sysprefs.sql Also changes the insert in the atomic update to an insert ignore, as we generally do for inserting sysprefs (see updatedatabase). Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Cédric Vita <cedric.vita(a)dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '20

14 Aug '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #42 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 108245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108245&action=e… Bug 11889: [Follow-up] Remove share if you are the new owner This will probably be exceptional. But if the staff member already had a share for a private list of the patron he deletes now, he will be the new owner and we should remove the share record. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Cédric Vita <cedric.vita(a)dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '20

14 Aug '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61451|0 |1 is obsolete| | Attachment #61452|0 |1 is obsolete| | Attachment #61453|0 |1 is obsolete| | Attachment #61454|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 108244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108244&action=e… Bug 11889: Disown a list upon deletion of owner This patch adds a syspref 'ListOwnershipUponPatronDeletion' which decides if all the owner's lists (public and private) are deleted when the owner is deleted, or if the ownership of their public and shared lists are transfered to the user who deleted the owner (private lists that are not shared are always deleted). To test: 1) Apply patch and update database 2) Set the ListOwnershipUponPatronDeletion syspref to 'Transfer...' 3) Set up a superlibrarian user 4) Log in as this superlibrarian user and set up three lists, a public list (maybe named 'public'), and two private lists (named 'private' and 'shared') 5) Log in as this user to the opac (if you haven't already) and share the 'shared' list with someone 6) View the virtualshelves table in mysql to see the three lists you just created under your new user 7) Also view the virtualshelfshares table in mysql to see the 'shared' list 8) Log into the staff client with your regular user (a different user to the one you just created) 9) Search for the user you just created and delete them 10) Go to your lists 11) You should see the 'shared' list under your private lists, and their 'public' list under your public lists, both with you as the owner 12) if you view both the virtualshelves table and the virtualshelfshares table in mysql again, youll see you are now the owner and the 'private' list will no longer exist. 13) Set the ListOwnershipUponPatronDeletion syspref back to 'Delete...' 14) Repeat steps 3 - 10 again (it may help to delete the 'shared' and 'public' lists before you re-create them) 15) You should not see any of the lists you just made under private or public lists this time. To confirm, check the virtualshelves table in mysql and make sure that all three lists have been deleted. Sponsored-by: Catalyst IT Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Cédric Vita <cedric.vita(a)dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '20

14 Aug '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #40 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #35) > (In reply to Katrin Fischer from comment #34) > > For the public/shared with public, I think the idea of > > having a general inheriting user is fine. > > If we would have consensus about that, we could perhaps apply the following > algorithm to public lists now ? Would this provide sufficient flexibility? > > When deleting a public list, > if pref GeneralPublicListOwner[?] is a specific userid then > move ownership to that user > elsif pref == current user then > move to current staff member > else > delete list > endif > > And open another report to handle shared lists. And another one for > transferring ownership? Late in the party... Yes Marcel I agree with that. Are you still willing to work on it? -- You are receiving this mail because: You are watching all bug changes.

1 0