September 2020 - Koha-bugs - lists.koha-community.org

[Bug 11176] Purchase suggestions should respect the 'active' switch on budgets
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '20

24 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22405 --- Comment #11 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- 22405 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11176] Purchase suggestions should respect the 'active' switch on budgets
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '20

24 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176 --- Comment #10 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- Created attachment 110646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110646&action=e… Bug 11176: Add active switch on budgets select in suggestions When creating a new purchase suggestion, all funds display and are available for selection. The behaviour of this drop-down menu should mirror that of those drop-down menus elsewhere in acquisitions, where only funds that are linked to active budgets display to the user. This patch add the active switch based on what exists in acqui/invoice.tt and acqui/invoice.pl. Looks like actually in suggestion.pl budgets list was fetches with GetBudgets(). But this is for the filter in 'Acquisition information'. Budgets selection on suggestion creation/edition must use GetBudgetHierarchy(), like in acqui/invoice.pl, in order to have the actif status. Test plan : 1) Create a budget periods active B1 with a fund F1 2) Create a budget periods inactive B2 with a fund F2 3) Go to suggestions module 4) Create a new suggestion 5) Check you see only active fund F1 6) Click on 'Show inactive' 7) Check you see also 'F2 (inactive)' 8) Choose fund F1 and save 9) Select the suggestion and edit 10) Check fund F1 is selected 11) Come back to suggestion table 12) Check filter 'Book fund' under 'Acquisition information' contains all funds -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11176] Purchase suggestions should respect the 'active' switch on budgets
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '20

24 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8338] Add ability to remove fines with dropbox mode
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '20

24 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #57 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- (In reply to Andrew Fuerste-Henry from comment #55) > Martin, can you please rebase this for 19.11? > Thanks! As requested, I have added a rebased and squashed patch for application to the 19.11 branch.. to apply it you will also need the rebased 19.11 patch for bug 24252 which introduces a relation accessor we use here. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8338] Add ability to remove fines with dropbox mode
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '20

24 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #56 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 110640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110640&action=e… Bug 8338: [19.11] Remove zero amount overdues on backdated returns [19.11.x] This is a squashed patchset ready for application to 19.11 * Remove zero amount overdues on backdated returns where appropriate This patch removes any overdues which would be reversed on a backdated return if CalcFineOnBackdate is enabled and the user has not already attempted to pay off the accruing fine. * Fix test This patch moves the previous test introduced with bug 24075 into the same block as the rest of the AddReturn tests and updates it to test for the new 'remove accountline' behaviour as well as the reduce and refund behaviour. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24252] New: Add credit_offsets and debit_offsets relationship to Koha::Account::Line
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '20

24 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252 Bug ID: 24252 Summary: Add credit_offsets and debit_offsets relationship to Koha::Account::Line Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Add the Koha::Objects expansion of the credit and debit offset relationships to the Koha::Account::Line class. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 25

[Bug 8338] Add ability to remove fines with dropbox mode
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '20

24 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252 [Bug 24252] Add credits, debits, credit_offsets and debit_offsets relationships to Koha::Account::Line -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8338] Add ability to remove fines with dropbox mode
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '20

24 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to decrease |Add ability to remove fines |fines with dropbox mode |with dropbox mode -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13625] RenewalSendNotice setting should be reflected in messaging preferences descriptions
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '20

24 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13625 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13625] RenewalSendNotice setting should be reflected in messaging preferences descriptions
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '20

24 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13625 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|RenewalSendNotice setting |RenewalSendNotice setting |should be reflected in |should be reflected in |messaging preferences |messaging preferences | |descriptions -- You are receiving this mail because: You are watching all bug changes.

1 0