September 2020 - Koha-bugs - lists.koha-community.org

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 22 Sep '20

22 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110553|0 |1 is obsolete| | Attachment #110554|0 |1 is obsolete| | Attachment #110555|0 |1 is obsolete| | Attachment #110556|0 |1 is obsolete| | Attachment #110557|0 |1 is obsolete| | --- Comment #148 from Michal Denar <black23(a)gmail.com> --- Created attachment 110568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110568&action=e… Bug 11299: Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : 1 - In your system preferences set: AutoCreateAuthorities: don't generate BiblioAddsAuthorities: don't allow 2 - Go to the Cataloging -> New record (koha/cataloguing/addbiblio.pl) Ensure you are using the basic editor 3 - Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." 4 - Add random informations in field 600$a of the biblio record. 5 - Click the "Link authorities automatically" button. the message box should now show "600 - No matching authority found.". the 9 subfield is red Above the 9 subfield is a red X with a blue plus next to it Hover on the plus, see it is titled 'Create authority' 6 - Click the 'Create authority' link 7 - A new authroity form pops up, the info from the cataloging editor is prefilled Click the 100 field heading to expand and confirm info is transferred 8 - Fill in necessary fields and save the new authority 9 - The cataloging screen now has the 9 subfield populated and is green 10 - Click "Link authorities automatically" again Dialog says "No authority link was changed" 11 - In another tab go to System preferences and set AutoCreateAuthorities to 'Allow' 12 - Add random information to the 650 field 13 - Click 'Link authorities' button 14 - Dialog says:650 - No matching authority found. A new authority was created automatically. 15 - The subfield 9 is green and has the id of the new authority record 16 - In another tab search authorities and find an existing subject heading 17 - Add a new 650 with the info from the existing record 18 - Click 'Link authorities' 19 - The new field is correctly linked to existing authority Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> https://bugs.koha-community.org/show_bug.cgi?id=12299 Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 22 Sep '20

22 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 22 Sep '20

22 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Agustín Moyano <agustinmoyano(a)theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs(a)lists.koha-commun |agustinmoyano(a)theke.io |ity.org | CC| |agustinmoyano(a)theke.io -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 22 Sep '20

22 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #147 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 110557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110557&action=e… Bug 11299: (follow-up) correct link -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 22 Sep '20

22 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109181|0 |1 is obsolete| | --- Comment #146 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 110556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110556&action=e… Bug 11299: (follow-up) Skip fields with no 9 subfields To test: 1 - Disable the 'thesaurus' for a controlled field like 600a or 650a 2 - Edit a record and put random data in this field 3 - Try to link, get a JS error 4 - Apply patch 5 - Repeat 6 - No more error, field is not linked (as it has no $9 subfield) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 22 Sep '20

22 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109062|0 |1 is obsolete| | --- Comment #145 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 110555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110555&action=e… Bug 11299: (follow-up) Correct rebase errors and add message class to dialog -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 22 Sep '20

22 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108835|0 |1 is obsolete| | --- Comment #144 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 110554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110554&action=e… Bug 11299: (QA follow-up) Fix tests, spaces, and CSS update Removed my from variables in test Undid stray line deletions Undid adding 1; to test file Fix CSS replace command Update license Fix spelling Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 22 Sep '20

22 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108834|0 |1 is obsolete| | --- Comment #143 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 110553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110553&action=e… Bug 11299: Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : 1 - In your system preferences set: AutoCreateAuthorities: don't generate BiblioAddsAuthorities: don't allow 2 - Go to the Cataloging -> New record (koha/cataloguing/addbiblio.pl) Ensure you are using the basic editor 3 - Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." 4 - Add random informations in field 600$a of the biblio record. 5 - Click the "Link authorities automatically" button. the message box should now show "600 - No matching authority found.". the 9 subfield is red Above the 9 subfield is a red X with a blue plus next to it Hover on the plus, see it is titled 'Create authority' 6 - Click the 'Create authority' link 7 - A new authroity form pops up, the info from the cataloging editor is prefilled Click the 100 field heading to expand and confirm info is transferred 8 - Fill in necessary fields and save the new authority 9 - The cataloging screen now has the 9 subfield populated and is green 10 - Click "Link authorities automatically" again Dialog says "No authority link was changed" 11 - In another tab go to System preferences and set AutoCreateAuthorities to 'Allow' 12 - Add random information to the 650 field 13 - Click 'Link authorities' button 14 - Dialog says:650 - No matching authority found. A new authority was created automatically. 15 - The subfield 9 is green and has the id of the new authority record 16 - In another tab search authorities and find an existing subject heading 17 - Add a new 650 with the info from the existing record 18 - Click 'Link authorities' 19 - The new field is correctly linked to existing authority Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> https://bugs.koha-community.org/show_bug.cgi?id=12299 Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 22 Sep '20

22 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 22 Sep '20

22 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 --- Comment #49 from Alexis Ripetti <alexis.ripetti(a)inLibro.com> --- (In reply to Arthur Suzuki from comment #48) > Test patch works as expected (there is one test which doesn't pass when test > patch is applied alone). > However the test patch seems to change things in C4/Circulation as well, > is this due to a change in the db structure, > and shouldn't this change be in the main patch anyway? > Other than this comment, happy to signoff :) The change in the C4/Circulation.pm file should have been applied on the main patch. You previously said that a test should fail when patches are applied. But which test does fail for you and which one is supposed to fail? Because when I apply both patches every tests pass. -- You are receiving this mail because: You are watching all bug changes.

1 0