September 2020 - Koha-bugs - lists.koha-community.org

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '20

18 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110396|0 |1 is obsolete| | --- Comment #35 from David Nind <david(a)davidnind.com> --- Created attachment 110404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110404&action=e… Bug 12224: (follow-up) Move button to patron column in checkins table This patch moves the "Print checkin slip" out of its own column and into the colum containing patron information. I think this makes more sense because the slip is specific to a patron, not the individual item which has been checked in. Also changed: printcheckinslip function should be triggered via a class, not a non-unique ID. The function should handle the click using "preventDefault" rather than "return false." To test, apply the patch and check in some items checked out to various patrons. - In the table of checked-in items, confirm that the "Print checkin slip" appears correctly in the column of patron information. - Confirm that the button works correctly to print the correct slip for the associated patron. Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '20

18 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110395|0 |1 is obsolete| | --- Comment #34 from David Nind <david(a)davidnind.com> --- Created attachment 110403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110403&action=e… Bug 12224: Print a slip of borrower's checkins for today To test: 1) Apply patch and run installer 2) Check out two items (or more) to a borrower 3) Check in two items (or more) for this borrower (you should end up on circ/returns.pl) 4) Notice the checked-in items table has started building. There should be a new column with the button 'Print checkin slip' in each row. 5) Click the button and confirm the checkin slip opens for printing in a new window. 6) Go to the patron's account 7) Click the Print dropdown. Confirm there is a 'Print checkin slip' option. Click this and confirm the checkin slip opens for printing in a new window. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '20

18 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '20

18 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 --- Comment #33 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 110396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110396&action=e… Bug 12224: (follow-up) Move button to patron column in checkins table This patch moves the "Print checkin slip" out of its own column and into the colum containing patron information. I think this makes more sense because the slip is specific to a patron, not the individual item which has been checked in. Also changed: printcheckinslip function should be triggered via a class, not a non-unique ID. The function should handle the click using "preventDefault" rather than "return false." To test, apply the patch and check in some items checked out to various patrons. - In the table of checked-in items, confirm that the "Print checkin slip" appears correctly in the column of patron information. - Confirm that the button works correctly to print the correct slip for the associated patron. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '20

18 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110308|0 |1 is obsolete| | --- Comment #32 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 110395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110395&action=e… Bug 12224: Print a slip of borrower's checkins for today To test: 1) Apply patch and run installer 2) Check out two items (or more) to a borrower 3) Check in two items (or more) for this borrower (you should end up on circ/returns.pl) 4) Notice the checked-in items table has started building. There should be a new column with the button 'Print checkin slip' in each row. 5) Click the button and confirm the checkin slip opens for printing in a new window. 6) Go to the patron's account 7) Click the Print dropdown. Confirm there is a 'Print checkin slip' option. Click this and confirm the checkin slip opens for printing in a new window. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '20

18 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '20

18 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10921] You can edit an order even when it is in a closed basket
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '20

18 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10921 --- Comment #8 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10921] You can edit an order even when it is in a closed basket
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '20

18 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10921 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '20

18 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david(a)davidnind.com --- Comment #5 from David Nind <david(a)davidnind.com> --- Patch no longer applies 8-( : root@kohadevbox:koha(bz7607)$ git bz apply 7607 Bug 7607 - Advanced search: Index and search term don't match when leaving fields empty 107963 - Bug 7607: Fix adv search when leaving fields empty Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 7607: Fix adv search when leaving fields empty Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 7607: Fix adv search when leaving fields empty The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-7607-Fix-adv-search-when-leaving-fields-empty-P2nq_2.patch -- You are receiving this mail because: You are watching all bug changes.

1 0