September 2020 - Koha-bugs - lists.koha-community.org

[Bug 15436] Use semicolon between series name and volume information
by bugzilla-daemon＠bugs.koha-community.org 17 Sep '20

17 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15436] Use semicolon between series name and volume information
by bugzilla-daemon＠bugs.koha-community.org 17 Sep '20

17 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46837|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15436] Use semicolon between series name and volume information
by bugzilla-daemon＠bugs.koha-community.org 17 Sep '20

17 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5927 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5927 [Bug 5927] Show series information in search results page -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5927] Show series information in search results page
by bugzilla-daemon＠bugs.koha-community.org 17 Sep '20

17 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5927 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15436 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 [Bug 15436] Use semicolon between series name and volume information -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 14648] Batch remove reserve items
by bugzilla-daemon＠bugs.koha-community.org 17 Sep '20

17 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #26 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 110295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110295&action=e… Bug 14648: (QA follow-up) Terminology items-reserves delete-remove - As we have batch add reserves, we should also have batch remove reserves - Delete items sounds a bit scary, removed items I think is a little better here Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14648] Batch remove reserve items
by bugzilla-daemon＠bugs.koha-community.org 17 Sep '20

17 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #25 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 110294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110294&action=e… Bug 14648: (QA follow-up) Add missing filters Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14648] Batch remove reserve items
by bugzilla-daemon＠bugs.koha-community.org 17 Sep '20

17 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110228|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 110293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110293&action=e… Bug 14648: Batch remove reserve items Adds "Batch remove items" button to course-reserves.tt. Creates batch_rm_items.pl and batch_rm_items.tt. Allows user to enter a list of barcode numbers so that they will be removed from all course reserves to which they are attached. A dialog box will provide a warning before the final deletion is made. This patch also now moves barcodes that are invalid or not attached to a course reserve to the invalid barcodes output. It also provides a count of the courses that the deleted items were attached to. Test Plan 1. Log in as a user with permissions to add and delete course reserves 2. Add the same items to multiple course reserves 3. Go to the main course reserves page (i.e. /cgi-bin/koha/course_reserves/course-reserves.pl) 4. Click the "- Batch remove items" button 5. Enter the barcodes that you added to multiple reserves in step 1 6. Click submit 7. Click Ok if you are ready to delete all of these items 8. Check each course reserve that you added the items to in step 1 to make sure the items you entered were deleted but nothing else 9. Repeat 2-5 10. Add an invalid barcode and a valid barcode that is not attached to a course reserve 11. Repeat 6-7 12. You should see that the items attached to course reserves were removed while the invalid and unattached barcodes were rejected 13. Log out 14. Log in as a user without permission to delete course reserves 15. Go to the main course reserves page (i.e. /cgi-bin/koha/course_reserves/course-reserves.pl) 16. You should not longer see the "- Batch remove items" button Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14648] Batch remove reserve items
by bugzilla-daemon＠bugs.koha-community.org 17 Sep '20

17 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14648] Batch remove reserve items
by bugzilla-daemon＠bugs.koha-community.org 17 Sep '20

17 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #23 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Joe, once things have been fixed, you can usually go back to Signed off if the changes were not too major (in this case, do a follow-up patch instead of replacing the original one, so QA can easier see the new changes). Set back to "Needs Signoff" for more drastic changes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 17 Sep '20

17 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #109 from David Nind <david(a)davidnind.com> --- Hi Arthur, I thought I would test again but the patch no longer applies 8-( : root@kohadevbox:koha(bz11999)$ git bz apply 11999 Bug 11999 - Add two checks in CanBookBeReserved and CanItemBeReserved 99927 - Bug 11999: Add maxreserves check in CanBookBeReserved and CanItemBeReserved 106481 - Bug 11999: Test improvements + check maxreserves 106494 - Bug 11999: QA follow-up Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11999: Add maxreserves check in CanBookBeReserved and CanItemBeReserved Using index info to reconstruct a base tree... M C4/Reserves.pm M reserve/request.pl Falling back to patching base and 3-way merge... Auto-merging reserve/request.pl Auto-merging C4/Reserves.pm CONFLICT (content): Merge conflict in C4/Reserves.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 11999: Add maxreserves check in CanBookBeReserved and CanItemBeReserved The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11999-Add-maxreserves-check-in-CanBookBeReserv-WtX_N_.patch -- You are receiving this mail because: You are watching all bug changes.

1 0