September 2020 - Koha-bugs - lists.koha-community.org

[Bug 13535] Table alert is missing FK and not deleted with the patron
by bugzilla-daemon＠bugs.koha-community.org 16 Sep '20

16 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13535 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #9 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Yeay for proper constraints. Thanks Katrin, looks good to me and works as expected. Signing off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13535] Table alert is missing FK and not deleted with the patron
by bugzilla-daemon＠bugs.koha-community.org 16 Sep '20

16 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13535 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108275|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 110194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110194&action=e… Bug 13535: Add FK constraint on borrowrnumber to alert table When a patron is deleted, we should clean up the data connected to the patron. This includes subscriptions to 'new issue arrived' arrive messages from the serials module. To test: Part1: - Before applying the patch - Add a subscription and select a notice template for patron notification - Go to the OPAC and subscribe to the email alert - Log in as any other patron (not yourself) and subscribe with that patron too - Verfiy on the subscription detail page, that the patrons are subscribed - Note the borrowernumber of your patrons - Delete the second patron - Note borrowernumber and delete patron - Run: SELECT * from alert; in a report - Despite the patron being deleted, you will see entries for both - Apply patch - Run updatedatabase - verify no error message - Run updatedatabase again - verify still no error message - There should no longer be an entry with the deleted borrowernumber, but only the entry for your own patron account Part 2: - Start fresh with the web installer, verify there are no errors on creating the database tables Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 16 Sep '20

16 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #16 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Thanks Emmi; I hope I didn't come across too negative.. I'd happily pick up the bug if I had some time to do so.. I'll certainly keep and eye out on it and try to help with testing/qa as needed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 16 Sep '20

16 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #15 from Emmi Takkinen <emmi.takkinen(a)outlook.com> --- Looking back to this after feedback and I agree, this implementation isn't ideal. At least method should return Patron object. I'll work on it again based on feedback. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14866] Make high holds work with different item types and number of open days
by bugzilla-daemon＠bugs.koha-community.org 16 Sep '20

16 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103427|0 |1 is obsolete| | --- Comment #15 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 110149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110149&action=e… Bug 14866: Make high holds work with different item types To test: 1) Apply patch, update database, restart services 2) Enable decreaseLoanHighHolds sysprefs if not already active 3) Go to circulation rules and set a value under 'Decrease loan holds (day)' that is DIFFERENT from decreaseLoanHighHoldsDuration 4) Check out an item with holds and confirm that the value from the rule is used instead of the system preference 5) Confirm tests pass before and after the patch t/db_dependent/DecreaseLoanHighHolds.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14866] Make high holds work with different item types and number of open days
by bugzilla-daemon＠bugs.koha-community.org 16 Sep '20

16 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 16 Sep '20

16 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108695|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 16 Sep '20

16 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #85 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 110148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110148&action=e… Bug 14242: (follow-up) Adding publication year hint and fix js translations -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 16 Sep '20

16 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108701|0 |1 is obsolete| | --- Comment #84 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 110147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110147&action=e… Bug 14242: Styling of buttons, get copyright date, fixing plugin comment And other code-y bits. Addressing comments in Comment 59. Sponsored-by: Catalyst IT Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 16 Sep '20

16 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108700|0 |1 is obsolete| | --- Comment #83 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 110146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110146&action=e… Bug 14242: (follow-up) Move English strings out of JavaScript In order for English strings to be translatable they must be defined in the template, not in the JS file. Signed-off-by: Maryse Simard <maryse.simard(a)inlibro.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0