September 2020 - Koha-bugs - lists.koha-community.org

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '20

11 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100057|0 |1 is obsolete| | --- Comment #214 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 109959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109959&action=e… Bug 14957: Change YUI layout to to Boostrap Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '20

11 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100056|0 |1 is obsolete| | --- Comment #213 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 109958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109958&action=e… Bug 14957: Fix rule javascript validation issue Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '20

11 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100055|0 |1 is obsolete| | --- Comment #212 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 109957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109957&action=e… Bug 14957: Adjust paging option for new version of datatables Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '20

11 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100054|0 |1 is obsolete| | --- Comment #211 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 109956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109956&action=e… Bug 14957: Make preset labels translatable Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '20

11 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100053|0 |1 is obsolete| | --- Comment #210 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 109955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109955&action=e… Bug 14957: Merge rules system for merging of MARC records Add a rule based system for merging MARC records to for example prevent field data from being overwritten. To test: 1. Apply this patch. 2. Log in to staff client. 3. Enable new syspref MARCMergeRules. 4. Click the new link "MARC merge rules" in the "Catalog" section of the Koha administration page. 5. Create a new rule: Module: source, Filter: *, Tag: 245, Preset: Protect. 6. Clicking "Edit" should allow you to edit corresponding rule. 7. Clicking "Delete" should remove corresponding rule after confirmation. 8. Selecting one or more rules followed by clicking "Delete selected" should remove all selected rules after confirmation. 9. Try creating a rule with tag set to "**", the other options does not matter. Verify that saving this rule produces an error message complaining about invalid tag regular expression. 10. Try creating a rule with tag set to "008" (or other control field) and set Appended: Append and Removed: Skip, the other options does not matter. Verify that saving this rule produces an error message complaining about invalid combination of actions for control field. 11. With the 245 rule in step 5 in place, edit a bibliographic record, change 245a for example (which should be Title for MARC21) and save. 12. Verify that the changes has not been saved. 13. Create a new rule: Module: source, Filter: intranet, Tag: 245, Preset: Overwrite. 14. Repeat step 12, and verify that the changes has now been saved. 15. Run tests in t/db_dependent/Biblio/MarcMergeRules.t and very that all tests pass. Sponsored-by: Halland County Library Sponsored-by: Catalyst IT Sponsored-by: Gothenburg University Library Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '20

11 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Heather <heather_hernandez(a)nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez(a)nps.gov -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10921] You can edit an order even when it is in a closed basket
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '20

11 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10921 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109639|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 109945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109945&action=e… Bug 10921: Prevent an order from a closed basket to be edited We don't allow editing of orders that are part of a closed basket, but we don't enforce the rule in the controller file. This patch use output_and_exit to stop the script and display an error to the end user. Test plan: Create a basket, add an order On the basket view you see the "Modify" link, open it in a separate tab => You can edit the basket Keep this tab open, get back to the other one and close the basket Reload the tab with the order edition form => You cannot longer edit the basket QA: Do we need a check in addorder.pl as well? Signed-off-by: Henry Bolshaw <bolshawh(a)parliament.uk> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10921] You can edit an order even when it is in a closed basket
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '20

11 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10921 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '20

11 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Whilst I understand the idea behind this, I'm not sure the implementation is good. We iterate through all patrons in the resultset (so, if you're calling this without having first chained it to a search) we will literally fetch all borrowers from the db. We're also returning a weird hasref rather than a set of Koha::Patron objects which you could then work with further to produce the data you want. I would also suggest that it should support the standard attribute params available to normal searches to allow for filtering. So.. all in all I feel we can do better.. this method should produce a joined query that can be used inline with a method chain on Koha::Patrons... What I'de really like to see is something along the lines: my $filtered_patrons = Koha::Patrons->search({ whatever })->filter_by_owes({amount => { '>=' => $max_owed }}); -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '20

11 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #20 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- Rebased and fixed the issue with another patron being able to checkout in processing hold via SIP machine. Ready for sign-off again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0