September 2020 - Koha-bugs - lists.koha-community.org

[Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '20

11 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Whilst I understand the idea behind this, I'm not sure the implementation is good. We iterate through all patrons in the resultset (so, if you're calling this without having first chained it to a search) we will literally fetch all borrowers from the db. We're also returning a weird hasref rather than a set of Koha::Patron objects which you could then work with further to produce the data you want. I would also suggest that it should support the standard attribute params available to normal searches to allow for filtering. So.. all in all I feel we can do better.. this method should produce a joined query that can be used inline with a method chain on Koha::Patrons... What I'de really like to see is something along the lines: my $filtered_patrons = Koha::Patrons->search({ whatever })->filter_by_owes({amount => { '>=' => $max_owed }}); -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '20

11 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #20 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- Rebased and fixed the issue with another patron being able to checkout in processing hold via SIP machine. Ready for sign-off again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '20

11 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #19 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- Created attachment 109929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109929&action=e… Bug 12556: Add new "in processing" state to holds This adds new syspref, HoldsNeedProcessingSIP, which controls whether a hold that is related to item will be filled automatically or not. If the user has enabled the syspref then instead of fulfilling the hold automatically the hold will go to "in processing" state. To test: 1. Checkout a book to patron A 2. Place a bib level hold to the book for B 3. Patron A returns the book via SIP, to simulate this use: ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item <ItemBarcode> -m checkin 4. Notice that no notification is generated for Patron B about hold and that the hold status in intranet and opac is "In Processing". 5. Notice that patron A (or other patrons) cannot checkout a book that is in processing, because it is considered to be attached to the holdee (similarly to the waiting state): ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --patron <PatronABarcode> --item <ItemBarcode> -m checkout -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '20

11 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #18 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- Created attachment 109928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109928&action=e… Bug 12556: Simplify and correct logic in holds-table.inc template The states is_waiting and is_found are already implied by is_at_destination. Also we would never get the 'transfered' html class since transfer's status is T (this might not have been true in the past but now is). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '20

11 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #17 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- Created attachment 109927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109927&action=e… Bug 12556: reserves/request.pl: Reuse code from Koha::Hold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '20

11 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #16 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- Created attachment 109926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109926&action=e… Bug 12556: Reuse code from Koha::Hold instead of duplicating it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '20

11 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #15 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- Created attachment 109925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109925&action=e… Bug 12556: Remove unused HTML Koha::Hold::is_at_destination() already checks for found = 'W' so the ELSE code path which would print "Item waiting to be pulled from [...]" never gets executed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '20

11 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107181|0 |1 is obsolete| | Attachment #107182|0 |1 is obsolete| | Attachment #107183|0 |1 is obsolete| | Attachment #107184|0 |1 is obsolete| | Attachment #107185|0 |1 is obsolete| | Attachment #109140|0 |1 is obsolete| | --- Comment #14 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- Created attachment 109924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109924&action=e… Bug 12556: Refactor hold transfer status setting to its own method -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '20

11 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15562] Make Koha more suitable for shared hosting with plack
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '20

11 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 --- Comment #77 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Or maybe even better drop this one. Things have moved on obviously. Take those small patches if you find them useful. -- You are receiving this mail because: You are watching all bug changes.

1 0