January 2021 - Koha-bugs - lists.koha-community.org

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '21

20 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #124 from Mazen Khallaf <mazen.i.khallaf(a)gmail.com> --- Created attachment 115384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115384&action=e… Bug 13952: (follow-up) Fixing export on default biblio framework Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '21

20 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #123 from Mazen Khallaf <mazen.i.khallaf(a)gmail.com> --- Created attachment 115383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115383&action=e… Bug 13952: (follow-up) Fixing import for default auth type Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '21

20 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #122 from Mazen Khallaf <mazen.i.khallaf(a)gmail.com> --- Created attachment 115382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115382&action=e… Bug 13952: (follow-up) Fixing authority type import This patch fixes the comments from Comment 29 and the import functionality. You should now be able to import an exported file without editing the file at all and the authority type code will be overwritten in the file (same behaviour as biblio frameworks). Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '21

20 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Mazen Khallaf <mazen.i.khallaf(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114170|0 |1 is obsolete| | Attachment #114171|0 |1 is obsolete| | Attachment #114172|0 |1 is obsolete| | Attachment #114173|0 |1 is obsolete| | Attachment #114174|0 |1 is obsolete| | Attachment #114175|0 |1 is obsolete| | Attachment #114176|0 |1 is obsolete| | Attachment #115379|0 |1 is obsolete| | --- Comment #121 from Mazen Khallaf <mazen.i.khallaf(a)gmail.com> --- Created attachment 115381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115381&action=e… Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs Update5: Getting rid of warns, making sure Import and Export of default authority will work Update6: Merge conflicts and making sure export of default auth type works Update7: Fixing merge conflicts and updating buttons to bootstrap3 To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) Import into your new authority type using the file you just exported 7) Confirm you are taken to auth_tag_structure.pl 8) Go back to Authority types 9) Export your new authority type. View the exported file and confirm the authtypecode has been updated to match the code you set for the new auth type 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Confirm Export and Import work for the Default authority type 12) Go to Admin -> MARC bibliographic framework 13) Confirm that the 'Export' and 'Import' functions still work here as well Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '21

20 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Mazen Khallaf <mazen.i.khallaf(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114177|0 |1 is obsolete| | --- Comment #120 from Mazen Khallaf <mazen.i.khallaf(a)gmail.com> --- Created attachment 115379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115379&action=e… Bug 13952: (follow-up) fixing indentation and rebasing Signed-off-by: Mazen Khallaf <mazen.i.khallaf(a)gamil.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '21

20 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Mazen Khallaf <mazen.i.khallaf(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13513] Improve POD of C4::Circulation AnonymiseIssueHistory
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '21

20 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13513 --- Comment #3 from James O'Keeffe <jamespfk(a)gmail.com> --- Hello! I'm having a little trouble finding the incorrect documentation. Is this still relevant, and if not, where is it? Thanks -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14723] Additional delivery notes to messages
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '21

20 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Mazen Khallaf <mazen.i.khallaf(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mazen.i.khallaf(a)gmail.com --- Comment #38 from Mazen Khallaf <mazen.i.khallaf(a)gmail.com> --- Failed to apply the patch in step 4 $ git bz apply 14723 Bug 14723 - Additional delivery notes to messages 105776 - Bug 14723: Additional delivery notes to messages 105777 - Bug 14723: Make delivery notes translatable Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14723: Additional delivery notes to messages Using index info to reconstruct a base tree... M C4/Letters.pm M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt M t/db_dependent/Letters.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Letters.t CONFLICT (content): Merge conflict in t/db_dependent/Letters.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging C4/Letters.pm CONFLICT (content): Merge conflict in C4/Letters.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 14723: Additional delivery notes to messages The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14723-Additional-delivery-notes-to-messages-h__pEr.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14723] Additional delivery notes to messages
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '21

20 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Victoria Faafia <vfaafia29(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #37 from Victoria Faafia <vfaafia29(a)gmail.com> --- Applying: Bug 14723: Additional delivery notes to messages Using index info to reconstruct a base tree... M C4/Letters.pm M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt M t/db_dependent/Letters.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Letters.t CONFLICT (content): Merge conflict in t/db_dependent/Letters.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging C4/Letters.pm CONFLICT (content): Merge conflict in C4/Letters.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 14723: Additional delivery notes to messages The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14723-Additional-delivery-notes-to-messages-_b90Al.patch Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13513] Improve POD of C4::Circulation AnonymiseIssueHistory
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '21

20 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13513 James O'Keeffe <jamespfk(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |jamespfk(a)gmail.com CC| |jamespfk(a)gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0