January 2021 - Koha-bugs - lists.koha-community.org

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '21

19 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107077|0 |1 is obsolete| | Attachment #107078|0 |1 is obsolete| | Attachment #107079|0 |1 is obsolete| | --- Comment #84 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Created attachment 115369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115369&action=e… Bug 7376: Transfer limits should be checked at check-in Test case: * UseBranchTransferLimits must be set * define your branch transfer limit. Refuse transfers from libraryA to libraryB * checkout a book owned by libraryB, from libraryB, with a librarian located at libraryB * move the librarian to libraryA ("Set Library" link top/right) * check-in the book => it's possible whatever your setup After the patch, the behaviour respect the branch transfer limit parameter: you can check-in if you accept transfers, you can't if you refuse them. (Note: IndependantBranches must be OFF, otherwise it's not possible to do the checkin whatever the branch transfer limits) Sponsored-by: National Library of Finland Signed-off-by: Arthur Suzuki <arthur.suzuki(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '21

19 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13961] Option to include patron's total amount of fines in notices
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '21

19 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Mazen Khallaf <mazen.i.khallaf(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mazen.i.khallaf(a)gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #29 from Mazen Khallaf <mazen.i.khallaf(a)gmail.com> --- Unable to apply patch (step 1) $ git bz apply 13961 Bug 13961 - Option to include patron's total amount of fines in notices 106192 - Bug 13961: Option to include patron's total amount of fines in notices 106193 - Bug 13961: Add currency format handling 106194 - Bug 13961: Add unit test 106623 - Bug 13961: Fix QA issues 106624 - Bug 13961: Check that borrowernumber isn't a reference Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 13961: Option to include patron's total amount of fines in notices Applying: Bug 13961: Add currency format handling error: sha1 information is lacking or useless (C4/Letters.pm). error: could not build fake ancestor Patch failed at 0001 Bug 13961: Add currency format handling The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-13961-Add-currency-format-handling-LIVbPh.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23162] New: Cannot copy a notice if independent branches enabled and not a superlibrarian
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '21

19 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23162 Bug ID: 23162 Summary: Cannot copy a notice if independent branches enabled and not a superlibrarian Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- We forget to set the branch to current branch I guess To recreate: 1 - Be a superlibrarian (you all are anyways!) 2 - Go to Tools->notices and slips 3 - Note you see notices and can copy them to other branches to edit 4 - Now enabled independent branches 5 - It all still works 6 - Stop being a superlibrarian (i.e. create a patron with permissions for notices, but not superlibrarian) 7 - Go to Tools->notices and slips 8 - Note the 'copy' button doesn't have a drop down to select branch 9 - Click it, you can edit 10 - Try to save - Alert:A letter with the code 'ACCTDETAILS' already exists for 'undefined'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 11257] Document <<items.content>> for duedgst and preduedgst and update sample notices
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '21

19 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11257 James O'Keeffe <jamespfk(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs(a)lists.koha-commun |jamespfk(a)gmail.com |ity.org | CC| |jamespfk(a)gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 11344] Perldoc issues in misc/cronjobs/advance_notices.pl
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '21

19 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11344 --- Comment #1 from James O'Keeffe <jamespfk(a)gmail.com> --- Created attachment 115363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115363&action=e… Bug 11344: Perldoc issues in misc/cronjobs/advance_notices.pl This patch removes the double ups in the perldoc of the above file, deleting the less clear double ups. The missing "-c" in OPTIONS appears to have been fixed in an earlier patch (it is there already). Task Plan: 1. Run perldoc misc/cronjobs/advance_notices.pl in the terminal. Note the double ups of NAME, SYNOPSIS, and DESCRIPTION 2. Apply the patch 3. Run the command again. The double ups should be gone, with the more clear version of each of NAME, SYNOPSIS, and DESCRIPTION remaining. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11344] Perldoc issues in misc/cronjobs/advance_notices.pl
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '21

19 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11344 James O'Keeffe <jamespfk(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 26067] New: Email validation of member based on MX record
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '21

19 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26067 Bug ID: 26067 Summary: Email validation of member based on MX record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: amitddng135(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Currently we are checking Email validation of member (both Staff and OPAC interface)based on the Email::Valid->address but we are not checking the MX record of the domain name, We have encountered the issue with one of our client while doing the email validation through PatronSelfRegistration. I am planning to add below code. Email::Valid->address( -address => 'amitddng135(a)gmail.com', -mxcheck => 1 ); instead of Email::Valid->address('amitddng135(a)gmail.com'); Can you provide us your feedback. Should we do fix code through system preference for ex: "EmailValidationMXrecord" or without system preference. -- You are receiving this mail because: You are watching all bug changes.

1 27

[Bug 11344] Perldoc issues in misc/cronjobs/advance_notices.pl
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '21

19 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11344 James O'Keeffe <jamespfk(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |jamespfk(a)gmail.com Status|NEW |ASSIGNED CC| |jamespfk(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10744] ExpireReservesMaxPickUpDelay works with hold(s) over report
by bugzilla-daemon＠bugs.koha-community.org 19 Jan '21

19 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 Mazen Khallaf <mazen.i.khallaf(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mazen.i.khallaf(a)gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Mazen Khallaf <mazen.i.khallaf(a)gmail.com> --- Couldn't apply patch during signoff. $ git bz apply 10744 Bug 10744 - ExpireReservesMaxPickUpDelay works with hold(s) over report 110030 - Bug 10744: DO NOT PUSH! Schema change 110031 - Bug 10744 - ExpireReservesMaxPickUpDelay works with hold(s) over report Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 10744: DO NOT PUSH! Schema changes Using index info to reconstruct a base tree... M Koha/Schema/Result/OldReserve.pm M Koha/Schema/Result/Reserve.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Schema/Result/Reserve.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Reserve.pm Auto-merging Koha/Schema/Result/OldReserve.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/OldReserve.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 10744: DO NOT PUSH! Schema changes The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-10744-DO-NOT-PUSH-Schema-change-RxpQb0.patch -- You are receiving this mail because: You are watching all bug changes.

1 0