October 2021 - Koha-bugs - lists.koha-community.org

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '21

18 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #388 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Regression found, the order of the subfields (introduced by bug 7882) is not kept. To recreate: Turn on MARCOverlayRules Edit a record Change the order of subfields Save Edit again => The order hasn't been saved. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '21

18 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #387 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Created attachment 126431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126431&action=e… Bug 14957: Fix syspref's values It didn't switch off when set to "don't use" -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '21

18 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '21

18 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #386 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Created attachment 126425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126425&action=e… Bug 14957: Fix record preview -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '21

18 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #385 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Created attachment 126424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126424&action=e… Bug 14957: (follow-up) Clarify 'context' param -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '21

18 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #384 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to David Gustafsson from comment #383) > > > 6. How does it interface with the marc modification templates when batch > > > editing bibliographic records? > > > > Investigating.. I have a feeling his patchset predates it and I missed this > > case ! :( > > Sorry, never got around to have a look at this yesterday, but now did. From > what I can gather from the code I'm pretty sure that if no rules have been > defined for the batchmod context, the incoming record simply overwrites the > existing record. If there are rules, these are applied on the record after > the record has been modified using the specified template. So if the > modification template modifies some protected field for example, these > changes will not be applied. This is expected behavior as far as I can tell? Tested right now: - Protect 500 - Edit bibliographic record, add new 500 field => Change not saved (OK) - Use the batch record modification tool (previously created a MARC modification template that add a 500$a => The preview show the 500$a (KO) - Save => The new field is created (KO) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 28796] New: wrong number of parameters in new_from_xml call
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '21

18 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28796 Bug ID: 28796 Summary: wrong number of parameters in new_from_xml call Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs(a)lists.koha-community.org Reporter: didier.gautheron(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Hi, It seems to me that C4/ImportBatch.pm: my $old_marc = MARC::Record->new_from_xml(StripNonXmlChars($oldxml), 'UTF-8', $rowref->{'encoding'}, $marc_type); Is calling MARC::Record->new_from_xml with the wrong number of parameters and $marc_type is ignored it should be either: MARC::Record->new_from_xml(StripNonXmlChars($oldxml), 'UTF-8', $marc_type); or: MARC::Record->new_from_xml(StripNonXmlChars($oldxml),$rowref->{'encoding'} , $marc_type); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '21

18 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 mathieu saby <mathsabypro(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '21

18 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 --- Comment #64 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 126414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126414&action=e… Bug 14367: Updated schema files -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '21

18 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121076|0 |1 is obsolete| | --- Comment #63 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 126413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126413&action=e… Bug 14367: Add MARC record history This is a proof-of-concept implementation for adding history support to MARC records. Every time a change is made a complete copy of the record is stored along with the date/time and user identity. The changes are listed under each field in the MARC record editor and can be reverted with a click. The changes are stored as a JSON array in a new column named 'history' in the database. The array is re-read from the database before updating the record to prevent old data lingering in the session from overwriting newer changes made by other users. If we decide to implement this feature it might be better to simply create a new table altogether and link it rather than the clumsy JSON solution. That would eliminate a lot of bulky code that transforms MARC-KOHA-JSON and back while ensuring data integrity. Also, there are plans to add permissions to the MARC records; this likely requires more complex interactions that will scale badly with the current JSON solution. At present, the history is hardcoded to 10 entries. This can easily be made into a syspref. The current implementation should probably be refactored into a 'BiblioHistory' class before deploying. Documentation of the functions/methods are also needed. Icon is ugly and needs to be improved. Sponsored-By: Halland County Library & Catalyst IT Test plan: * Update the database, update the schema files, restart services * Log into Staff interface, search for a title, choose to edit it's MARC record. * Chose a MARC field and modify it, press Save. * Open the MARC editor again for the same title. * Next to the edited field a new icon should appear, looking like a clock face with a encircling arrow; the history icon. * Clicking the icon should open a table showing all changes done to the record, including value change, date/time and user name. * Clicking a record in the history log should revert that field to the clicked value (a previous value) * Run prove t/db_dependent/BiblioHistory.t and confirm all tests pass Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0