October 2021 - Koha-bugs - lists.koha-community.org

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '21

08 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #47 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Bug 29106 comment14 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29019] New: Unable to delete HTML customization
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '21

08 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29019 Bug ID: 29019 Summary: Unable to delete HTML customization Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org Hi all, I don't know if I'm just not doing it right, but I cannot seem to be able to delete an HTML customization. To replicate : 1. Go to Tools > HTML customizations 2. Click on New entry 3. Fill out the form (I tried it with OpacSuggestionInstructions and OpacLoginInstructions) 4. Click Save 5. In the list of HTML customizations, click on the Delete button at the end of the row -> Note that it goes back to Additional contents (News) instead of Additional contents (HTML customizations) 6. Go back to Tools > HTML customizations -> Note that the entry you deleted is still there Since it goes back to Additional contents (News) after deleting, I'm wondering if it has something to do with the separation of News and HTML customizations... Caroline -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 12

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '21

08 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #46 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #45) > (In reply to Jonathan Druart from comment #44) > > Created attachment 125951 [details] [review] [review] > > Bug 3142: Handle biblio level item type > > Something like that? Yeah, looks like it. But we should definitely get rid of this preference. The maintenance cost is much higher than the user benefit (where a large majority is not using it; 95% or more?) At upgrade time we could set items.itype correct for this minority and make sure that the itype at item creation defaults to 942c correctly. It was discussed already somewhere. We should do it in 22.05. Didnt test this change yet btw. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '21

08 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #45 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Jonathan Druart from comment #44) > Created attachment 125951 [details] [review] > Bug 3142: Handle biblio level item type Something like that? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '21

08 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #44 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Created attachment 125951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125951&action=e… Bug 3142: Handle biblio level item type -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '21

08 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #43 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Marcel de Rooy from comment #42) > while ( my $item = $items->next ) { > - $norequests = 0 > - if $norequests > - && !$item->withdrawn > - && !$item->itemlost > - && ($item->notforloan < 0 || not $item->notforloan ) > - && !Koha::ItemTypes->find($item->effective_itemtype)->notforloan > - && $item->itemnumber; > - > $allow_onshelf_holds = Koha::CirculationRules->get_onshelfholds_policy( > { item => $item, patron => $patron } ) > unless $allow_onshelf_holds; > > Could this loop be done smarter now? We could certainly have get_onshelfholds_policy take a Koha::Items iterator and do things there to avoid the while. > opac/opac-ISBDdetail.pl > - && !Koha::ItemTypes->find($item->effective_itemtype)->notforloan > opac/opac-MARCdetail.pl > - && !Koha::ItemTypes->find($item->effective_itemtype)->notforloan > opac-detail.pl > - && !$itemtypes->{$itm->{'itype'}}->{notforloan} > Added a follow-up that looks at notforloan but effective is still another > story. Good catch. Isn't it blocker? Looks like a regression :-/ -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '21

08 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #42 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- while ( my $item = $items->next ) { - $norequests = 0 - if $norequests - && !$item->withdrawn - && !$item->itemlost - && ($item->notforloan < 0 || not $item->notforloan ) - && !Koha::ItemTypes->find($item->effective_itemtype)->notforloan - && $item->itemnumber; - $allow_onshelf_holds = Koha::CirculationRules->get_onshelfholds_policy( { item => $item, patron => $patron } ) unless $allow_onshelf_holds; Could this loop be done smarter now? opac/opac-ISBDdetail.pl - && !Koha::ItemTypes->find($item->effective_itemtype)->notforloan opac/opac-MARCdetail.pl - && !Koha::ItemTypes->find($item->effective_itemtype)->notforloan opac-detail.pl - && !$itemtypes->{$itm->{'itype'}}->{notforloan} Added a follow-up that looks at notforloan but effective is still another story. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '21

08 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #41 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 125950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125950&action=e… Bug 3142: (QA follow-up) Include notforloan itemtypes As was done in the code already. Note that we are ignoring effective itemtype now. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '21

08 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #40 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 125949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125949&action=e… Bug 3142: (QA follow-up) Cosmetic changes Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '21

08 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125734|0 |1 is obsolete| | --- Comment #39 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 125948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125948&action=e… Bug 3142: Add note about imprecision of filter_by_for_hold Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0