February 2021 - Koha-bugs - lists.koha-community.org

[Bug 27819] New: Spurious errors when running delete_records_via_leader.pl
by bugzilla-daemon＠bugs.koha-community.org 24 May '21

24 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27819 Bug ID: 27819 Summary: Spurious errors when running delete_records_via_leader.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz The job reports errors when deleting items. The issue seems to be that Koha::Object->delete claims in the POD to return -1, 0, or 1 as a result, but it in fact returns the Object itself on a successful deletion The errors are reported as: ERROR DELETING ITEM 501740: Koha::Item=HASH(0x55ce407a1a78) To recreate: 1 - Find or create a record with some items 2 - Ensure those items can be deleted (not on loan, etc.) 3 - Edit the record leader and set position 5 to 'd' 4 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm 5 - Deletion succeeds, but reports failure on items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 26405] New: Circulation.t fails on 'AddRenewal left both fines'
by bugzilla-daemon＠bugs.koha-community.org 24 May '21

24 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26405 Bug ID: 26405 Summary: Circulation.t fails on 'AddRenewal left both fines' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: emmi.takkinen(a)outlook.com QA Contact: testopia(a)bugs.koha-community.org Running prove t/db_dependent/Circulation.t, I receive following error: t/db_dependent/Circulation.t .. 1/48 # Failed test 'AddRenewal left both fines' # at t/db_dependent/Circulation.t line 591. # got: '1' # expected: '2' # Looks like you planned 83 tests but ran 28. # Looks like you failed 1 test of 28 run. t/db_dependent/Circulation.t .. 15/48 # Failed test 'CanBookBeRenewed tests' # at t/db_dependent/Circulation.t line 1255. Can't call method "status" on an undefined value at t/db_dependent/Circulation.t line 593. Adding t::lib::Mocks::mock_preference('CalculateFinesOnReturn', 1) solved problem since bug 23051 added following to Circulation.pm: if ( !$skipfinecalc && C4::Context->preference('CalculateFinesOnReturn') ) { _CalculateAndUpdateFine( { issue => $issue, item => $item_unblessed, borrower => $patron_unblessed } ); } However I'm unsure if this is appropriate solution or are those tests invalid at this point. -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 21818] New: Don't use AutoCommit flag in stage-marc-import.pl
by bugzilla-daemon＠bugs.koha-community.org 24 May '21

24 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21818 Bug ID: 21818 Summary: Don't use AutoCommit flag in stage-marc-import.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Like Bug 18806, we should replace the use of AutoCommit flag by DBIx transaction. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 27566] New: CSS rule not applying to HTML select / option - displays with serif font ignoring rules
by bugzilla-daemon＠bugs.koha-community.org 24 May '21

24 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 Bug ID: 27566 Summary: CSS rule not applying to HTML select / option - displays with serif font ignoring rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: Mac OS Status: NEW Severity: critical Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: ramos.rodolfo(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org System uses NotoSans to render content, the font file loads correctly (see it in the network while using inspector). The HTML select displays with serif fonts.The CSS rules applied to select and option is font-family: NotoSans. In this instance i think there should be a fallback like font-family: NotoSans, sans-serif. -- You are receiving this mail because: You are watching all bug changes.

1 36

[Bug 23195] New: Shipping costs are inconsistent in where displayed
by bugzilla-daemon＠bugs.koha-community.org 24 May '21

24 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23195 Bug ID: 23195 Summary: Shipping costs are inconsistent in where displayed Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- When an invoice has shipping costs included in it, the totals are displayed inconsistently in Koha Acquisitions. If looking at the acqui-home.pl, the shipping costs are included in the total, however, clicking on the link to see the ordered totals (ordered.pl), shipping costs are not included in this view, causing the totals to not be consistent. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 24

[Bug 27120] New: Sent biblio to Koha plugins hook 'intranet_catalog_biblio_tab'
by bugzilla-daemon＠bugs.koha-community.org 24 May '21

24 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27120 Bug ID: 27120 Summary: Sent biblio to Koha plugins hook 'intranet_catalog_biblio_tab' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Koha plugins hook 'intranet_catalog_biblio_tab' should have the datas of the current biblio record. Koha::Biblio is aleady in template, send it with hooks call. Depends on Bug 27114 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 26

[Bug 27114] New: Use Template Toolkit plugin for Koha plugins hook 'intranet_catalog_biblio_tab'
by bugzilla-daemon＠bugs.koha-community.org 24 May '21

24 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27114 Bug ID: 27114 Summary: Use Template Toolkit plugin for Koha plugins hook 'intranet_catalog_biblio_tab' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Koha plugins hook 'intranet_catalog_biblio_tab' is for a template, it will be better it uses Template Toolkit plugin like intranet_js, ... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 31

[Bug 27282] New: Print List (shelves.pl) broken in Chrome
by bugzilla-daemon＠bugs.koha-community.org 24 May '21

24 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Bug ID: 27282 Summary: Print List (shelves.pl) broken in Chrome Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Lists Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl In more recent version of Chrome if you go to /cgi-bin/koha/virtualshelves/shelves.pl and attempt to 'Print list' the dialog pops up and immediately closes. We fixed this problem in the OPAC with Bug 24061, the same fix is needed in the staff client on shelves.pl Read Bug 24061 for much of the details. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 40

[Bug 27232] New: Missing spaces in member-alt-contact-style.inc make some strings appearing twice in po
by bugzilla-daemon＠bugs.koha-community.org 24 May '21

24 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 Bug ID: 27232 Summary: Missing spaces in member-alt-contact-style.inc make some strings appearing twice in po Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org >From the koha-translate ML: #. %1$s: END #: koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-contact-style.inc:162 #, c-format msgid "%s State:" msgstr "%s Provincia:" #. For the first occurrence, #. %1$s: END #: koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style.inc:177 #: koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style.inc:168 #, c-format msgid "%s State: " msgstr "%s Stato: " We need to add a space between ":" and "</label>" https://lists.koha-community.org/pipermail/koha-translate/2020-December/002… -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 20854] New: Redirect after logout with CAS 3.0 broken
by bugzilla-daemon＠bugs.koha-community.org 24 May '21

24 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854 Bug ID: 20854 Summary: Redirect after logout with CAS 3.0 broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org There has been a change in the parameters for the logout request between CAS 2.0 und CAS 3.0: Redirect URL parameter CAS 2.0: url CAS 3.0: service The CAS module used by Koha officially only support CAS 2.0, so when you logout from a CAS 3.0 server now, the redirect to Koha will be broken. See here: https://github.com/apereo/cas/blob/master/docs/cas-server-documentation/pro… Note: The url parameter defined in the former CAS 2.0 specification is not a valid parameter in CAS 3.0 anymore. CAS Servers MUST ignore given url parameters. A CAS client MAY provide the service parameter as described above, as this ensures the parameter is validated against the registered service URLs when operating in non-open mode. See 2.3.2 for details. We are using the following 'hack' to make the redirect work correctly: C4/Auth_with_cas.pm $uri =~ s/\?logout\.x=1//; # We don't want to keep triggering a logout, if we got here, the borrower is already logged out of Koha - print $query->redirect( $cas->logout_url(url => $uri)); + my $logout_url = $cas->logout_url(url => $uri); + $logout_url =~ s/url/service/; + print $query->redirect( $logout_url ); We won't have time to fix this properly, but wanted to document problem and workaround at least. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 30