February 2021 - Koha-bugs - lists.koha-community.org

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #117 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- Created attachment 116825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116825&action=e… Bug 11175: Keep component part record list items inside the box Without this the number denoting the component part item in the list will overflow and is partly hidden. To test: 1) Create 100 component parts 2) Notice without this patch the number next to the component part is not fully shown Signed-off-by: Pasi Kallinen <pasi.kallinen(a)koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #116 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- Created attachment 116824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116824&action=e… Bug 11175: Add Elasticsearch support Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Pasi Kallinen <pasi.kallinen(a)koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #115 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- Created attachment 116823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116823&action=e… Bug 11175: (follow-up) Relocate and reword ShowComponentRecords syspref description The syspref is not only affecting staff interface so moving it to Cataloguing section. Added also notes about UNIMARC and Elasticsearch not being supported. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Pasi Kallinen <pasi.kallinen(a)koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #114 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- Created attachment 116822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116822&action=e… Bug 11175: (follow-up) Add tests Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Pasi Kallinen <pasi.kallinen(a)koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #113 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- Created attachment 116821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116821&action=e… Bug 11175: (follow-up) Return empty array if no components Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Pasi Kallinen <pasi.kallinen(a)koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #112 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- Created attachment 116820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116820&action=e… Bug 11175: (follow-up) Don't return explicitly undef This would create in list context an list of one element that is undef, which we don't want, we want empty list if there are no components. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Pasi Kallinen <pasi.kallinen(a)koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114326|0 |1 is obsolete| | Attachment #114327|0 |1 is obsolete| | Attachment #114328|0 |1 is obsolete| | Attachment #114329|0 |1 is obsolete| | Attachment #114330|0 |1 is obsolete| | Attachment #114331|0 |1 is obsolete| | Attachment #114332|0 |1 is obsolete| | Attachment #114333|0 |1 is obsolete| | Attachment #114334|0 |1 is obsolete| | --- Comment #111 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- Created attachment 116819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116819&action=e… Bug 11175: Show record component parts in the detail view Shows the component records of a host, on the hosts detail view in staff client or OPAC, with clickable links to the component records. The host does not require linking entries to the components, but components do require a link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. Adds 'Yet Another System Preference', ShowComponentRecords, which can be used to turn this feature on or off in staff client and/or OPAC, and defaults to off. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001' or, if the 003 is not defined in the Host, 773$w=Host001. Does not use easyanalytics or useControlNumber. Only for MARC21 biblios - UNIMARC has not been updated. staff-global.css and opac.css have not been recreated, so you need to use sass to recreate those from staff-global.scss and opac.scss Test plan: 0) Apply patch 1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML (This file is an attachment on the bug) 2) rebuild the zebra biblio index 3) Search for "easy piano" in staff client, and go to the biblio detail page. You should not see anything different in the record detail page. 4) Do the same on OPAC. 5) Change the ShowComponentRecords syspref appropriately and check the record detail page in staff client and OPAC. You should see a list of component part records. Rebased-by: Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Pasi Kallinen <pasi.kallinen(a)koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8137] Checkout limit by patron category for all libraries
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #76 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- And, last question (hopefully), why don't we have the "has priority" only for "Default checkout, hold policy by patron category", if it is what we really wanted to fix? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8137] Checkout limit by patron category for all libraries
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #75 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- The bug report title and commit message must be updated to describe what we are doing here. It's not only impacting "checkouts", but all rules! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8137] Checkout limit by patron category for all libraries
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '21

12 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed Status|Passed QA |Failed QA --- Comment #74 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- 1. +sub priority { + my ($self) = @_; + + return $self->has_priority; +} It does not seem very useful, especially when it's only used once, from test. 2. +ALTER TABLE circulation_rules ADD KEY (branchcode , categorycode, itemtype, has_priority); Why? Note that it's missing from kohastructure.sql 3. There is a shift when you edit the line, the "unlimited" (stupid) trick The followin line (smart-rules.tt): 1169 } else if ( i == 5 || i == 6 || i == 26 || i == 27 || i == 28 ) { 4. I think we need a hint on the UI (tooltip on the "Has priority" header?) to explain what this column is about. 5. Reading the code I don't understand why the first query in get_effective_rule is not passing the item type. 211 $search_params->{rule_name} = $rule_name; 212 $search_params->{categorycode} = defined $categorycode ? [ $categorycode, undef ] : undef; 213 $search_params->{has_priority} = 1; What will happen if Cat 1 | BK | has priority | max_holds = 5 Cat 1 | VID | has priority | max_holds = 2 It feels like you are going to get a random value. -- You are receiving this mail because: You are watching all bug changes.

1 0