March 2021 - Koha-bugs - lists.koha-community.org

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '21

30 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68375|0 |1 is obsolete| | Attachment #68376|0 |1 is obsolete| | Attachment #68377|0 |1 is obsolete| | Attachment #68378|0 |1 is obsolete| | Attachment #68379|0 |1 is obsolete| | Attachment #68380|0 |1 is obsolete| | --- Comment #101 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 119016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119016&action=e… Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. What this patch does: The Koha::Patron::notice_email_address subroutine has been renamed to Koha::Patron::notice_email_addresses (plural). It only gets the patron emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1. Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2. Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3. Verify the email is correctly sent to the message_queue. 4. Fill the pref with email and emailpro (for instance) 5. Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6. You can also verify that only 1 notice is generated if the emailpro is empty. Important note for testers: Pending messages must be removed each time you change the value of AutoEmailPrimaryAddress. When there are already existing pending messages for a borrower, Koha tries to update them rather than enqueuing new ones, but it will not update the recipient's email address, nor add/remove messages depending on the new value of AutoEmailPrimaryAddress; not sure if this is a bug or not. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '21

30 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Failed QA |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #14 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Pretty sure with is fixed now.. bug 10876 perhaps.. Either way, I can't replicate the bug so I think we're safe to close :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15338] Remove inconsistency in location of SIPServer.pm
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '21

30 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15338 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15338] Remove inconsistency in location of SIPServer.pm
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '21

30 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15338 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45526|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15338] Remove inconsistency in location of SIPServer.pm
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '21

30 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15338 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Attachment #45525|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15338] Remove inconsistency in location of SIPServer.pm
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '21

30 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15338 --- Comment #5 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 119003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119003&action=e… Bug 15338: Fix indentation and comments in SIPServer Supplemental patch which takes advantage of the relocation of the program to apply a consistent indentation to the code also removes comments arising from the confusion resulting from the program's name and location Add a comment indicating that this code will work under other flavours of Net::Server as well as PreFork -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15338] Remove inconsistency in location of SIPServer.pm
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '21

30 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15338 --- Comment #4 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 119002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119002&action=e… Bug 15338: Move SIPServer to bin directory SIPServer should reside like other programs in the bin directory rather than lurking in modules removed the pm suffix which confused some users sip_run.sh can now be simplified and not fail because of misuse of path definition as a directory removed the unnecessary sourcing of .bash_profile in shutdown (what if you dont have a bash_profile?) SIP modules are now in standard lib path so Server does not need to set its own lib -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15729] New: SIP server allows checkin of reserved item
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '21

30 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15729 Bug ID: 15729 Summary: SIP server allows checkin of reserved item Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: bc(a)interleaf.ie QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com At present the SIP server will allow an item to be returned even if there is an outstanding hold on it. Some libraries do not see this as an issue and run reports for reserves before re-shelving. However, some prefer to have the item denied at the selfservice unit and force the borrower to return the item to the desk. With this in mind there should be a SIP systempreference which allows libraries to specify if a reserved item should be permitted to be checked in via the selfservice unit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 25541] New: Add ability to prevent checkin of items with holds
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '21

30 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Bug ID: 25541 Summary: Add ability to prevent checkin of items with holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com Some libraries would like patrons to be unable to return items with holds via SIP. Instead, the screen message should indicate that the patron should return that item at the circ desk so a librarian can use it to fill the next hold right away and place it on the hold shelf. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 33

[Bug 12169] Improve reliability of sip_shutdown script
by bugzilla-daemon＠bugs.koha-community.org 30 Mar '21

30 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12169 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99533|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 119001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119001&action=e… Bug 12169 Use pid file in sipserver shutdown Change sample SIPConfig to request server writes a pid file Use this pid in shutdown rather than the current open to error method. Have also added to the Config parameters to ensure that the sipserver runs as the correct user and sets its own session id. These are always useful but makes it easier for users to run up the sipserver as root at boot time similarly to apache, mysql etc Added to the sample config where to locate other server parameter documentation. Removed from the sample config the unedifying, unwanted and purely historical http example Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0