March 2021 - Koha-bugs - lists.koha-community.org

[Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '21

10 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118077|1 |0 is patch| | Attachment #118077|0 |1 is obsolete| | --- Comment #12 from Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> --- Comment on attachment 118077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118077 Bug 15563: add option to cleanup_database to delete old label and card batches mistyped a bug number, sorry! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '21

10 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 --- Comment #11 from Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> --- Created attachment 118077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118077&action=e… Bug 15563: add option to cleanup_database to delete old label and card batches To test: For item label batches: 1- Create 3 item label batches of at least 2 items each 2- Perform the following updates via the database 3- In Batch 1, set all items' timestamps to 10+ days prior to today 4- In Batch 2, set 1 item's timestamp to 10+ days prior to today 5- In Batch 3, do not update any timestamps 6- Run cron with --labels 9 7- Confirm batch 1 is deleted, batches 2 and 3 are not Repeat with card creator batches 8- Create 3 card creator batches of at least 2 items each 9- Perform the following updates via the database 10- In Batch 1, set all cards' timestamps to 10+ days prior to today 11- In Batch 2, set 1 card's timestamp to 10+ days prior to today 12- In Batch 3, do not update any timestamps 13- Run cron with --cards 9 14- Confirm batch 1 is deleted, batches 2 and 3 are not -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15563] Add option to regularly delete patroncard and label batches to cleanup_database.pl cronjob
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '21

10 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15563 Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107639|0 |1 is obsolete| | --- Comment #20 from Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> --- Comment on attachment 107639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107639 Bug 15563: add label and card creator batch deletion to cleanup_database >From cb0cdb4c97783566339d080be1a6263bad4caf97 Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> >Date: Mon, 20 Jul 2020 15:09:30 +0000 >Subject: [PATCH] Bug 15563: add label and card creator batch deletion to > cleanup_database > >To test: >For item label batches: >1- Create 3 item label batches of at least 2 items each >2- Perform the following updates via the database >3- In Batch 1, set all items' timestamps to 10+ days prior to today >4- In Batch 2, set 1 item's timestamp to 10+ days prior to today >5- In Batch 3, do not update any timestamps >6- Run cron with --labels 9 >7- Confirm batch 1 is deleted, batches 2 and 3 are not > >Repeat with card creator batches >8- Create 3 card creator batches of at least 2 items each >9- Perform the following updates via the database >10- In Batch 1, set all cards' timestamps to 10+ days prior to today >11- In Batch 2, set 1 card's timestamp to 10+ days prior to today >12- In Batch 3, do not update any timestamps >13- Run cron with --cards 9 >14- Confirm batch 1 is deleted, batches 2 and 3 are noti >--- > misc/cronjobs/cleanup_database.pl | 47 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > >diff --git a/misc/cronjobs/cleanup_database.pl b/misc/cronjobs/cleanup_database.pl >index c2d8e9832c..d59fa3a368 100755 >--- a/misc/cronjobs/cleanup_database.pl >+++ b/misc/cronjobs/cleanup_database.pl >@@ -103,6 +103,9 @@ Usage: $0 [-h|--help] [--confirm] [--sessions] [--sessdays DAYS] [-v|--verbose] > --pseudo-transactions DAYS Purge the pseudonymized transactions that have been originally created more than DAYS days ago > DAYS is optional and can be replaced by: > --pseudo-transactions-from YYYY-MM-DD and/or --pseudo-transactions-to YYYY-MM-DD >+ --labels DAYS Purge item label batches last added to more than DAYS days ago. >+ --cards DAY Purge card creator batches last added to more than DAYS days ago. >+ > USAGE > exit $_[0]; > } >@@ -577,6 +580,50 @@ if (defined $pPseudoTransactions or $pPseudoTransactionsFrom or $pPseudoTransact > ? sprintf "Done with purging %d pseudonymized transactions.", $count > : sprintf "%d pseudonymized transactions would have been purged.", $count; > } >+ $sth = $dbh->prepare( >+ q{ >+ DELETE FROM branchtransfers >+ WHERE datearrived < DATE_SUB(CURDATE(), INTERVAL ? DAY) >+ } >+ ); >+ $sth->execute($pTransfers); >+ print "Done with purging transfers.\n" if $verbose; >+} >+ >+if ($labels) { >+ print "Purging item label batches last added to more than $labels days ago.\n" if $verbose; >+ $sth = $dbh->prepare( >+ q{ >+ DELETE from creator_batches >+ WHERE batch_id in >+ (SELECT batch_id >+ FROM (SELECT batch_id >+ FROM creator_batches >+ WHERE creator='labels' >+ GROUP BY batch_id >+ HAVING max(timestamp) < date_sub(curdate(),interval ? day)) a) >+ } >+ ); >+ $sth->execute($labels) or die $dbh->errstr; >+ print "Done with purging item label batches last added to more than $labels days ago.\n" if $verbose; >+} >+ >+if ($cards) { >+ print "Purging card creator batches last added to more than $cards days ago.\n" if $verbose; >+ $sth = $dbh->prepare( >+ q{ >+ DELETE from creator_batches >+ WHERE batch_id in >+ (SELECT batch_id >+ FROM (SELECT batch_id >+ FROM creator_batches >+ WHERE creator='patroncards' >+ GROUP BY batch_id >+ HAVING max(timestamp) < date_sub(curdate(),interval ? day)) a); >+ } >+ ); >+ $sth->execute($cards) or die $dbh->errstr; >+ print "Done with purging card creator batches last added to more than $cards days ago.\n" if $verbose; > } > > exit(0); >-- >2.11.0 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15563] Add option to regularly delete patroncard and label batches to cleanup_database.pl cronjob
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '21

10 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15563 --- Comment #19 from Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> --- Updated patch to make sure it still applies and works -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15563] Add option to regularly delete patroncard and label batches to cleanup_database.pl cronjob
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '21

10 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15563 --- Comment #18 from Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> --- Created attachment 118076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118076&action=e… Bug 15563: add option to cleanup_database to delete old label and card batches To test: For item label batches: 1- Create 3 item label batches of at least 2 items each 2- Perform the following updates via the database 3- In Batch 1, set all items' timestamps to 10+ days prior to today 4- In Batch 2, set 1 item's timestamp to 10+ days prior to today 5- In Batch 3, do not update any timestamps 6- Run cron with --labels 9 7- Confirm batch 1 is deleted, batches 2 and 3 are not Repeat with card creator batches 8- Create 3 card creator batches of at least 2 items each 9- Perform the following updates via the database 10- In Batch 1, set all cards' timestamps to 10+ days prior to today 11- In Batch 2, set 1 card's timestamp to 10+ days prior to today 12- In Batch 3, do not update any timestamps 13- Run cron with --cards 9 14- Confirm batch 1 is deleted, batches 2 and 3 are not -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5697] Automatic linking in guided reports
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '21

10 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 --- Comment #27 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I wonder how the performance would be affected if we built the links in the template instead of with a render function and then just hid/displayed with JS? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 27905] New: Hidden buttons in Stage Marc Records when using Language Pack on Staff client with Chrome
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '21

10 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27905 Bug ID: 27905 Summary: Hidden buttons in Stage Marc Records when using Language Pack on Staff client with Chrome Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Created attachment 117990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117990&action=e… Languages covering up buttons When using Chrome, the bottom options (Save Profile, Profile Name, Stage Records, in Stage Marc Records for Import (under Tools) are not visible due to the Language options at the bottom of the staff client. They are visible if you reduce your screen to 50%, but after 50%, these buttons will not be seen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 27180] New: Fines cronjob does not update fines on holidays when finesCalendar is set to ignore
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '21

10 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27180 Bug ID: 27180 Summary: Fines cronjob does not update fines on holidays when finesCalendar is set to ignore Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The fines cronjob currently skips updating fines if the date it is run is a holiday for the applicable library. This is problematic when an item is marked lost the day following a holiday as we can end up missing a day of fines. Additionally it confuses things for libraries who do not expect the calendar to affect fines. This seems to have been done when dropbox mode used calculations on the 'last update' of a fine to determine how much to refund. Now that dropbox mode simply calculates the fine with a different return date this code is no longer needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 22

[Bug 25850] New: CalcDateDue freezes with 'useDaysMode' set to 'Daysweek' and the due date lands on a sunday.
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '21

10 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850 Bug ID: 25850 Summary: CalcDateDue freezes with 'useDaysMode' set to 'Daysweek' and the due date lands on a sunday. Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andreas.jonsson(a)kreablo.se QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com >From the DateTime manual page: $dt->day_of_week() Returns the day of the week as a number, from 1..7, with 1 being Monday and 7 being Sunday. Also available as "$dt->wday()" and "$dt->dow()". But the method "get_push_amt" assumes that day_of_week is numbered 0..6 with 0 being Sunday. (Also, there is a funny equality test of a boolean value and the number 1.) The result is that for Sundays, $self->{weekly_closed_days}->[$dow] is undefined and its negation is thus true, which results in a push_amt of seven days, which lands on the next Sunday and the process repeats. sub get_push_amt { my ( $self, $base_date) = @_; my $dow = $base_date->day_of_week; return ( # We're using Dayweek useDaysMode option $self->{days_mode} eq 'Dayweek' && # It's not a permanently closed day !$self->{weekly_closed_days}->[$dow] == 1 ) ? 7 : 1; } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 39

[Bug 5697] Automatic linking in guided reports
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '21

10 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 --- Comment #26 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 118022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118022&action=e… testing performance on a report with many rows It looks like the initial patch almost doubles the time to load the page fully, and the final patch add about the same I don't know how typical this many results is, and I really love the concept here, so I am not sure if this is a concern -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0