March 2021 - Koha-bugs - lists.koha-community.org

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '21

11 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117318|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 118139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118139&action=e… Bug 14233: (follow-up) Add notice code to log viewer Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '21

11 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117317|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 118138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118138&action=e… Bug 14233: (QA follow-up) Record updated content We should record the updated template, not the content prior to the update.. That way we can properly compare between versions to see the changes made. Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '21

11 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117316|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 118137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118137&action=e… Bug 14233: (QA follow-up) Fix typo in viewlog.tt We had a double ?? in the object link.. Thanks for spotting that David :) Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '21

11 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117315|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 118136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118136&action=e… Bug 14233: (follow-up) Fix for delete entire notice This fixes the overall notice delete option. Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '21

11 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117314|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 118135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118135&action=e… Bug 14233: Allow comparing notice changes This patch adds the 'compare' option to the Notices logs. Test plan 1/ Make some changes to at least two different notices to trigger logs 2/ Go to the 'Log viewer' from 'Tools' and filter on 'Notices' 3/ Note, you can now see the 'Compare' checkbox option for these logs 4/ Select the checkbox on one of the notices and note that the results are now filtered by that specific notice. 5/ Select a second checkbox to expose the option to 'View comparison' 6/ Click 'View comparison' to see the 'Diff view' of the two notices. 7/ Signoff Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '21

11 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117313|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 118134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118134&action=e… Bug 14233: Add filtering of NOTICES type action logs to the logviewer This patch adds handling for the new 'NOTICES' type action_logs to the logviewer page. Test plan 1/ Add some 'Notice' action logs by adding a new notice or updateing an existing notice 2/ Go to the 'Log viewer' under 'Tools' 3/ Note you can filter by 'Notices' 4/ Confirm the changes you made appear in the logs and that the 'Object' field links back to the updated notice ready for editing. 5/ Signoff Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '21

11 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117312|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 118133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118133&action=e… Bug 14233: Add logging to notice create/update/delete This patch adds the call to logaction to record when a notice is added or changed. Test plan 1/ Add a new notice and check a corresponding line appears in the action_logs table. 2/ Update a notice and check that a corresponding line appears in the action_logs table. 3/ Signoff Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '21

11 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117311|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 118132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118132&action=e… Bug 14233: Add 'id' field to `letter` table to allow linking To allow for 'object' linking from the action_logs table we need an int(11) identifier. This patch updates the letter table to add such a field as a replacement for the multi-field primary key and moves that key to a unique constraint. Test plan 1/ Run the database update 2/ Check that the 'letter' table now includes an 'id' primary key and 'letter_uniq_1' multi-field unique key 3/ Signoff Signed-off-by: Kelly McElligott <kelly(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27716] Insufficient access control for printer profiles
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '21

11 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27716 --- Comment #10 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Moved to main component.. it's easier to get through the motions of pushing this way.. and doesn't expose any real security issues in reality -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27716] Insufficient access control for printer profiles
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '21

11 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27716 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.

1 0