April 2021 - Koha-bugs - lists.koha-community.org

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '21

09 Apr '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '21

09 Apr '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119315|0 |1 is obsolete| | --- Comment #113 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 119362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119362&action=e… Bug 14233: Select the correct tab Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '21

09 Apr '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119314|0 |1 is obsolete| | --- Comment #112 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 119361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119361&action=e… Bug 14233: Add logging support to notices and slips management This enhancements adds support for logging changes to notices and slips. Features include: - a system preference (NoticesLog) which allows you to enable logging changes for notices and slips - logging new notices, changes to notices, and deletion of notices - filtering in the log viewer so you can show all changes for a specific notice - a comparison feature, so you can see what changes were made to a notice. Test plan: 1/ Add some 'Notice' action logs by adding a new notice or updateing an existing notice 2/ Go to the 'Log viewer' under 'Tools' 3/ Note you can filter by 'Notices' 4/ Confirm the changes you made appear in the logs and that the 'Object' field links back to the updated notice ready for editing. 1/ Make some changes to at least two different notices to trigger logs 2/ Go to the 'Log viewer' from 'Tools' and filter on 'Notices' 3/ Note, you can now see the 'Compare' checkbox option for these logs 4/ Select the checkbox on one of the notices and note that the results are now filtered by that specific notice. 5/ Select a second checkbox to expose the option to 'View comparison' 6/ Click 'View comparison' to see the 'Diff view' of the two notices. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '21

09 Apr '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119313|0 |1 is obsolete| | --- Comment #111 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 119360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119360&action=e… Bug 14233: DB changes - NoticesLog pref + letter.id PK Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '21

09 Apr '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119312|0 |1 is obsolete| | --- Comment #110 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 119359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119359&action=e… Bug 14233: DBIC schema changes Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27620] New: Remove fr-CA installer data
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '21

09 Apr '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27620 Bug ID: 27620 Summary: Remove fr-CA installer data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: bgkriegel(a)gmail.com, gmcharlt(a)gmail.com, jonathan.druart(a)bugs.koha-community.org, katrin.fischer(a)bsz-bw.de, koha-bugs(a)lists.koha-community.org, lucas(a)bywatersolutions.com, martin.renvoize(a)ptfs-europe.com, testopia(a)bugs.koha-community.org, victor(a)tuxayo.net Depends on: 24972, 24973, 27619, 24871 +++ This bug was initially created as a clone of Bug #27619 +++ Now we can translate all installer data, then the fr-CA directory is no longer needed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871 [Bug 24871] Add new *-installer-*.po translation files https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24972 [Bug 24972] Remove de-DE installer data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 [Bug 24973] Allow to localize and translate system preferences with new yaml based installer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 [Bug 27619] Remove de-DE installer data -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug.

1 5

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '21

09 Apr '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 --- Comment #109 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #108) > Comment on attachment 119315 [details] [review] > Bug 14233: Select the correct tab > > Review of attachment 119315 [details] [review]: > ----------------------------------------------------------------- > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt > @@ +340,4 @@ > > <a href="/cgi-bin/koha/authorities/detail.pl?authid=[% loopro.object | uri %]" title="Display detail for this authority">Authority [% loopro.object | html %]</a> > > [% ELSIF ( loopro.module == 'NOTICES' ) %] > > [% IF ( loopro.notice ) %] > > + <a href="/cgi-bin/koha/tools/letter.pl?op=add_form&branchcode=[% loopro.notice.branchcode | uri %]&module=[% loopro.notice.module | uri %]&code=[% loopro.notice.code | uri %]#lang_[% loopro.notice.lang | uri %]">Notice [% loopro.notice.title | html %] ([% loopro.notice.code | html %])</a> > > I don't understand this change. & => # if you are editing es-ES, on the log viewer the link was not redirecting you the the letter.pl es-ES tab, but the default one instead -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '21

09 Apr '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 --- Comment #108 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Comment on attachment 119315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119315 Bug 14233: Select the correct tab Review of attachment 119315: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=142…) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt @@ +340,4 @@ > <a href="/cgi-bin/koha/authorities/detail.pl?authid=[% loopro.object | uri %]" title="Display detail for this authority">Authority [% loopro.object | html %]</a> > [% ELSIF ( loopro.module == 'NOTICES' ) %] > [% IF ( loopro.notice ) %] > + <a href="/cgi-bin/koha/tools/letter.pl?op=add_form&branchcode=[% loopro.notice.branchcode | uri %]&module=[% loopro.notice.module | uri %]&code=[% loopro.notice.code | uri %]#lang_[% loopro.notice.lang | uri %]">Notice [% loopro.notice.title | html %] ([% loopro.notice.code | html %])</a> I don't understand this change. & => # -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11350] Holds offered to patrons who are not allowed to put the item on hold
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '21

09 Apr '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11350 --- Comment #3 from Lisette Scheer <lisetteslatah(a)gmail.com> --- This does appear to still be valid. We are on 20.05.09 It also shows up on the hold list if there is a copy that can be placed on hold for a patron but the only currently on-shelf copy can't be placed on hold for the patron. Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 28021] New: OPAC detail page contains incorrect Bootstrap classes (20.05.x)
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '21

08 Apr '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28021 Bug ID: 28021 Summary: OPAC detail page contains incorrect Bootstrap classes (20.05.x) Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org In 20.05.x the OPAC detail page contains the Bootstrap class 'col-lg-9' and not 'span9'. Since 20.05.x is not upgraded to Bootstrap 4 it cannot apply the correct CSS to OPAC detail page, making it display oddly. To fix this in the short term you can use the following OPACUserJS: if ( $('#opac-detail').length ) { $('#catalogue_detail_biblio').parent().addClass('span9').removeClass('col-lg-9'); } -- You are receiving this mail because: You are watching all bug changes.

1 18