May 2021 - Koha-bugs - lists.koha-community.org

[Bug 27885] Populate biblionumbers parameter when placing hold on single title
by bugzilla-daemon＠bugs.koha-community.org 11 May '21

11 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27885 --- Comment #7 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Katrin Fischer from comment #5) > Hi Nick, from your last comment#, should this be FQA (as in: Needs more > work)? You mention an issue with multi-holds for clubs. > > I doesn't apply, the conflict looks simple, but setting this one step back > to get confirmation. This should be good to move forward - the problems you mentioned and the one I found exist before the patch, the patch fixes the cases it is targeting -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27885] Populate biblionumbers parameter when placing hold on single title
by bugzilla-daemon＠bugs.koha-community.org 11 May '21

11 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27885 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117871|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 120831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120831&action=e… Bug 27885: Populate biblionumbers parameter using biblionumbers array Currently we send $biblionumbers as the parameter, but this is just apassthrough form when a list of biblios is selected for placing a hold If passed a single biblionumber we push it into @biblionumbers and use that for building the biblio loop This patch uses @biblionumbers to avoid sending a blank variable in the URL To test: 1 - On the staff client click 'place hold' for an individual record 2 - Use the form to find a patron 3 - Note the url is: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers= 4 - Apply patch 5 - Repeat 6 - The url is now like: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=248 (but with whatever biblionumber you chose) 7 - Perform a search and select multiple biblios and confirm you can place holds as before Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27885] Populate biblionumbers parameter when placing hold on single title
by bugzilla-daemon＠bugs.koha-community.org 11 May '21

11 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27885 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 26645] New: t/Koha/Script.t is failing randomly
by bugzilla-daemon＠bugs.koha-community.org 11 May '21

11 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26645 Bug ID: 26645 Summary: t/Koha/Script.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 25551 First time we see this one I think Koha_Master_D11 #103 14:41:47 koha_1 | # Failed test 'Exception found' 14:41:47 koha_1 | # at t/Koha/Script.t line 67. 14:41:47 koha_1 | # '' 14:41:47 koha_1 | # doesn't match '(?^u:Unable to acquire the lock.*)' 14:41:50 koha_1 | # Looks like you failed 1 test of 3. 14:41:50 koha_1 | 14:41:50 koha_1 | # Failed test 'lock_exec() tests' 14:41:50 koha_1 | # at t/Koha/Script.t line 85. 14:41:50 koha_1 | # Looks like you failed 1 test of 4. 14:41:50 koha_1 | [12:41:50] t/Koha/Script.t Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes.

1 4

[Bug 15261] Verify if checkout or hold request periods overlap with existing holds
by bugzilla-daemon＠bugs.koha-community.org 11 May '21

11 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #95 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- @Julian : You had this fix "Prevent checkout only if for a different borrower" on 17.11. All patches need master rebase. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15261] Verify if checkout or hold request periods overlap with existing holds
by bugzilla-daemon＠bugs.koha-community.org 11 May '21

11 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #94 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- Created attachment 120822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120822&action=e… Bug 15261: Prevent checkout only if for a different borrower -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27885] Populate biblionumbers parameter when placing hold on single title
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27885 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Nick, from your last comment#, should this be FQA (as in: Needs more work)? You mention an issue with multi-holds for clubs. I doesn't apply, the conflict looks simple, but setting this one step back to get confirmation. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 25557] New: Column config table in Acquisitions Order Does not Match the Acq table in Baskets
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Bug ID: 25557 Summary: Column config table in Acquisitions Order Does not Match the Acq table in Baskets Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: lucas(a)bywatersolutions.com Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The actual way that the Acq table appears in the basket view (basket.pl), 1.Basket # 2. Order information 3. RRP Tax Exc 4. Actual Cost Exc 5. Budgeted Cost Tax Exc 6. RRP Tax Included 7. Actual Cost Tax Inc 8. Budgeted Cost Tax Inc 9. Replacement Price 10. Quantity But in the column config table 1.Basket # 2. Order Info 3. RRP tax Exc 4. Ecost Exc (Actual Exc) 5. RRP tax Included 6. Ecost Tax Included (Actual Inc) 7. Replacement Prie 8. Quantity 9. Total Tax Excluded 10. Total Tax Included We will need to change the column configuration to match the table so it is easy to hide the correct columns. -- You are receiving this mail because: You are watching all bug changes.

1 24

[Bug 28310] New: request.pl using biblioitemnumber in biblionumber field
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28310 Bug ID: 28310 Summary: request.pl using biblioitemnumber in biblionumber field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: philippe.blouin(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com In reserve/request.pl, the code querying ItemsAnyAvailableAndNotRestricted (previously ItemsAnyAvailableForHold) is passing the biblioitemnumber as a value to a specified biblionumber. ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblioitemnumber, patron => $patron }) All you need is a Koha instance where the values of biblionumber and biblioitemnumber being different for this to break. And break badly. This occurs in 20.05+ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #129 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- (In reply to Joonas Kylmälä from comment #123) > I didn't realize the follow-ups here removed those git merge conflict > resolution hints. It would still probably be better if the conflicts were > solved in the patches they happen. If I review the patch "Test improvements > + check maxreserves" it contains merge resolution and test improvements, so > two things, git commits should do just one thing. Also "Bug 11999: (QA > follow-up)" doesn't say what it does. I've squashed fixes from QA follow-up inside patches. And rebase master. I set back to Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0