May 2021 - Koha-bugs - lists.koha-community.org

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120778|0 |1 is obsolete| | --- Comment #128 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- Created attachment 120780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120780&action=e… Bug 11999: Test improvements + check maxreserves improve t/db_dependent/Reserves.t to make tests pass on UNIMARC installation -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120776|0 |1 is obsolete| | --- Comment #127 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- Created attachment 120779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120779&action=e… Bug 11999: Add maxreserves check in CanBookBeReserved and CanItemBeReserved - Check if borrower has reached the maximum number of holds allowed (syspref maxreserves) The goal of this patch is to do these checks also when using ILS-DI services HoldTitle and HoldItem Test plan: ---------- Before patch: 1/ Set syspref maxreserves to 1 2/ Place some holds through ILS-DI and note that you can place more than 1 hold for a borrower Apply the patch 3/ Place some holds through ILS-DI, you shouldn't be able to place more than 1 hold for a borrower 4/ Try to place holds on staff interface and OPAC. The behaviour must be identical than before the patch. Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> Signed-off-by: Alex Arnaud <alex.arnaud(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112874|0 |1 is obsolete| | Attachment #120777|0 |1 is obsolete| | --- Comment #126 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- Created attachment 120778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120778&action=e… Bug 11999: Test improvements + check maxreserves improve t/db_dependent/Reserves.t to make tests pass on UNIMARC installation -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112872|0 |1 is obsolete| | --- Comment #125 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- Created attachment 120777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120777&action=e… Bug 11999: Test improvements + check maxreserves improve t/db_dependent/Reserves.t to make tests pass on UNIMARC installation -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112871|0 |1 is obsolete| | --- Comment #124 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- Created attachment 120776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120776&action=e… Bug 11999: Add maxreserves check in CanBookBeReserved and CanItemBeReserved - Check if borrower has reached the maximum number of holds allowed (syspref maxreserves) The goal of this patch is to do these checks also when using ILS-DI services HoldTitle and HoldItem Test plan: ---------- Before patch: 1/ Set syspref maxreserves to 1 2/ Place some holds through ILS-DI and note that you can place more than 1 hold for a borrower Apply the patch 3/ Place some holds through ILS-DI, you shouldn't be able to place more than 1 hold for a borrower 4/ Try to place holds on staff interface and OPAC. The behaviour must be identical than before the patch. Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> Signed-off-by: Alex Arnaud <alex.arnaud(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Medium patch |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7620] OPACNoResult, add search string to available parameters
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28241 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28241 [Bug 28241] OPACNoResultsFound {QUERY_KW} placeholder doesn't always match the search terms when commas are included in the search -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13613] Don't allow digest to be selected without a digest-able transport selected
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 --- Comment #22 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I see this more as a "helper" kind of thing. Nothing bad is going to happen if you check digest and no transport afaik - it just doesn't make sense? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13613] Don't allow digest to be selected without a digest-able transport selected
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #21 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #20) > It's not clear to me how strong we want to prevent that. > > 1. existing values: > a. should we update the DB? > b. what if the form is loaded with all checked? > 2. Shouldn't it be forbidden at lower level? TLDR - I think these are all correct, but this bug is very old and offers improvement - we should file new bugs for remaining issues 1 - a - The current behaviour if only digest selected is to send nothing - we check if they want a digest, then loop the transports - we could clean up, but loading a patron after this bug will fix things and behaviour won't change b - All checked is fine - digestible notices will be digested, and others will not be 2 - Yes, but things are handled in C4/Form/MessagingsPreferences.pm - this needs tests/moved to Koha -- You are receiving this mail because: You are watching all bug changes.

1 0