May 2021 - Koha-bugs - lists.koha-community.org

[Bug 14723] Additional delivery notes to messages
by bugzilla-daemon＠bugs.koha-community.org 05 May '21

05 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #55 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 120491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120491&action=e… Bug 14723: (QA follow-up) Fix typo Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14723] Additional delivery notes to messages
by bugzilla-daemon＠bugs.koha-community.org 05 May '21

05 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #54 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 120490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120490&action=e… Bug 14723: Add error codes and replace strings with them in template This patch adds error codes for delivery notes and replaces English strings with them in template. To test confirm everything works as intended. Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14723] Additional delivery notes to messages
by bugzilla-daemon＠bugs.koha-community.org 05 May '21

05 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #53 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 120489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120489&action=e… Bug 14723: Make delivery notes translatable Delivery notes weren't translatable. This patch adds them in notices.tt. If note is Mail::Sendmail error generic 'Error occured while sending email' is shown. Also fixes MySQLisms and adds AFTER to atomicupdate file. To test prove t/db_dependent/Letters.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin <stina.hallin(a)ub.lu.se> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14723] Additional delivery notes to messages
by bugzilla-daemon＠bugs.koha-community.org 05 May '21

05 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120487|0 |1 is obsolete| | --- Comment #52 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 120488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120488&action=e… Bug 14723: Additional delivery notes to messages This patch adds additional delivery notes to messages in message queue as there can be multiple reasons for a delivery to fail. Currently in message_queue we are given only two delivery statuses for messages, "sent" and "failed". When the status becomes failed, we have no idea why it fails. This feature can be useful with SMS gateway providers. Many SMS gateways inform the application the reason of SMS delivery failure. With this feature, this information can now be stored. As well as for emails, instead of simply logging failures, we can now store the reason of failure directly into the message row of message_queue. Test plan: 1. Enable EnhancedMessagingPreferences syspref 2. Find a borrower with notices at members/notices.pl 3. Observe that there is no column for Delivery notes 4. Apply patch and run the given database update 5. Repeat step 1. 6. Observe that there is now a column for Delivery notes Sponsored-by: Hypernova Oy Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14723] Additional delivery notes to messages
by bugzilla-daemon＠bugs.koha-community.org 05 May '21

05 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120309|0 |1 is obsolete| | Attachment #120310|0 |1 is obsolete| | Attachment #120312|0 |1 is obsolete| | Attachment #120314|0 |1 is obsolete| | Attachment #120376|0 |1 is obsolete| | --- Comment #51 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 120487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120487&action=e… Bug 14723: Additional delivery notes to messages This patch adds additional delivery notes to messages in message queue as there can be multiple reasons for a delivery to fail. Currently in message_queue we are given only two delivery statuses for messages, "sent" and "failed". When the status becomes failed, we have no idea why it fails. This feature can be useful with SMS gateway providers. Many SMS gateways inform the application the reason of SMS delivery failure. With this feature, this information can now be stored. As well as for emails, instead of simply logging failures, we can now store the reason of failure directly into the message row of message_queue. Test plan: 1. Enable EnhancedMessagingPreferences syspref 2. Find a borrower with notices at members/notices.pl 3. Observe that there is no column for Delivery notes 4. Apply patch and run the given database update 5. Repeat step 1. 6. Observe that there is now a column for Delivery notes Sponsored-by: Hypernova Oy Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14723] Additional delivery notes to messages
by bugzilla-daemon＠bugs.koha-community.org 05 May '21

05 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10460] way to stop a run away report
by bugzilla-daemon＠bugs.koha-community.org 05 May '21

05 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10460 Holly <hc(a)interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc(a)interleaf.ie -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24852] New: XSLT paths not adjusted for dev installs
by bugzilla-daemon＠bugs.koha-community.org 05 May '21

05 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24852 Bug ID: 24852 Summary: XSLT paths not adjusted for dev installs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org We are building the XSLT paths with intrahtdocs, it should be intranetdir (and assume that have the usual git structure) -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 05 May '21

05 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #311 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Working on this now -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 05 May '21

05 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116621|0 |1 is obsolete| | --- Comment #52 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 120480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120480&action=e… Bug 14367: Add MARC record history This is a proof-of-concept implementation for adding history support to MARC records. Every time a change is made a complete copy of the record is stored along with the date/time and user identity. The changes are listed under each field in the MARC record editor and can be reverted with a click. The changes are stored as a JSON array in a new column named 'history' in the database. The array is re-read from the database before updating the record to prevent old data lingering in the session from overwriting newer changes made by other users. If we decide to implement this feature it might be better to simply create a new table altogether and link it rather than the clumsy JSON solution. That would eliminate a lot of bulky code that transforms MARC-KOHA-JSON and back while ensuring data integrity. Also, there are plans to add permissions to the MARC records; this likely requires more complex interactions that will scale badly with the current JSON solution. At present, the history is hardcoded to 10 entries. This can easily be made into a syspref. The current implementation should probably be refactored into a 'BiblioHistory' class before deploying. Documentation of the functions/methods are also needed. Icon is ugly and needs to be improved. Sponsored-By: Halland County Library & Catalyst IT Test plan: * Run updatedatabase.pl * Log into Staff interface, search for a title, choose to edit it's MARC record. * Chose a MARC field and modify it, press Save. * Open the MARC editor again for the same title. * Next to the edited field a new icon should appear, looking like a clock face with a encircling arrow; the history icon. * Clicking the icon should open a table showing all changes done to the record, including value change, date/time and user name. * Clicking a record in the history log should revert that field to the clicked value (a previous value) * Run prove t/db_dependent/BiblioHistory.t and confirm all tests pass Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0