May 2021 - Koha-bugs - lists.koha-community.org

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 05 May '21

05 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 05 May '21

05 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #42 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 120478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120478&action=e… Bug 3150: (follow-up) HTML filtering TT notices and removing old files -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 05 May '21

05 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118313|0 |1 is obsolete| | --- Comment #41 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 120477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120477&action=e… Bug 3150: Move emails for sending cart and list contents to notices This patch creates notices using Template Toolkit syntax for sending emails containing cart and list contents. To test: 1. Apply Bug 27266 2. Run update database and restart services 3. In the staff client, add multiple items to your cart and to a list 4. Go to your cart and click Send to email the contents 5. Add an email and a comment and click Send 6. Confirm the information shown in the success message is correct 7. In your terminal, log into the database. View the message queue ( i.e. select * from message_queue; ). Confirm that your email has been queued and the content is all correct. Confirm the cart contents has been included as an attachment. 8. Go to your list and click Send list to email the contents 9. Repeat steps 5-7 10. Log into the OPAC 11. Add multiple items to your cart and to a list 12. Repeat steps 4-9 13. By the end, you should have four emails in your message queue. All of the data about the items should be correct, they should all have attachments, and be addressed to the correct email address. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 05 May '21

05 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 05 May '21

05 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #40 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- (In reply to Jonathan Druart from comment #38) > Why don't you HTML filter the variables in the template notice? The original notices use $raw filtering (sendbasket.tt etc), so that's what I used. I can change them all to HTML. (In reply to Jonathan Druart from comment #39) > Do we still need the following files? > > koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasket.tt > koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelf.tt > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasket.tt > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt I don't think so, I'll remove them. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12561] Omnibus: Deprecate non-XSLT detail and result views
by bugzilla-daemon＠bugs.koha-community.org 05 May '21

05 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 --- Comment #5 from David Cook <dcook(a)prosentient.com.au> --- Is the idea that Bug 11426 is the blocker for this? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12561] Omnibus: Deprecate non-XSLT detail and result views
by bugzilla-daemon＠bugs.koha-community.org 05 May '21

05 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 --- Comment #4 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Owen Leonard from comment #3) > (In reply to David Cook from comment #2) > > I feel like the non-XSLT view was deprecated just not removed? > > I don't understand what you're saying. Deprecated just means that it's not endorsed/recommended anymore but it is still available in the system. The XSLT view has been the default and the recommended view for quite a few years now. Even if we never explicitly said it was deprecated it has been deprecated in practice. If you look at ./koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt, there are about 152 lines of non-XSLT view. I think at this point that we could safely remove those lines. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 26364] New: XISBN.t makes a bad assumption about return values
by bugzilla-daemon＠bugs.koha-community.org 04 May '21

04 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26364 Bug ID: 26364 Summary: XISBN.t makes a bad assumption about return values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org 75 eval { $results_thingisbn = C4::XISBN::get_xisbns($isbn1,$biblionumber3); }; 76 SKIP: { 77 skip "Problem retrieving ThingISBN", 1 78 unless $@ eq ''; 79 is( $results_thingisbn->[0]->{biblionumber}, 80 undef, 81 "Doesn't get biblionumber if the biblionumber matches the one passed to the sub." ); 82 } Here we are testing that we don't get the same book that we passed into the sub in the list that is returned, however, we shouldn't assume that we get nothing, we should just check that it is not the biblionumber we passed in -- You are receiving this mail because: You are watching all bug changes.

1 38

[Bug 12782] t/db_dependent/XISBN.t should work on DOM too
by bugzilla-daemon＠bugs.koha-community.org 04 May '21

04 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12782 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28288 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28288 [Bug 28288] XISBN.t is failing is 500 is returned by the webservice -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7170] Remove use of XML::Simple
by bugzilla-daemon＠bugs.koha-community.org 04 May '21

04 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com, | |nick(a)bywatersolutions.com, | |tomascohen(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0