June 2021 - Koha-bugs - lists.koha-community.org

[Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '21

23 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Hakam Almotlak <hakam.almotlak(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hakam.almotlak(a)inLibro.com --- Comment #20 from Hakam Almotlak <hakam.almotlak(a)inLibro.com> --- patch does not apply on master Applying: Bug 15156: Get all patrons with owings Using index info to reconstruct a base tree... M Koha/Patrons.pm M t/db_dependent/Koha/Patrons.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Patrons.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/Patrons.t Auto-merging Koha/Patrons.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 15156: Get all patrons with owings -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '21

23 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #19 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Oh, totally forgot about this one, I'm really sorry Emmi. I actually introduced a similar method in bug 11983 though.. so perhaps worth comparing. I'll try to bring that one back up to date, updating tests etc.. it's been on my list for a long time :S -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15758] New: Move the C4::Branch related code to Koha::Libraries - part 4
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '21

23 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Bug ID: 15758 Summary: Move the C4::Branch related code to Koha::Libraries - part 4 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 15629 Blocks: 15293 This fourth and last part will remove: - GetBranchName - GetBranchesLoop - GetBranches - GetBranch will move mybranch and onlymine to C4::Context and finally remove all occurrences of C4::Branch. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15293 [Bug 15293] Move the C4::Branch related code to Koha::Libraries https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 -- You are receiving this mail because: You are watching all bug changes.

1 169

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '21

23 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Hakam Almotlak <hakam.almotlak(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hakam.almotlak(a)inLibro.com --- Comment #62 from Hakam Almotlak <hakam.almotlak(a)inLibro.com> --- patch does not apply Applying: Bug 14367: Add MARC record history Using index info to reconstruct a base tree... M C4/Biblio.pm Falling back to patching base and 3-way merge... Auto-merging C4/Biblio.pm CONFLICT (content): Merge conflict in C4/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 14367: Add MARC record history hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14367-Add-MARC-record-history-1fUpWI.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27151] New: SIP2 server doesn't handle broken connections which then kills SIP2 server
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '21

23 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27151 Bug ID: 27151 Summary: SIP2 server doesn't handle broken connections which then kills SIP2 server Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: joonas.kylmala(a)helsinki.fi QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com Koha SIP2 server doesn't handle the situation where a client unexpectedly closes socket, this leads to the SIP2 server processes being killed and therefore SIP2 service being unavailable. sip-error.log when this happens: koha3-koha-sip: client (pid 1181) killed by signal 13, stopping More info on this issue I found from the perl website manual (https://perldoc.perl.org/perlipc) "Be careful to check the return values from both open() and close(). If you're writing to a pipe, you should also trap SIGPIPE. [...]" Another problem we have is that the koha-common service doesn't start the process if it gets killed, but let's focus here only on the SIGPIPE issue. This has happened now 2 times in around 1 month period on our Koha SIP instances. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10

[Bug 28587] New: ldap auth fails unless <ldapserver id="ldapserver">
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '21

23 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28587 Bug ID: 28587 Summary: ldap auth fails unless <ldapserver id="ldapserver"> Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: marceau(a)unh.edu QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org This is related/similar to bug 28385. Apologies if this should be posted there instead. The fix there only works if ldapserver id is set to "ldapserver" and not anything else (such as <ldapserver id="ad.domain.com">). In previous versions ldapserver id could be set to anything. There is nothing in the release notes noting this behavior change so it seems to be a bug. To reproduce simply set ldapserver id to something else and restart plack. There should be lots of errors in the plack-error.log, most useful is: No ldapserver "hostname" defined in KOHA_CONF: /etc/koha/sites/instance/koha-conf.xml The problem is in Auth_with_ldap.pm, specifically: if ( exists $ldap->{ldapserver} ) { $ldap = $ldap->{ldapserver} or die ldapserver_error('id="ldapserver"'); } The code is assuming the id is "ldapserver". Better behavior would be to evaluate $ldap and find what the id is set to. It should be the only key in $ldap, and then do: $ldap=$ldap->{$ldapserveridname} The easy fix is just to set the id to ldapserver, but again, that isn't documented anywhere. I can probably provide a patch in in the next few days. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 6

[Bug 20460] New: Staff can only change password through the change password button if patron hits failedloginattempts
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '21

23 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20460 Bug ID: 20460 Summary: Staff can only change password through the change password button if patron hits failedloginattempts Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: jzairo(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org If you use the system preference FailedLoginAttempts and a patron becomes blocked after reaching x failed login attempts, the user is prompted to reset their password. The system preference for OPACresetpassword must be turned on to allow patron to reset their password. If a patron experiences an issue resetting their password and needs staff intervention, it would be helpful to make staff aware that the account has been locked due to too many failed attempts on the patron’s detail page. Staff can click the change password button on circulation.pl or moremember.pl to reset the password. However, if staff click the edit button on circulation.pl or moremember.pl to reset the password, it does not change the password for the patron. It would be helpful to prompt staff to use the Change Password link in the staff UI and/or have the ability to update the password from the edit menu. -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 28589] New: Move C4 and Koha to lib
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '21

23 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 Bug ID: 28589 Summary: Move C4 and Koha to lib Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: In Discussion Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 28519 Git handles that perfectly in both ways: * a patch has been created with a file in /Koha, and is applied later when it's moved to /lib/Koha * a file is modified in /lib/Koha and backported into branches which have the file in /Koha Are we ready for this move? Is it something we really want? Who is willing to spend time on working on this (testing mostly)? We can push it in the next month if there are volunteers. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 [Bug 28519] Add a 2nd directory for Perl modules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 12

[Bug 28619] New: Move misc/translator/ modules to lib/C4/Translate (?)
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '21

23 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28619 Bug ID: 28619 Summary: Move misc/translator/ modules to lib/C4/Translate (?) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 28589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 [Bug 28589] Move C4 and Koha to lib -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 3142] Standardize how OPAC and staff determine requestability
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '21

23 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #14 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to David Cook from comment #9) > Comment on attachment 122284 [details] [review] > Bug 3142: Add itemlost, withdrawn and onloan > > Review of attachment 122284 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/Items.pm > @@ +53,5 @@ > > + itemlost => 0, > > + withdrawn => 0, > > + notforloan => { '<=' => 0 } > > + , # items with negative or zero notforloan value are holdable > > + onloan => undef, > > Why is onloan undef here? I removed it and kept it in Koha::Items->filter_by_for_hold -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0