July 2021 - Koha-bugs - lists.koha-community.org

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '21

09 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119506|0 |1 is obsolete| | --- Comment #144 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 122716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122716&action=e… Bug 11175: (follow-up) Add tests Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Pasi Kallinen <pasi.kallinen(a)koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '21

09 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116828|0 |1 is obsolete| | --- Comment #143 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 122715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122715&action=e… Bug 11175: Remove outdated info about Elasticsearch not being suppported Support for Elasticsearch was added in commit "Bug 11175: Add Elasticsearch support". Signed-off-by: Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '21

09 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116827|0 |1 is obsolete| | --- Comment #142 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 122714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122714&action=e… Bug 11175: Search using double quotes to support Elasticsearch With Elasticsearch if you would use the search string here without the change to double quotes, i.e. (rcn='1234' AND cni='FI-XXX') OR rcn='FI-XXX 1234' then the search would somehow manage to return a record with 001 = 1234 and 003 = FI-XXX. Using double quotes prevents that. Also using parenthesis around the latter part of the OR seems to work: (rcn='1234' AND cni='FI-XXX') OR (rcn='FI-XXX 1234') Signed-off-by: Pasi Kallinen <pasi.kallinen(a)koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '21

09 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116826|0 |1 is obsolete| | --- Comment #141 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 122713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122713&action=e… Bug 11175: Limit the amount of component parts returned There was already before this a limit of 100 results when using Elasticsearch but then the list of component parts was truncated silently. This change now limits the amount to hard coded limit of 300 which is still fast to render. Also when the 300 component part record limit is reached there is a link in the list now to list all the records via the cataloging search. To test: 1) Create 300+ component part records and see if the link to list all the component part records shows up 2) Make sure prove t/Koha/Util/Search.t passes Signed-off-by: Pasi Kallinen <pasi.kallinen(a)koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '21

09 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116825|0 |1 is obsolete| | --- Comment #140 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 122712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122712&action=e… Bug 11175: Keep component part record list items inside the box Without this the number denoting the component part item in the list will overflow and is partly hidden. To test: 1) Create 100 component parts 2) Notice without this patch the number next to the component part is not fully shown Signed-off-by: Pasi Kallinen <pasi.kallinen(a)koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '21

09 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116824|0 |1 is obsolete| | --- Comment #139 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 122711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122711&action=e… Bug 11175: Add Elasticsearch support Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Pasi Kallinen <pasi.kallinen(a)koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '21

09 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116823|0 |1 is obsolete| | --- Comment #138 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 122710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122710&action=e… Bug 11175: (follow-up) Relocate and reword ShowComponentRecords syspref description The syspref is not only affecting staff interface so moving it to Cataloguing section. Added also notes about UNIMARC and Elasticsearch not being supported. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Pasi Kallinen <pasi.kallinen(a)koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '21

09 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116821|0 |1 is obsolete| | --- Comment #137 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 122709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122709&action=e… Bug 11175: (follow-up) Return empty array if no components Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Pasi Kallinen <pasi.kallinen(a)koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '21

09 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116820|0 |1 is obsolete| | --- Comment #136 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 122708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122708&action=e… Bug 11175: (follow-up) Don't return explicitly undef This would create in list context an list of one element that is undef, which we don't want, we want empty list if there are no components. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Pasi Kallinen <pasi.kallinen(a)koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '21

09 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116819|0 |1 is obsolete| | --- Comment #135 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 122707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122707&action=e… Bug 11175: Show record component parts in the detail view Shows the component records of a host, on the hosts detail view in staff client or OPAC, with clickable links to the component records. The host does not require linking entries to the components, but components do require a link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. Adds 'Yet Another System Preference', ShowComponentRecords, which can be used to turn this feature on or off in staff client and/or OPAC, and defaults to off. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001' or, if the 003 is not defined in the Host, 773$w=Host001. Does not use easyanalytics or useControlNumber. Only for MARC21 biblios - UNIMARC has not been updated. staff-global.css and opac.css have not been recreated, so you need to use sass to recreate those from staff-global.scss and opac.scss Test plan: 0) Apply patch 1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML (This file is an attachment on the bug) 2) rebuild the zebra biblio index 3) Search for "easy piano" in staff client, and go to the biblio detail page. You should not see anything different in the record detail page. 4) Do the same on OPAC. 5) Change the ShowComponentRecords syspref appropriately and check the record detail page in staff client and OPAC. You should see a list of component part records. Rebased-by: Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Pasi Kallinen <pasi.kallinen(a)koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0