July 2021 - Koha-bugs - lists.koha-community.org

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '21

09 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116819|0 |1 is obsolete| | --- Comment #135 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 122707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122707&action=e… Bug 11175: Show record component parts in the detail view Shows the component records of a host, on the hosts detail view in staff client or OPAC, with clickable links to the component records. The host does not require linking entries to the components, but components do require a link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. Adds 'Yet Another System Preference', ShowComponentRecords, which can be used to turn this feature on or off in staff client and/or OPAC, and defaults to off. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001' or, if the 003 is not defined in the Host, 773$w=Host001. Does not use easyanalytics or useControlNumber. Only for MARC21 biblios - UNIMARC has not been updated. staff-global.css and opac.css have not been recreated, so you need to use sass to recreate those from staff-global.scss and opac.scss Test plan: 0) Apply patch 1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML (This file is an attachment on the bug) 2) rebuild the zebra biblio index 3) Search for "easy piano" in staff client, and go to the biblio detail page. You should not see anything different in the record detail page. 4) Do the same on OPAC. 5) Change the ShowComponentRecords syspref appropriately and check the record detail page in staff client and OPAC. You should see a list of component part records. Rebased-by: Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Pasi Kallinen <pasi.kallinen(a)koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14083] Make it possible to record the date the order was placed/sent to the vendor
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '21

09 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 --- Comment #5 from Daphne Hoolahan <dch(a)interleaf.ie> --- I agree that it makes sense to link updating the closed date to closing the basket, but we cannot reliably use this date as the date the order was placed with the vendor. If you re-open the basket to make any modifications you lose the date that the order was placed with the vendor. If we had a second date column for 'Date order placed with vendor' we could update both this new column and the orders.closedate when the basket was first closed, but any further opening and closing of the basket would only update orders.closedate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14083] Make it possible to record the date the order was placed/sent to the vendor
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '21

09 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 Daphne Hoolahan <dch(a)interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dch(a)interleaf.ie -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '21

09 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #111 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- [10:16] <Joubu> but we have misc/devel/add_missing_filters.pl! Might be helpful? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '21

09 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '21

09 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #110 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Lots of warnings, especially on filters. But some interesting other ones too ;) Processing files before patches |========================>| 20 / 20 (100.00%) Processing files after patches File not found : lib/jquery/mobile/jquery.mobile.min.css at /usr/share/koha/Koha/Template/Plugin/Asset.pm line 107. File not found : lib/jquery/mobile/jquery.mobile.min.js at /usr/share/koha/Koha/Template/Plugin/Asset.pm line 84. |========================>| 20 / 20 (100.00%) OK Koha/Schema/Result/SavedSql.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling OK valid FAIL Koha/Schema/Result/Sign.pm OK critic OK file permissions OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 SKIP spelling OK valid FAIL Koha/Schema/Result/SignStream.pm OK critic OK file permissions OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 SKIP spelling OK valid FAIL Koha/Schema/Result/SignsToStream.pm OK critic OK file permissions OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 SKIP spelling OK valid FAIL Koha/Sign.pm OK critic OK file permissions FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 18) OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 SKIP spelling OK valid FAIL Koha/SignStream.pm OK critic OK file permissions FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 18) OK git manipulation OK pod OK pod coverage SKIP spelling OK valid FAIL Koha/SignStreams.pm OK critic OK file permissions FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 18) OK git manipulation OK pod OK pod coverage SKIP spelling OK valid FAIL Koha/Signs.pm OK critic OK file permissions FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 18) OK git manipulation OK pod OK pod coverage SKIP spelling OK valid FAIL Koha/SignsToStream.pm OK critic OK file permissions FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 18) OK git manipulation OK pod OK pod coverage SKIP spelling OK valid FAIL Koha/SignsToStreams.pm OK critic OK file permissions FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 18) OK git manipulation OK pod OK pod coverage SKIP spelling OK valid FAIL installer/data/mysql/kohastructure.sql FAIL boolean_vs_tinyint WARNING - The new column (webapp) for table signs is using INT(1) as type, must be TINYINT(1) if it has a boolean purpose, see the SQL12 coding guideline OK charset_collate OK git manipulation OK tinyint_has_boolean_flag OK installer/data/mysql/mandatory/sysprefs.sql OK git manipulation OK semicolon OK sysprefs_order OK koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc OK filters OK forbidden patterns OK git manipulation OK js_in_body SKIP spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc OK filters OK forbidden patterns OK git manipulation OK js_in_body SKIP spelling OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt FAIL filters missing_filter at line 18 ( [% INCLUDE dslink %] Edit "[% stream.name %]") missing_filter at line 24 ( [% INCLUDE dslink %] Edit "[% sign.name %]") missing_filter at line 29 ( [% INCLUDE dslink %] Edit streams attached to "[% sign.name %]") wrong_html_filter at line 32 ( <a href="/cgi-bin/koha/tools/signs.pl?op=edit_streams&sign_id=[% sign.sign_id %]">Edit streams attached to "[% sign.name %]"</a> &rsaquo;) missing_filter at line 32 ( <a href="/cgi-bin/koha/tools/signs.pl?op=edit_streams&sign_id=[% sign.sign_id %]">Edit streams attached to "[% sign.name %]"</a> &rsaquo;) missing_filter at line 32 ( <a href="/cgi-bin/koha/tools/signs.pl?op=edit_streams&sign_id=[% sign.sign_id %]">Edit streams attached to "[% sign.name %]"</a> &rsaquo;) missing_filter at line 35 ( [% INCLUDE dslink %] Delete stream "[% stream.name %]") missing_filter at line 39 ( [% INCLUDE dslink %] Delete sign "[% sign.name %]") missing_filter at line 82 ( <form action="[% script_name %]" name="streamform" id="streamform" method="post">) missing_filter at line 85 ( <input type="hidden" name="sign_stream_id" value="[% stream.sign_stream_id %]" />) missing_filter at line 91 ( <input type="text" name="name" value="[% stream.name %]" required="required">) missing_filter at line 101 ( <option value="[% report.id %]" selected="selected">[% report.report_name %]</option>) missing_filter at line 101 ( <option value="[% report.id %]" selected="selected">[% report.report_name %]</option>) missing_filter at line 103 ( <option value="[% report.id %]">[% report.report_name %]</option>) missing_filter at line 103 ( <option value="[% report.id %]">[% report.report_name %]</option>) missing_filter at line 121 ( <form action="[% script_name %]" name="signform" id="signform" method="post">) missing_filter at line 124 ( <input type="hidden" name="sign_id" value="[% sign.sign_id %]" />) missing_filter at line 129 ( <li><label for="name">Name</label><input type="text" name="name" value="[% sign.name %]" /></li>) missing_filter at line 150 ( <option value="[% swatch %]" selected="selected">[% swatch %]</option>) missing_filter at line 150 ( <option value="[% swatch %]" selected="selected">[% swatch %]</option>) missing_filter at line 152 ( <option value="[% swatch %]">[% swatch %]</option>) missing_filter at line 152 ( <option value="[% swatch %]">[% swatch %]</option>) missing_filter at line 161 ( <option value="[% transition %]" selected="selected">[% transition %]</option>) missing_filter at line 161 ( <option value="[% transition %]" selected="selected">[% transition %]</option>) missing_filter at line 163 ( <option value="[% transition %]">[% transition %]</option>) missing_filter at line 163 ( <option value="[% transition %]">[% transition %]</option>) missing_filter at line 174 ( <input type="text" name="idleafter" id="idleafter" value="[% sign.idleafter %]" size="4" /> seconds. (Set to 0 to disable automatic page turning.)) missing_filter at line 177 ( <input type="text" name="pagedelay" id="pagedelay" value="[% sign.pagedelay %]" size="4" /> seconds.) missing_filter at line 180 ( <input type="text" name="reloadafter" id="reloadafter" value="[% sign.reloadafter %]" size="4" /> seconds.) missing_filter at line 188 ( <h1>Edit streams attached to [% sign.name %]</h1>) missing_filter at line 202 ( <td>[% s.sign_stream.name %]</td>) missing_filter at line 203 ( <td>[% IF s.params %][% s.params %][% ELSE %]None[% END %]</td>) wrong_html_filter at line 206 ( <a href="/cgi-bin/koha/tools/signs.pl?op=get_params&sign_to_stream_id=[% s.sign_to_stream_id %]&sign_stream_id=[% s.sign_stream_id %]&sign_id=[% s.sign_id %]" class="btn btn-default btn-xs" title="Edit parameters"><i class="fa fa-pencil"></i></a>) wrong_html_filter at line 206 ( <a href="/cgi-bin/koha/tools/signs.pl?op=get_params&sign_to_stream_id=[% s.sign_to_stream_id %]&sign_stream_id=[% s.sign_stream_id %]&sign_id=[% s.sign_id %]" class="btn btn-default btn-xs" title="Edit parameters"><i class="fa fa-pencil"></i></a>) wrong_html_filter at line 206 ( <a href="/cgi-bin/koha/tools/signs.pl?op=get_params&sign_to_stream_id=[% s.sign_to_stream_id %]&sign_stream_id=[% s.sign_stream_id %]&sign_id=[% s.sign_id %]" class="btn btn-default btn-xs" title="Edit parameters"><i class="fa fa-pencil"></i></a>) missing_filter at line 206 ( <a href="/cgi-bin/koha/tools/signs.pl?op=get_params&sign_to_stream_id=[% s.sign_to_stream_id %]&sign_stream_id=[% s.sign_stream_id %]&sign_id=[% s.sign_id %]" class="btn btn-default btn-xs" title="Edit parameters"><i class="fa fa-pencil"></i></a>) missing_filter at line 206 ( <a href="/cgi-bin/koha/tools/signs.pl?op=get_params&sign_to_stream_id=[% s.sign_to_stream_id %]&sign_stream_id=[% s.sign_stream_id %]&sign_id=[% s.sign_id %]" class="btn btn-default btn-xs" title="Edit parameters"><i class="fa fa-pencil"></i></a>) missing_filter at line 206 ( <a href="/cgi-bin/koha/tools/signs.pl?op=get_params&sign_to_stream_id=[% s.sign_to_stream_id %]&sign_stream_id=[% s.sign_stream_id %]&sign_id=[% s.sign_id %]" class="btn btn-default btn-xs" title="Edit parameters"><i class="fa fa-pencil"></i></a>) wrong_html_filter at line 208 ( <a href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% s.sign_stream.saved_sql_id %]&phase=Edit SQL" class="btn btn-default btn-xs" title="Edit SQL"><i class="fa fa-pencil"></i></a>) missing_filter at line 208 ( <a href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% s.sign_stream.saved_sql_id %]&phase=Edit SQL" class="btn btn-default btn-xs" title="Edit SQL"><i class="fa fa-pencil"></i></a>) wrong_html_filter at line 211 ( <td class="actions"><a href="/cgi-bin/koha/tools/signs.pl?op=detach_stream_from_sign&sign_id=[% s.sign_id %]&sign_to_stream_id=[% s.sign_to_stream_id %]" class="btn btn-default btn-xs detach"><i class="fa fa-times"></i> Detach</a></td>) wrong_html_filter at line 211 ( <td class="actions"><a href="/cgi-bin/koha/tools/signs.pl?op=detach_stream_from_sign&sign_id=[% s.sign_id %]&sign_to_stream_id=[% s.sign_to_stream_id %]" class="btn btn-default btn-xs detach"><i class="fa fa-times"></i> Detach</a></td>) missing_filter at line 211 ( <td class="actions"><a href="/cgi-bin/koha/tools/signs.pl?op=detach_stream_from_sign&sign_id=[% s.sign_id %]&sign_to_stream_id=[% s.sign_to_stream_id %]" class="btn btn-default btn-xs detach"><i class="fa fa-times"></i> Detach</a></td>) missing_filter at line 211 ( <td class="actions"><a href="/cgi-bin/koha/tools/signs.pl?op=detach_stream_from_sign&sign_id=[% s.sign_id %]&sign_to_stream_id=[% s.sign_to_stream_id %]" class="btn btn-default btn-xs detach"><i class="fa fa-times"></i> Detach</a></td>) missing_filter at line 221 ( <form action="[% script_name %]" name="attach_stream_to_sign_form" id="attach_stream_to_sign_form" method="post">) missing_filter at line 223 ( <input type="hidden" name="sign_id" value="[% sign_id %]" />) missing_filter at line 229 ( <option value="[% s.sign_stream_id %]">[% s.name %]</option>) missing_filter at line 229 ( <option value="[% s.sign_stream_id %]">[% s.name %]</option>) missing_filter at line 239 ( <h1>Parameters for [% stream.name %]</h1>) wrong_html_filter at line 240 ( Based on report: [% sql.report_name %] | <a href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% stream.saved_sql_id %]&phase=Edit SQL">Edit this report</a>) missing_filter at line 240 ( Based on report: [% sql.report_name %] | <a href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% stream.saved_sql_id %]&phase=Edit SQL">Edit this report</a>) missing_filter at line 240 ( Based on report: [% sql.report_name %] | <a href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% stream.saved_sql_id %]&phase=Edit SQL">Edit this report</a>) missing_filter at line 242 ( <form action="[% script_name %]" name="get_params_form" id="get_params_form" method="post">) missing_filter at line 244 ( <input type="hidden" name="sign_to_stream_id" value="[% sign_to_stream_id %]" />) missing_filter at line 245 ( <input type="hidden" name="sign_stream_id" value="[% sign_stream_id %]" />) missing_filter at line 246 ( <input type="hidden" name="sign_id" value="[% sign_id %]" />) missing_filter at line 255 ( <input type="text" size="60" name="parameters" id="parameters" value="[% sts.params %]" />) missing_filter at line 277 ( <h3>Confirm deletion of stream <span class="ex">'[% stream.name %]'</span>?</h3>) missing_filter at line 278 ( <form action="[% script_name %]" id ="confirm_stream_delete_form" method="post">) missing_filter at line 280 ( <input type="hidden" name="sign_stream_id" value="[% stream.sign_stream_id %]" />) missing_filter at line 284 ( <form action="[% script_name %]" id="cancel_stream_delete_form" method="get">) missing_filter at line 292 ( <form action="[% script_name %]" method="get">) missing_filter at line 299 ( <h3>Confirm deletion of sign <span class="ex">'[% sign.name %]'</span>?</h3>) missing_filter at line 300 ( <form action="[% script_name %]" id ="confirm_sign_delete_form" method="post">) missing_filter at line 302 ( <input type="hidden" name="sign_id" value="[% sign.sign_id %]" />) missing_filter at line 306 ( <form action="[% script_name %]" id="cancel_sign_delete_form" method="get">) missing_filter at line 314 ( <form action="[% script_name %]" method="get">) missing_filter at line 320 ( <h1>[% sign.name %]</h1>) missing_filter at line 325 ( <h3>[% stream.sign_stream.name %]</h3>) wrong_html_filter at line 328 ( <li><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% record.biblionumber %]">[% record.title %]</a></li>) missing_filter at line 328 ( <li><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% record.biblionumber %]">[% record.title %]</a></li>) missing_filter at line 328 ( <li><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% record.biblionumber %]">[% record.title %]</a></li>) missing_filter at line 337 ( <h1>[% stream.name %]</h1>) wrong_html_filter at line 338 ( Based on report: [% stream.saved_sql_id.report_name %] | <a href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% stream.saved_sql_id %]&phase=Edit SQL">Edit this report</a>) missing_filter at line 338 ( Based on report: [% stream.saved_sql_id.report_name %] | <a href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% stream.saved_sql_id %]&phase=Edit SQL">Edit this report</a>) missing_filter at line 338 ( Based on report: [% stream.saved_sql_id.report_name %] | <a href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% stream.saved_sql_id %]&phase=Edit SQL">Edit this report</a>) wrong_html_filter at line 377 ( <td><a href="/cgi-bin/koha/tools/signs.pl?op=view_sign&sign_id=[% s.sign_id %]">[% s.name %]</a></td>) missing_filter at line 377 ( <td><a href="/cgi-bin/koha/tools/signs.pl?op=view_sign&sign_id=[% s.sign_id %]">[% s.name %]</a></td>) missing_filter at line 377 ( <td><a href="/cgi-bin/koha/tools/signs.pl?op=view_sign&sign_id=[% s.sign_id %]">[% s.name %]</a></td>) missing_filter at line 379 ( <td>[% s.swatch %]</td>) missing_filter at line 380 ( <td>[% s.transition %]</td>) missing_filter at line 381 ( <td>[% s.idleafter %]</td>) missing_filter at line 382 ( <td>[% s.pagedelay %]</td>) missing_filter at line 383 ( <td>[% s.reloadafter %]</td>) missing_filter at line 386 ( <a class="btn btn-default btn-xs dropdown-toggle" id="opensignsactions[% s.sign_id %]" role="button" data-toggle="dropdown" href="#"> Actions <b class="caret"></b></a>) missing_filter at line 387 ( <ul class="dropdown-menu pull-right" role="menu" aria-labelledby="opensignsactions[% s.sign_id %]">) wrong_html_filter at line 388 ( <li><a href="/cgi-bin/koha/tools/signs.pl?op=edit_sign&sign_id=[% s.sign_id %]"><i class="fa fa-pencil"></i> Edit</a></li>) missing_filter at line 388 ( <li><a href="/cgi-bin/koha/tools/signs.pl?op=edit_sign&sign_id=[% s.sign_id %]"><i class="fa fa-pencil"></i> Edit</a></li>) wrong_html_filter at line 389 ( <li><a href="/cgi-bin/koha/tools/signs.pl?op=edit_streams&sign_id=[% s.sign_id %]"><i class="fa fa-pencil"></i> Edit streams</a></li>) missing_filter at line 389 ( <li><a href="/cgi-bin/koha/tools/signs.pl?op=edit_streams&sign_id=[% s.sign_id %]"><i class="fa fa-pencil"></i> Edit streams</a></li>) wrong_html_filter at line 390 ( <li><a href="/cgi-bin/koha/tools/signs.pl?op=del_sign&sign_id=[% s.sign_id %]"><i class="fa fa-trash"></i> Delete</a></li>) missing_filter at line 390 ( <li><a href="/cgi-bin/koha/tools/signs.pl?op=del_sign&sign_id=[% s.sign_id %]"><i class="fa fa-trash"></i> Delete</a></li>) wrong_html_filter at line 391 ( [% IF ( OPACBaseURL ) %]<li><a href="[% OPACBaseURL %]/cgi-bin/koha/opac-signs.pl?sign=[% s.sign_id %]" title="View this sign in the OPAC"><i class="fa fa-eye"></i> View sign</a></li>[% END %]) wrong_html_filter at line 391 ( [% IF ( OPACBaseURL ) %]<li><a href="[% OPACBaseURL %]/cgi-bin/koha/opac-signs.pl?sign=[% s.sign_id %]" title="View this sign in the OPAC"><i class="fa fa-eye"></i> View sign</a></li>[% END %]) missing_filter at line 391 ( [% IF ( OPACBaseURL ) %]<li><a href="[% OPACBaseURL %]/cgi-bin/koha/opac-signs.pl?sign=[% s.sign_id %]" title="View this sign in the OPAC"><i class="fa fa-eye"></i> View sign</a></li>[% END %]) missing_filter at line 391 ( [% IF ( OPACBaseURL ) %]<li><a href="[% OPACBaseURL %]/cgi-bin/koha/opac-signs.pl?sign=[% s.sign_id %]" title="View this sign in the OPAC"><i class="fa fa-eye"></i> View sign</a></li>[% END %]) wrong_html_filter at line 417 ( <td><a href="/cgi-bin/koha/tools/signs.pl?op=view_stream&sign_stream_id=[% s.sign_stream_id %]">[% s.name %]</a></td>) missing_filter at line 417 ( <td><a href="/cgi-bin/koha/tools/signs.pl?op=view_stream&sign_stream_id=[% s.sign_stream_id %]">[% s.name %]</a></td>) missing_filter at line 417 ( <td><a href="/cgi-bin/koha/tools/signs.pl?op=view_stream&sign_stream_id=[% s.sign_stream_id %]">[% s.name %]</a></td>) missing_filter at line 418 ( <td title="ID: [% s.saved_sql_id %]">[% s.saved_sql.report_name %]</td>) missing_filter at line 418 ( <td title="ID: [% s.saved_sql_id %]">[% s.saved_sql.report_name %]</td>) missing_filter at line 420 ( <a class="btn btn-default btn-xs" href="/cgi-bin/koha/tools/signs.pl?op=edit_stream&sign_stream_id=[% s.sign_stream_id %]"><i class="fa fa-pencil"></i> Edit</a>) missing_filter at line 421 ( <a class="btn btn-default btn-xs" href="/cgi-bin/koha/tools/signs.pl?op=del_stream&sign_stream_id=[% s.sign_stream_id %]"><i class="fa fa-trash"></i> Delete</a>) missing_filter at line 483 ( <tr><td>[% r.biblionumber %]</td><td>[% r.title %]</td></tr>) missing_filter at line 483 ( <tr><td>[% r.biblionumber %]</td><td>[% r.title %]</td></tr>) FAIL forbidden patterns forbidden pattern: Title elements must start with the unique information (bug 26703) (line 5) OK git manipulation OK js_in_body SKIP spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt OK filters OK forbidden patterns OK git manipulation OK js_in_body SKIP spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/js/tools-menu.js OK ES template literals OK git manipulation FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-signs.tt FAIL filters missing_filter at line 23 ( [%-%]In transit from [%- item.transfertfrom %] to [%- item.transfertto %] since [%- item.transfertwhen | $KohaDates %]) missing_filter at line 23 ( [%-%]In transit from [%- item.transfertfrom %] to [%- item.transfertto %] since [%- item.transfertwhen | $KohaDates %]) missing_filter at line 36 ( [%- item.notforloanvalueopac -%] [%- IF ( item.restrictedopac ) -%] ([%- item.restrictedopac -%])[%- END -%]) missing_filter at line 36 ( [%- item.notforloanvalueopac -%] [%- IF ( item.restrictedopac ) -%] ([%- item.restrictedopac -%])[%- END -%]) missing_filter at line 38 ( [%-%]Not for loan [%- IF ( item.restrictedopac ) -%] ([%- item.restrictedopac -%])[%- END -%]) missing_filter at line 42 ( [%-%]Not for loan [%- IF ( item.restrictedopac ) -%] ([%- item.restrictedopac -%])[%- END -%]) missing_filter at line 53 ( [%-%]Available [%- IF ( item.restrictedopac ) -%] ([%- item.restrictedopac -%])[%- END -%]) missing_filter at line 58 (<title>[% IF ( sign ) %][% sign.name %] - Koha[% ELSE %]Koha digital signs[% END %]</title>) missing_filter at line 66 ( [% Koha.Preference( 'OPACDigitalSignsCSS' ) %]) asset_must_be_raw at line 68 ( [% Asset.css("lib/jquery/mobile/jquery.mobile.structure.min.css") %]) asset_must_be_raw at line 70 ( [% Asset.css("css/signs.css") %]) asset_must_be_raw at line 71 ( [% Asset.css("lib/jquery/mobile/jquery.mobile.min.css") %]) missing_filter at line 86 ( <div data-role="page" class="page-stream" data-stream-id="[% s.sign_stream_id %]" data-theme="[% sign.swatch %]" id="stream_[% s.sign_stream_id %]">) missing_filter at line 86 ( <div data-role="page" class="page-stream" data-stream-id="[% s.sign_stream_id %]" data-theme="[% sign.swatch %]" id="stream_[% s.sign_stream_id %]">) missing_filter at line 86 ( <div data-role="page" class="page-stream" data-stream-id="[% s.sign_stream_id %]" data-theme="[% sign.swatch %]" id="stream_[% s.sign_stream_id %]">) missing_filter at line 87 ( <div data-role="header" data-theme="[% sign.swatch %]" data-position="fixed">) wrong_html_filter at line 93 ( <a href="#stream_[% stream.sign_stream_id %]" data-stream-id="[% stream.sign_stream_id %]" class="btn-stream stream-active" data-inline="true" data-icon="star" data-role="button">[% stream.name %]</a>) missing_filter at line 93 ( <a href="#stream_[% stream.sign_stream_id %]" data-stream-id="[% stream.sign_stream_id %]" class="btn-stream stream-active" data-inline="true" data-icon="star" data-role="button">[% stream.name %]</a>) missing_filter at line 93 ( <a href="#stream_[% stream.sign_stream_id %]" data-stream-id="[% stream.sign_stream_id %]" class="btn-stream stream-active" data-inline="true" data-icon="star" data-role="button">[% stream.name %]</a>) missing_filter at line 93 ( <a href="#stream_[% stream.sign_stream_id %]" data-stream-id="[% stream.sign_stream_id %]" class="btn-stream stream-active" data-inline="true" data-icon="star" data-role="button">[% stream.name %]</a>) wrong_html_filter at line 95 ( <a href="#stream_[% stream.sign_stream_id %]" data-stream-id="[% stream.sign_stream_id %]" class="btn-stream" data-inline="true" data-role="button">[% stream.name %]</a>) missing_filter at line 95 ( <a href="#stream_[% stream.sign_stream_id %]" data-stream-id="[% stream.sign_stream_id %]" class="btn-stream" data-inline="true" data-role="button">[% stream.name %]</a>) missing_filter at line 95 ( <a href="#stream_[% stream.sign_stream_id %]" data-stream-id="[% stream.sign_stream_id %]" class="btn-stream" data-inline="true" data-role="button">[% stream.name %]</a>) missing_filter at line 95 ( <a href="#stream_[% stream.sign_stream_id %]" data-stream-id="[% stream.sign_stream_id %]" class="btn-stream" data-inline="true" data-role="button">[% stream.name %]</a>) missing_filter at line 101 ( <h1>[% s.name %]</h1>) wrong_html_filter at line 121 ( <li><a href="?sign=[% SIGN.sign_id %]" data-ajax="false">[% SIGN.name %]</a></li>) missing_filter at line 121 ( <li><a href="?sign=[% SIGN.sign_id %]" data-ajax="false">[% SIGN.name %]</a></li>) missing_filter at line 121 ( <li><a href="?sign=[% SIGN.sign_id %]" data-ajax="false">[% SIGN.name %]</a></li>) missing_filter at line 157 ( if (idleTime >= [% sign.idleafter %]) {) missing_filter at line 163 ( if (doIdle && idleTimePage >= [% sign.pagedelay %]) {) missing_filter at line 170 ( if (doIdle && idleTime >= [% sign.reloadafter %]) {) missing_filter at line 370 ( self.$cover.addClass('ui-bar-[% sign.swatch %]');) missing_filter at line 374 ( self.$vcontainer.addClass('ui-bar-[% sign.swatch %]');) missing_filter at line 378 ( self.$cover.css('border-color', $('.ui-bar-[% sign.swatch %]').first().css('background-color'));) missing_filter at line 397 ( var $page = $('<div data-role="page" data-close-btn="none" data-theme="[% sign.swatch %]" id="record_'+sid+'_'+cover.record.biblionumber+'"/>');) missing_filter at line 398 ( var $head = $('<div data-role="header" data-theme="[% sign.swatch %]"/>');) missing_filter at line 463 ( $li.append($('<img src="/[% interface %]/lib/famfamfam/'+item.type+'.png" class="ui-li-icon"/>'));) missing_filter at line 479 ( $foot.append($('<a href="#stream_'+sid+'" data-role="button" data-theme="[% sign.swatch %]" data-transition="[% sign.transition %]">'+_("Back")+'</a>'));) missing_filter at line 479 ( $foot.append($('<a href="#stream_'+sid+'" data-role="button" data-theme="[% sign.swatch %]" data-transition="[% sign.transition %]">'+_("Back")+'</a>'));) missing_filter at line 497 ( '[% stream.sign_stream_id %]': {) missing_filter at line 498 ( 'name': [% stream.name.json || '""' %],) missing_filter at line 501 ( {'author': [% record.author.json || '""' %],) missing_filter at line 502 ( 'title': [% record.title.json || '""' %],) missing_filter at line 503 ( 'publisher': [% record.publishercode.json || '""' %],) missing_filter at line 504 ( 'biblionumber': [% record.biblionumber.json || '""' %],) missing_filter at line 505 ( 'isbn': [% record.isbn.json || '""' %],) missing_filter at line 509 ( 'type': [% item.itemtype.json || '""' %],) missing_filter at line 511 ( 'location': [% item.location.json || '""' %],) missing_filter at line 512 ( 'location_description': [% item.location_description.json || '""' %],) missing_filter at line 513 ( 'home_branch': "[% Branches.GetName(item.homebranch) | json %]",) missing_filter at line 537 ( var $link = $('<a href="#record_'+sid+'_'+cover.record.biblionumber+'" class="btn-record" data-transition="[% sign.transition %]"/>')) missing_filter at line 539 ( $content.append($link.append($('<div class="cover placeholder ui-bar-[% sign.swatch %] cover_'+cover.id+'" data-id="'+cover.id+'"/>')));) asset_must_be_raw at line 561 ( [% Asset.js("lib/jquery/mobile/jquery.mobile.min.js") %]) FAIL forbidden patterns forbidden pattern: Attribute type should not be used for style tags (bug 20054) (line 65) forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 132) OK git manipulation OK js_in_body SKIP spelling OK tt_valid OK valid_template FAIL opac/opac-signs.pl OK critic OK file permissions FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 18) OK git manipulation OK pod SKIP spelling OK valid FAIL tools/signs.pl FAIL critic Subroutine "new" called using indirect syntax at line 48, column 11. See page 349 of PBP. OK file permissions FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 18) forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error (bug 24663) (line 56) OK git manipulation OK pod SKIP spelling OK valid -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '21

09 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #109 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- I would recommend running qa tools yourself too :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '21

09 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl QA Contact| |m.de.rooy(a)rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15969] New: Allow use of Template Toolkit syntax for Phone Notices
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '21

09 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Bug ID: 15969 Summary: Allow use of Template Toolkit syntax for Phone Notices Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org By allowing the use of Template Toolkit for generating the outgoing Talking Tech CSV files, we can give libaries more control over the data they send to Itiva. This enhancement would also make it possible to use the script for other services since the output is no longer fixed to a single format. -- You are receiving this mail because: You are watching all bug changes.

1 75

[Bug 27942] QOTD: quote CSV uploads may contain JavaScript payloads (XSS)
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '21

09 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27942 --- Comment #22 from Victor Grousset/tuxayo <victor(a)tuxayo.net> --- Hi :) Manual quote addition is broken with patch «[20.11] Prevent XSS vulnerabilities in quote-upload» See bug 28675 , any ideas/analysis/help welcome :) -- You are receiving this mail because: You are watching all bug changes.

1 0