July 2021 - Koha-bugs - lists.koha-community.org

[Bug 12169] Improve reliability of sip_shutdown script
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '21

02 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12169 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #17 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Enhancement not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '21

02 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #30 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Martin Renvoize from comment #25) > I've love to get peoples thoughts on my alternative implimentation.. I've > split out the relevant code I wrote for bug 11983 so we don't have to rely > on that entire bug working it's way through. > > It still needs a couple more tests adding to prove the branchcode/debit_type > refinement. > > I think it's really beneficial to be able to chain this.. I can see a really > clear use case for needing to filter to those patrons visible to the user > prior to using this function...? I love your alternate patch. It is in line with what we've been promoting the last couple years in the codebase. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '21

02 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Eric Bégin <eric.begin(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|hakam.almotlak(a)inLibro.com | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '21

02 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Eric Bégin <eric.begin(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|hakam.almotlak(a)inLibro.com | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '21

02 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #29 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- + my $group_by = + [ map { 'me.' . $_ } $self->_resultset->result_source->columns ]; + + my $attrs = { + join => 'accountlines', + group_by => $group_by, You probably dont want to group by on all patron columns, heh ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '21

02 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #28 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- + return $self + unless ( defined($options) + && ( $options->{less_than} || $options->{more_than} ) ); Would this raise questions if people only pass library or debit_type and get much more than expected ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '21

02 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #27 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Tests added -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '21

02 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122528|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 122534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122534&action=e… Bug 15156: [ALT] Add filter_by_amount_owed that's chainable This patch acts as an alternative here. We pull out the code from bug 11983 and extend it to support filtering of debts by branchcode and debit_type. The advantage of this approach is that we can add the filter into the middle of a search chain to filter down an pre-existing search. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '21

02 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #25 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I've love to get peoples thoughts on my alternative implimentation.. I've split out the relevant code I wrote for bug 11983 so we don't have to rely on that entire bug working it's way through. It still needs a couple more tests adding to prove the branchcode/debit_type refinement. I think it's really beneficial to be able to chain this.. I can see a really clear use case for needing to filter to those patrons visible to the user prior to using this function...? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '21

02 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #24 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 122528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122528&action=e… Bug 15156: [ALT] Add filter_by_amount_owed that's chainable This patch acts as an alternative here. We pull out the code from bug 11983 and extend it to support filtering of debts by branchcode and debit_type. The advantage of this approach is that we can add the filter into the middle of a search chain to filter down an pre-existing search. -- You are receiving this mail because: You are watching all bug changes.

1 0