September 2021 - Koha-bugs - lists.koha-community.org

[Bug 28690] New: Important and mandatory not checked on all item forms
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '21

14 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28690 Bug ID: 28690 Summary: Important and mandatory not checked on all item forms Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl If item subfields has marked as mandatory or important, there is no alert when the item is added from the acquisition or serial modules. acqui/neworderempty.tt: var empty_item_mandatory = CheckMandatorySubfields(ff); acqui/orderreceive.tt: var total_errors = CheckMandatorySubfields(form); serials/serials-edit.tt: total_errors = total_errors + CheckMandatorySubfields(this); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 8

[Bug 28983] New: Use Flatpickr on various pages
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '21

14 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28983 Bug ID: 28983 Summary: Use Flatpickr on various pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 28937, 28376 This bug will cover Flatpickr additions to these pages/files: * circ/offline.tt * clubs/clubs-add-modify.tt * ill/ill-requests.tt * labels/search.tt * pos/register.tt * suggestion/suggestion.tt * tags/review.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 [Bug 28376] Replace obsolete jquery-ui-timepicker-addon https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 [Bug 28937] Use Flatpickr on circulation and patron pages -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 24958] New: Remember last selected tab in SQL reports
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '21

14 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24958 Bug ID: 24958 Summary: Remember last selected tab in SQL reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Reports Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org I think it would be useful for the saved reports page to remember which tab the user last suggested. I propose to set a cookie to store the information. -- You are receiving this mail because: You are watching all bug changes.

1 42

[Bug 27545] New: NewItemsDefaultLocation is only used from additem.pl
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '21

14 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27545 Bug ID: 27545 Summary: NewItemsDefaultLocation is only used from additem.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Depends on: 3481 The syspref NewItemsDefaultLocation is used to set a default value for item's location. But it seems that there are some weirdness in the behaviour: 1. It's only used from additem. It seems that it should be used from acq and serial modules as well. And maybe for the items import too. 2. It set the location even if another one has been picked from the UI => We UI must preselect the syspref's value, but the controller must pick what has been selected on the UI Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3481 [Bug 3481] In Processing/Shelving Cart locations -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 25070] New: Include files to display address and contact must be refactored
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '21

14 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25070 Bug ID: 25070 Summary: Include files to display address and contact must be refactored Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org There are 5 includes files per value of AddressFormat (us, de, fr). The code is duplicated for each language, the only thing that changes is the order. A refactoring is needed to avoid further regressions. -- You are receiving this mail because: You are watching all bug changes.

1 77

[Bug 28942] New: Use Flatpickr on acquisitions pages
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '21

14 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942 Bug ID: 28942 Summary: Use Flatpickr on acquisitions pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 28376 This bug will cover Flatpickr additions to these pages/files: - includes/filter-orders.inc - acqui/invoice.tt - acqui/invoices.tt - acqui/lateorders.tt - acqui/orderreceive.tt - acqui/parcels.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 [Bug 28376] Replace obsolete jquery-ui-timepicker-addon -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 28945] New: Use Flatpickr on administration pages
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '21

14 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945 Bug ID: 28945 Summary: Use Flatpickr on administration pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 28376, 28938, 28942 This bug will cover Flatpickr additions to these pages/files: - admin/aqbudgetperiods.tt - admin/aqcontract.tt - admin/smart-rules.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 [Bug 28376] Replace obsolete jquery-ui-timepicker-addon https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 [Bug 28938] Correct Flatpickr's default 12hr time formatting https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942 [Bug 28942] Use Flatpickr on acquisitions pages -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 28949] New: Use Flatpickr on reports pages
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '21

14 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28949 Bug ID: 28949 Summary: Use Flatpickr on reports pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 28376, 28937 This bug will cover Flatpickr additions to these pages/files: * reports/acquisitions_stats.tt * reports/bor_issues_top.tt * reports/borrowers_out.tt * reports/cash_register_stats.tt * reports/cat_issues_top.tt * reports/catalogue_stats.tt * reports/dictionary.tt * reports/guided_reports_start.tt * reports/issues_avg_stats.tt * reports/issues_stats.tt * reports/reserves_stats.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 [Bug 28376] Replace obsolete jquery-ui-timepicker-addon https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 [Bug 28937] Use Flatpickr on circulation and patron pages -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 28928] New: Minor follow-ups to Bug 28376 - Flatpickr introduction
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '21

14 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928 Bug ID: 28928 Summary: Minor follow-ups to Bug 28376 - Flatpickr introduction Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 28376 I've discovered a few of minor follow-ups required for Bug 28376: - Missing document.ready() in borrowers_stats.tt. - Missing preventDefault() in calendar.inc - Redundant calendarFirstDayOfWeek setting in caregories.js Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 [Bug 28376] Replace obsolete jquery-ui-timepicker-addon -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 28938] New: Correct Flatpickr's default 12hr time formatting
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '21

14 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28938 Bug ID: 28938 Summary: Correct Flatpickr's default 12hr time formatting Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: jonathan.druart+koha(a)gmail.com, testopia(a)bugs.koha-community.org Depends on: 28937 In calendar.inc we define the variable "flatpickr_timeformat_string" using this string: "h:i K" This results in times which don't include a leading zero (https://flatpickr.js.org/formatting/) a format which doesn't seem to be expected by the Perl script. It should be "G" To reproduce: - Set the TimeFormat system preference to "12 hour" - Find an item which is checked out and renewable. - Go to Circulation -> Renew and use the date picker to select a time < 12, e.g. 9:00 AM - Submit the barcode for renewal. - Check the patron's account to see the due date: Instead of being due on your selected date at 9:00AM it will be due on your selected date at 12:00AM. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 [Bug 28937] Use Flatpickr on circulation and patron pages -- You are receiving this mail because: You are watching all bug changes.

1 16