January 2022 - Koha-bugs - lists.koha-community.org

[Bug 23590] New: Allow to modify the manager of a suggestion
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '22

27 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Bug ID: 23590 Summary: Allow to modify the manager of a suggestion Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: severine.queune(a)bulac.fr QA Contact: testopia(a)bugs.koha-community.org When a staff member modifies a suggestion, it is automatically attributed to the logged librarian. It would be very useful to have the option to select another user that will be the one in charge of this suggestion. This other user could also be notified by an email after the suggestion is modified. This feature probably means to create new fields in the ‘suggestions’ table to separate ‘managedby’ / ‘manageddate’ from the ‘lastmodificationby’ / ‘‘lastmodificationdate’ informations, but I think it will ensure a better follow up on the suggestions workflow. The BULAC (http://www.bulac.fr/) would like to sponsor this development. As long as “Change sponsored?” is set on “Seeking developer”, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: <sigb(a)bulac.fr>. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 166

[Bug 10309] New OPAC theme based on Bootstrap
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '22

27 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29960 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 [Bug 29960] Remove Modernizr dependency in the OPAC -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11873] Upgrade jstree jQuery plugin to the latest version
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '22

27 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 --- Comment #13 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Jonathan Druart from comment #12) > Created attachment 129857 [details] [review] > Bug 11873: Remove decoration on current authority > > Previously the current authority was not styled like a link. It was > useful to have a visual feedback knowing which authority is currently > displayed. > > Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> This is a bit ugly (duplication code, and css applied with JS) but didn't find something better. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11873] Upgrade jstree jQuery plugin to the latest version
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '22

27 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 --- Comment #12 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Created attachment 129857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129857&action=e… Bug 11873: Remove decoration on current authority Previously the current authority was not styled like a link. It was useful to have a visual feedback knowing which authority is currently displayed. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11873] Upgrade jstree jQuery plugin to the latest version
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '22

27 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29953] New: Possible inefficiency in REST API for biblios endpoint
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '22

27 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29953 Bug ID: 29953 Summary: Possible inefficiency in REST API for biblios endpoint Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au CC: tomascohen(a)gmail.com I was looking at Koha/REST/V1/Biblios.pm because of bug 28201 when I noticed it looks like we're running $record->$method calls more than we need to in the "get" function. Consider the following block of code: if ( $c->req->headers->accept =~ m/application\/json/ ) { return $c->render( status => 200, json => $biblio->to_api ); } else { my $record = $biblio->metadata->record; $c->respond_to( marcxml => { status => 200, format => 'marcxml', text => $record->as_xml_record }, mij => { status => 200, format => 'mij', text => $record->to_mij }, marc => { status => 200, format => 'marc', text => $record->as_usmarc }, txt => { status => 200, format => 'text/plain', text => $record->as_formatted }, any => { status => 406, openapi => [ "application/json", "application/marcxml+xml", "application/marc-in-json", "application/marc", "text/plain" ] } ); } If there is an Accept header for application/json, then we run $biblio->to_api, and that's it. However, if there isn't an Accept header for application/json, it looks like we create a hash of hashrefs that output the $record in 4 different formats. I think it would make more sense (based on what I see in https://docs.mojolicious.org/Mojolicious/Plugin/DefaultHelpers#respond_to) to provide anonymous functions instead of hashrefs so that $record->$method calls are only run when a specific format is actually chosen by Mojolicious. In terms of performance, it might be only a marginal gain, but if you're doing a lot of API calls, small gains can translate into large scale time savings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 11873] Upgrade jstree jQuery plugin to the latest version
by bugzilla-daemon＠bugs.koha-community.org 26 Jan '22

26 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 --- Comment #11 from Owen Leonard <oleonard(a)myacpl.org> --- Remote branch updated to remove the non-minified version. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11873] Upgrade jstree jQuery plugin to the latest version
by bugzilla-daemon＠bugs.koha-community.org 26 Jan '22

26 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 --- Comment #10 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Owen Leonard from comment #9) > (In reply to Jonathan Druart from comment #8) > > Do we really need to include the non-minified version of jstree? > > It's not strictly necessary as long as the minified version includes version > number information in it. Yes, that's my point. If someone wants to debug it is easy to retrieve the corresponding non-minified version. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11873] Upgrade jstree jQuery plugin to the latest version
by bugzilla-daemon＠bugs.koha-community.org 26 Jan '22

26 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 --- Comment #9 from Owen Leonard <oleonard(a)myacpl.org> --- (In reply to Jonathan Druart from comment #8) > Do we really need to include the non-minified version of jstree? It's not strictly necessary as long as the minified version includes version number information in it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11873] Upgrade jstree jQuery plugin to the latest version
by bugzilla-daemon＠bugs.koha-community.org 26 Jan '22

26 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #8 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Do we really need to include the non-minified version of jstree? -- You are receiving this mail because: You are watching all bug changes.

1 0