October 2022 - Koha-bugs - lists.koha-community.org

[Bug 31290] New: Getting error in batch modification
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31290 Bug ID: 31290 Summary: Getting error in batch modification Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: nayema(a)mes.ac.in QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Created attachment 138598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138598&action=e… /usr/share/koha/bin/background_jobs_worker.pl line 57 I am getting following error while trying to do any batch modification or batch delete in KOHA. "Cannot enqueue this job. (The error was: Job has not been enqueued, see the Koha log file for more information)." I have checked the error log file and found following error: ==> /var/log/koha/library/worker-output.log <== malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "You must log in usin...") at /usr/share/koha/bin/background_jobs_worker.pl line 57. I have attached the screen short of /usr/share/koha/bin/background_jobs_worker.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 7

[Bug 31106] New: Error searching for analytics in detail view
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106 Bug ID: 31106 Summary: Error searching for analytics in detail view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com Bug 30865 fixed part of the problem. We need to implement the fix in bug 29418 for master and 21.11+. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 45

[Bug 31158] New: Can't filter suggestions by suggestion date range
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31158 Bug ID: 31158 Summary: Can't filter suggestions by suggestion date range Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org On the suggestions home page I expanded the "Suggestions information" sidebar filter, then entered dates in the "Suggested date from:" and "To:" fields. When I submit I get an error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'suggesteddate_from' in 'where clause' at /kohadevbox/koha/Koha/Objects.pm line 394 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 30420] New: We don't need Koha::Patron::get_overdues AND ::overdues
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30420 Bug ID: 30420 Summary: We don't need Koha::Patron::get_overdues AND ::overdues Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org We should really replace the get_ accessor with the overdues accessor rather than just providing an alias. We could also put the query at the dbic schema class level as a fully-fledged relationship and get some query construction benefits. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 30384] New: Reindent template for ordering from a MARC file
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30384 Bug ID: 30384 Summary: Reindent template for ordering from a MARC file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org I would like reformat the "Add orders from MARC file" template in the staff interface (addorderiso2709.tt) so that it has consistent spacing and indentation. -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 26114] New: ILL should mark status=RET only if a return happened
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26114 Bug ID: 26114 Summary: ILL should mark status=RET only if a return happened Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com When the C4::Circulation::AddReturn reaches the ILL request update, there are many circumstances under which no return happened, and the ILL code doesn't check that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 24461] New: Add to_api_mapping to Koha::Acquisition::BasketGroup
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461 Bug ID: 24461 Summary: Add to_api_mapping to Koha::Acquisition::BasketGroup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com We need those mappings for the API. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 24369] New: Add ability to set CORS header in Koha
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369 Bug ID: 24369 Summary: Add ability to set CORS header in Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The reports API can produce JSON that would be useful on other library related websites, but the use of it appears to be blocked by default via CORS. It would be nice if there were a Koha syspref to set the CORS header rather than mucking about with htaccess files and whatnot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 30

[Bug 24321] New: Make objects.search use mappings from Koha::Object(s)
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Bug ID: 24321 Summary: Make objects.search use mappings from Koha::Object(s) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com Now Koha::Object(s) implement 'to_api' and 'attributes_from_api' there's no need to implement such mappings on the controllers for simple Koha::Object<->API conversions. The to_api mappings have already been moved to Koha::Object level. It is time for the to_model ones. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 105

[Bug 22280] New: The ILL module assumes every status needs a next/previous status
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280 Bug ID: 22280 Summary: The ILL module assumes every status needs a next/previous status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no Target Milestone: --- Swedish ILL is very centrally driven, so some status changes are only done by updates from the API. That means that these statuses do not need a prev_actions or a next_actions: IN_NEG => { prev_actions => [ ], id => 'IN_NEG', name => 'Inlån Negativt svar', ui_method_name => 'Negativt svar', method => 'requestitem', next_actions => [ ], ui_method_icon => 'fa-send-o' }, But leaving these blank as above leads to errors, around line 386 of /usr/share/koha/lib/Koha/Illrequest.pm: # Update all core methods' next_actions. foreach my $prev_action ( @{$backend_status->{prev_actions}} ) { if ( grep $prev_action, @core_status_ids ) { my @next_actions = @{$status_graph->{$prev_action}->{next_actions}}; ### ERROR HERE push @next_actions, $backend_status_key; $status_graph->{$prev_action}->{next_actions} = \@next_actions; } } # Update all core methods' prev_actions foreach my $next_action ( @{$backend_status->{next_actions}} ) { if ( grep $next_action, @core_status_ids ) { my @prev_actions = @{$status_graph->{$next_action}->{prev_actions}}; ### AND HERE push @prev_actions, $backend_status_key; $status_graph->{$next_action}->{prev_actions} = \@prev_actions; } } The error is something like "Can't treat an undefined value as an array". Changing those lines to check if an array is defined makes the error go away, and I have not seen any bad side effects: @{$status_graph->{$prev_action}->{next_actions}} if $status_graph->{$prev_action}->{next_actions}; ### NO MORE ERROR HERE @{$status_graph->{$next_action}->{prev_actions}} if $status_graph->{$next_action}->{prev_actions}; ### OR HERE Does that change make sense to others, or am I missing some other way to work around this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 27