February 2022 - Koha-bugs - lists.koha-community.org

[Bug 26102] Javascript injection in intranet search
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '22

22 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26102 wainuiwitikapark(a)catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130932|0 |1 is obsolete| | --- Comment #54 from wainuiwitikapark(a)catalyst.net.nz --- Created attachment 131000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131000&action=e… Bug 26102: [19.11] Prevent XSS when To.json is used: authorities/authorities.tt Check that mandatory tags and subfields are correctly required when editing an authority record. Signed-off-by: Wainui Witika-Park <wainuiwitikapark(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 26102] Javascript injection in intranet search
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '22

22 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26102 wainuiwitikapark(a)catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130931|0 |1 is obsolete| | --- Comment #53 from wainuiwitikapark(a)catalyst.net.nz --- Created attachment 130999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130999&action=e… Bug 26102: [19.11] Prevent XSS when To.json is used: admin/preferences.tt Test that preference search term highlighting works correctly. Signed-off-by: Wainui Witika-Park <wainuiwitikapark(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 30051] New: Changing AcqCreateItems value impacts baskets set to follow default behavior
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '22

21 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30051 Bug ID: 30051 Summary: Changing AcqCreateItems value impacts baskets set to follow default behavior Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org When creating a basket in acquisitions, we record the user's choice for item creation in aqbasket.create_items. However, if one sets the basket to follow the default behavior determined in the AcqCreateItems syspref then we leave aqbasket.create_items NULL. This can create issues if the syspref gets changed. For example: - set AcqCreateItems to "placing an order" - create a basket, leaving item creation set to the default - confirm aqbasket.create_items is null - add an order to your basket from a new bib. confirm your bib and 1 item are created. - close your basket - set AcqCreateItems to "receiving an order" - receive your order - confirm receiving the order creates a second item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 28724] New: AllowAllMessageDeletion "Don't allow" not working on moremember.pl
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '22

21 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28724 Bug ID: 28724 Summary: AllowAllMessageDeletion "Don't allow" not working on moremember.pl Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: george(a)nekls.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com I can delete messages from other libraries on moremember.pl even when AllowAllMessageDeletion is set to "Don't allow" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 29903] Message deletion possible from different branch
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '22

21 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29903 George Williams (NEKLS) <george(a)nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george(a)nekls.org --- Comment #13 from George Williams (NEKLS) <george(a)nekls.org> --- *** Bug 28724 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 30146] New: Add test for missing SCSS compilation
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '22

21 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30146 Bug ID: 30146 Summary: Add test for missing SCSS compilation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: victor(a)tuxayo.net QA Contact: testopia(a)bugs.koha-community.org This is a request for a test that checks that it hasn't been missed by RMaints or the RM. Not enough RMaints use the pre-push git hook (see link bellow) that does the check locally before pushing. I have found 2 or 3 times uncompiled SCSS (thanks to the hook!) when I started working on a new (old) branch that in the previous cycle, had compilation forgotten. Is that feasible to have tests that use git? It could work like the prepush hook for "Check for missing CSS Compiles" section: https://wiki.koha-community.org/wiki/Tips_and_tricks#pre-push -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 30145] New: Add test for DBIx schema files matching kohastructure.sql
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '22

21 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30145 Bug ID: 30145 Summary: Add test for DBIx schema files matching kohastructure.sql Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: victor(a)tuxayo.net QA Contact: testopia(a)bugs.koha-community.org This is a request for a test that checks that updating the schema files hasn't been missed by RMaints or the RM. It has just been found to have happened on 20.11.x and 19.11.x. As for 20.11.x I have no idea from old long it is. Because I haven't backported structure changes this cycle. Is that feasible to have tests that use git? It could work like the prepush hook for "Check for missing CSS Compiles" section: https://wiki.koha-community.org/wiki/Tips_and_tricks#pre-push -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 29735] New: Remove flatpickr instantiations from .js files
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '22

21 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29735 Bug ID: 29735 Summary: Remove flatpickr instantiations from .js files Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 29394 Blocks: 29239 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 [Bug 29394] Remove flatpickr instantiations from .tt files -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 29906] New: When changing hold parameters over API (PUT) it forcibly gets to "suspended" state
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '22

21 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 Bug ID: 29906 Summary: When changing hold parameters over API (PUT) it forcibly gets to "suspended" state Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: stalkernoid(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com This change: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127244&action=d… - my $suspended_until = exists $body->{suspended_until} ? $body->{suspended_until} : $hold->suspend_until; + my $suspended_until = + exists $body->{suspended_until} + ? dt_from_string( $body->{suspended_until}, 'rfc3339' ) + : dt_from_string( $hold->suspend_until, 'iso' ); Breaks passing "undef" in $hold->suspend_until as well as "undef" in $body->{suspended_until} to: my $params = { ... suspend_until => $suspended_until and always comes with date, it has "today date" instead of "udef" because: sub dt_from_string has: return DateTime->now( time_zone => $tz ) unless $date_string; so as a result when you are changing any hold location (for example) from API, it also puts that hold to be suspended. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 33

[Bug 29690] New: Software error in details.pl when invalid MARCXML
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '22

21 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Bug ID: 29690 Summary: Software error in details.pl when invalid MARCXML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Bug 23846 added support for invalid MARCXML. But now page details.pl fails again with software error. This comes from several Koha::Biblio calling $self->metadata->record without eval. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 86