February 2022 - Koha-bugs - lists.koha-community.org

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '22

24 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #22 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Comment on attachment 130516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130516 Bug 12029: Patrons should be able to delete their patron messages Review of attachment 130516: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=120…) ----------------------------------------------------------------- ::: installer/data/mysql/kohastructure.sql @@ +3739,4 @@ > `message` mediumtext COLLATE utf8mb4_unicode_ci NOT NULL COMMENT 'the text of the message', > `message_date` timestamp NOT NULL DEFAULT current_timestamp() COMMENT 'the date and time the message was written', > `manager_id` int(11) DEFAULT NULL COMMENT 'creator of message', > + `patron_read_date` timestamp NULL DEFAULT NULL COMMENT 'date and time the patron dismissed the message', Final additional note from my own review: Shouldn't this be a DATETIME rather than a TIMESTAMP field? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '22

24 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #21 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Welcome Bill, This looks like a great new feature and I'm really glad the discussion continued past comment 4 to get the refinements I also felt were necessary. Regarding the actual submission, did you read the coding guidelines available https://wiki.koha-community.org/wiki/Coding_Guidelines ? These are what the QA people will base their most basic feedback upon and are 'hard fails' in most cases when not adhered to. They are voted upon by a council of community members and have good reasoning behind each (though they do not cover all cases and being updated fairly regularly as we come across various patterns.. for exapme the 'filter_by_' requirement is not yet a formal guideline, but will become one very soon) Beyond hard fails, the QA persons role is to help spot regressions and ensure coding of a minimum standard is maintained for submissions so we can maintain the features going forward. Such advice can be argued against, but should generally be considered constructive. So, taking Jonathans list. 1. Style, this may fail guidelines given our perlcritic requirements. It's a 1s fix anyway. 2. Will be in the guidelines imminently, a few minutes to fix. 3. Style, improved coding style, readability improvement. Not a hard fail, but constructive. 4. Hard fail, all module changes have required corresponding unit tests since 2017. If you are stuck here, just ask for some guidance. https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL17:_Unit_tests_a… 5. This is an unwritten rule.. I've made a note to add it to the guidelines. It just makes submissions considerably simpler for maintainers to add to all the supported branches. 6. Style, no guidelines broken, but it's a fair comment to help improve the developer. Another 10s fix. 7. Style, this will be fixed at push. 8. Hard fail: https://wiki.koha-community.org/wiki/Coding_Guidelines#Licence 9. Superfluous comments confuse future maintenance and cost everybody time. 10. Style, developers do things in their own way. Whilst I agree an ajax method would have been preferable (I'd probably have gone for a new REST route myself, rather than svc), this isn't a hard fail but more of a guide for future developments. 11. This is highlighting some red flags for future maintenance again. This is the most 'human' comment here. To me, this code looks rather 'copy/paste', which is fine but there should be evidence that you've stripped out all unnecessary boilerplate and given the development some thought as to what it's actually doing and requires. Hope that helps clarify things. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27296] New: Return claims should be filtered by default to show unresolved claims
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '22

23 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27296 Bug ID: 27296 Summary: Return claims should be filtered by default to show unresolved claims Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com I would like to add a default filter on the table of claims shown on the checkout and patron detail pages. The table will be filtered by default to show only unresolved claims, with links to switch back and forth between this view and a view of all claims. -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 30170] New: Add a link to edit the merged record on merge.pl
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '22

23 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30170 Bug ID: 30170 Summary: Add a link to edit the merged record on merge.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: barbara.johnson(a)bedfordtx.gov QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl After merging two bib records there is a link to view the merged record on merge.pl. Clicking on the link takes you to a display of the record on MARCdetail.pl. Often after merging two records we still need to go in and edit the record. It would be helpful if there were also an "edit the merged record" link on merge.pl which would take you to the advanced or basic cataloging editor based on the editor last used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 30163] New: Cater for library groups in notices
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '22

23 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30163 Bug ID: 30163 Summary: Cater for library groups in notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: fiona.borthwick(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Currently notices can be created for All libraries or individual libraries. It is very easy to clone the notices to other libraries but for large public library authorities (and especially those in a consortia), this may result in a huge number of notices. It would be good if 'library groups' could be used here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 14974] Use the REST API for cities
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '22

23 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 --- Comment #20 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Bug 30160 is going to provide an alternative using React. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14974] Use the REST API for cities
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '22

23 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30160 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14974] Use the REST API for cities
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '22

23 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 --- Comment #19 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Fridolin Somers from comment #18) > Dream became true in Bug 25279 Well, not really. The idea here was to use the different REST API routes for all CRUD operations, not only list. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7923] Performance omnibus
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '22

23 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30085 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30085 [Bug 30085] Improve performance of CanItemBeReserved -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14393] Add collection code filter to inventory
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '22

22 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44772|0 |1 is obsolete| | --- Comment #27 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 131025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131025&action=e… Bug 14393 - Add collection code filter to inventory This patch adds the ability to do inventory by collection. _TEST PLAN_ Before applying: 1) Go to "Tools > Inventory/stocktaking" 2) Note that there is no "Collection code:" option Optionally: 2b) You can create a Barcode file with a single barcode 2c) Don't select anything from "Select items you want to check" (or filter if you know how to filter to make it faster... doesn't matter) 2d) Click "Submit" at the bottom of the screen 2e) Note that there is no "Collection code" column in the screen output or CSV output (ie with/without the "Export to CSV file" box ticked before submitting) Apply the patch. After applying: 3) Note that there is a "Collection code" filter on the main inventory screen 4) Create a Barcode file with a single barcode for an item with a collection and upload it using the "Choose file" button. 5) Select that item's collection code from the "Collection code" filter 6) Click "Submit" 7) Note that the screen output and the CSV output contains a "Collection code" column (ie with/without the "Export to CSV file" box ticked before submitting) -- You are receiving this mail because: You are watching all bug changes.

1 0