February 2022 - Koha-bugs - lists.koha-community.org

[Bug 29543] Self-checkout allows returning everybody's loans
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '22

08 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29543 --- Comment #51 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Hmm. Why are we doing this in sco-main: L47 my ( $template, $loggedinuser, $cookie ) = get_template_and_user( So the CGISESSID cookie is used here and we check permissions. L371 $cookie = $query->cookie( -name => 'JWT', We create a new cookie JWT. But ignore the session cookie. L381 output_html_with_http_headers $query, $cookie, $template->output, undef, { force_no_caching => 1 }; We output now without the CGISESSID, only JWT. Why dont you pass the session cookie? You could pass something like [ $cookie1, $cookie2 ] ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29543] Self-checkout allows returning everybody's loans
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '22

08 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29543 --- Comment #50 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Question when looking in sco-main my $jwt = $query->cookie('JWT'); if ($op eq "logout") { $template->param( loggedout => 1 ); $query->param( patronlogin => undef, patronpw => undef ); undef $jwt; } Shouldnt we do some cleaning up here and just exit ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29543] Self-checkout allows returning everybody's loans
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '22

08 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29543 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30045 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30045 [Bug 30045] SCO print slip is broken -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3007] Translate UNIMARC value builders macles and unimarc_field_700-4 into English for translations
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '22

08 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007 --- Comment #9 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Oops. wrong bug! Obsoleted patches -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 3007] Translate UNIMARC value builders macles and unimarc_field_700-4 into English for translations
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '22

08 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130271|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 3007] Translate UNIMARC value builders macles and unimarc_field_700-4 into English for translations
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '22

08 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130270|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3007] Translate UNIMARC value builders macles and unimarc_field_700-4 into English for translations
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '22

08 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Attachment #130269|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 3007] Translate UNIMARC value builders macles and unimarc_field_700-4 into English for translations
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '22

08 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007 --- Comment #8 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 130271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130271&action=e… Bug 30007: Make ->anonymize methods throw an exception if AnonymousPatron is not set This patch makes the ->anonymize methods throw a Koha::Exceptions::SysPref::NotSet exception when trying to anonymize holds and checkouts without AnonymousPatron properly set. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkouts.t \ t/db_dependent/Koha/Old/Holds.t \ t/db_dependent/Koha/Old/Hold.t => FAIL: Tests fail, no exception thrown 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug.

1 0

[Bug 3007] Translate UNIMARC value builders macles and unimarc_field_700-4 into English for translations
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '22

08 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007 --- Comment #7 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 130270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130270&action=e… Bug 30007: Add Koha::Exceptions::SysPref Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug.

1 0

[Bug 3007] Translate UNIMARC value builders macles and unimarc_field_700-4 into English for translations
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '22

08 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007 --- Comment #6 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 130269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130269&action=e… Bug 30007: Regression tests Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes.

1 0