March 2022 - Koha-bugs - lists.koha-community.org

[Bug 11581] HTTP 404s generated badly in some cases
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '22

10 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11581 --- Comment #2 from David Cook <dcook(a)prosentient.com.au> --- With Bug 30261, we should be able to use C4::Output::output_error() for any staff interface or OPAC page. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11581] HTTP 404s generated badly in some cases
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '22

10 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11581 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30261 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23329] tracklinks.pl accepts any url from a parameter for proxying if not tracking
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '22

10 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23329 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30261 [Bug 30261] opac/tracklinks.pl renders 404 incorrectly -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23329] tracklinks.pl accepts any url from a parameter for proxying if not tracking
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '22

10 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23329 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #87 from David Cook <dcook(a)prosentient.com.au> --- For opac/tracklinks.pl, we changed 'print $cgi->redirect("/cgi-bin/koha/errors/404.pl");' to 'output_error( $cgi, '404' );', but that's wrong as that's an intranet style 404 when we need an opac style 404. It'll never work correctly... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11581] HTTP 404s generated badly in some cases
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '22

10 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11581 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23329 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23329] tracklinks.pl accepts any url from a parameter for proxying if not tracking
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '22

10 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23329 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11581 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27009] New: Use 301 to redirect from tracklinks.pl
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '22

10 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27009 Bug ID: 27009 Summary: Use 301 to redirect from tracklinks.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org In opac/tracklinks.pl we use a simple redirect to send the user on to the actual URL, after tracking: print $cgi->redirect($uri); This sends a "302 Moved Temporarily" to the browser as a default. One of our clients had some SEO work done on their websites, and one of the recommendations was to use "301 Moved Permanently" instead. This makes some sense, the URLs we redirect to do not change very often, I guess. According to https://metacpan.org/pod/CGI#Generating-a-redirection-header, the solution is to change the call to redirect() thusly: print $q->redirect( -uri => $uri, -status => '301 Moved Permanently' ); Patch coming. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 30240] New: Re-authentication on sensitive actions
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '22

09 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30240 Bug ID: 30240 Summary: Re-authentication on sensitive actions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com It would be nice if it was possible to give extra protection to some sensitive actions in the staff client, such as maybe updating borrowers and definitely changing sysprefs. This could be done by asking the user to re-authenticate, before carrying out the action. Extra nice if this could be turned on and off for individual actions. https://opsec.readthedocs.io/en/latest/user/re-authentication-on-sensitive-… -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 30256] New: PUT /patrons/42 returns 201 instead of 200
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '22

09 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30256 Bug ID: 30256 Summary: PUT /patrons/42 returns 201 instead of 200 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart+koha(a)gmail.com CC: tomascohen(a)gmail.com https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/PUT """ If the target resource does not have a current representation and the PUT request successfully creates one, then the origin server must inform the user agent by sending a 201 (Created) response. If the target resource does have a current representation and that representation is successfully modified in accordance with the state of the enclosed representation, then the origin server must send either a 200 (OK) or a 204 (No Content) response to indicate successful completion of the request. """ We are returning 200, at least for /patrons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 26650] New: Add Koha::Object->reset_messages
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '22

09 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26650 Bug ID: 26650 Summary: Add Koha::Object->reset_messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org This method was originally introduced as part of bug 26555. But it was not clear if it was required, or even if some more complex mechanism for marking 'seen' messages is required. I'm leaving this specific patch here for discussing it once someone finds a real need for it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2