March 2022 - Koha-bugs - lists.koha-community.org

[Bug 1526] Catalogue detail page does not show reserve status
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '22

10 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1526 --- Comment #1 from Henri-Damien LAURENT <hdlaurent(a)afi-sa.net> --- Created attachment 131561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131561&action=e… Bug 15261: Check if checkout/reserve request overlaps existing reserves When checking out or placing hold, we should check if an existing reserve whose period overlap exists. - A user places a hold from opac whose requested period overlaps with an existing reserve period => prevent reserve - A librarian places a hold from staff whose requested period overlaps with an existing reserve period => Warn librarian (Ask for confirmation) - A librarian makes a checkout from staff whose requested period overlaps with an existing reserve period => Warn librarian (Ask for confirmation) Test plan: Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod 1 (staff side): - Place a hold on title (which has only one items) level with start date and expiration date. - Place another hold (also title level) with period overlaping this reserve. - Check you are warned about an existing reserve 2 (staff side): - Place a hold on title (which has more than one items) level with start date and expiration date. - Place another hold (also title level) with period overlaping this reserve. - Check you are NOT warned about an existing reserve. Because it remains at least one item not reserved. 3 (staff side): - Place a hold on item level with start date and expiration date. - Place another hold on item level with period overlaping this reserve. - Check you are warned about an existing reserve. 4 (opac side): - Do the same than for staff side. Instead of a warn, reserve is prevented. 5: - Place a hold on title (which has only one items) level with start date and expiration date. - Try to checkout the unique item from this title with period overlaping the reserve period. - Check you are warned about an existing reserve 6: - Place a hold on title (which has more than one items) level with start date and expiration date. - Checkout an item from this title with period overlaping the reserve period. - Check you are NOT warned about an existing reserve. 7: - Place a hold on item level with start date and expiration date. - Checkout this item period overlaping the reserve period. - Check you are warned about an existing reserve 8: - Create a checkout (i.e from ${TODAY} to ${TODAY + 10 days}), - Place a hold on the same item from ${TODAY + 11 days} to ${TODAY + 30 days}), - Check that you cannot renew the checkout. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19642] New: If autoMemberNum is enabled, we should just ignore cardnumber entry in BorrowerMandatoryField
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '22

10 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19642 Bug ID: 19642 Summary: If autoMemberNum is enabled, we should just ignore cardnumber entry in BorrowerMandatoryField Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Bug 19225 proposes a warning for users that the config is wrong. I propose instead, we should just ignore that field if automembernum is enabled (since it autocalculates and becomes mandatory -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 8

[Bug 6815] Capture member photo via webcam
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '22

10 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Nicolas Legrand <nicolas.legrand(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers(a)biblibre.co | |m --- Comment #85 from Nicolas Legrand <nicolas.legrand(a)bulac.fr> --- Frido, any chance you merge this in 20.11? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6815] Capture member photo via webcam
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '22

10 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Nicolas Legrand <nicolas.legrand(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand(a)bulac.fr Status|Needs Signoff |Signed Off --- Comment #84 from Nicolas Legrand <nicolas.legrand(a)bulac.fr> --- Thank you Owen it's great! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6815] Capture member photo via webcam
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '22

10 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Nicolas Legrand <nicolas.legrand(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131174|0 |1 is obsolete| | --- Comment #83 from Nicolas Legrand <nicolas.legrand(a)bulac.fr> --- Created attachment 131554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131554&action=e… Bug 6815: Capture member photo via webcam This patch builds on a patch by Mark Tompsett, adding the option to take a patron's picture using the computer's webcam. The photo can then be saved to the patron's account. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staf…) - Go to Administration -> System preferences and enable the 'patronimages' preference. - View a patron record. In the sidebar, hover your mouse over the blank patron image. Click the "Edit" button which appears. - A modal window should appear with two sections, "Upload patron photo" and "Take patron photo." - If your computer has a webcam, your browser should ask permission to access it. Grant access. - You should see the view of your webcam shown under the "Take photo" button. - Click the "Take photo" button. The captured photo should be shown in place of the live video from the webcam. - You should now see three buttons: "Retake photo," "Download photo," and "Upload photo." - Clicking "Retake photo" should hide those buttons and return you to a live video view. - Clicking "Download" should make your browser download the image. - Clicking "Upload" should cause the page to redirect back to the patron detail page where you should see the new patron image displayed in the sidebar. - Trigger the modal again and click the "cancel" button. The modal should disappear and camera access should stop. - If your computer has no webcam the modal should appear correctly but there should be a banner at the bottom indicating that a camera is not available. - Try the test again but this time deny your browser access to the webcam. You may need to reset the camera permissions in your browser's settings. When the modal appears you should see a message saying access to the camera is denied. - The patron image edit modal should be available on all pages which show the patron image in the sidebar: Check out, Batch check out, Details, Accounting, Routing lists, Circulation history, Holds history, Modification log, Notices, Statistics, Files, Purchase suggestions, Discharges, Housebound, and ILL requests history. - Test adding an image to a patron record using the "Upload photo" option. It should still work correctly. - If the patron has an image attached, the "Upload photo" section should have a "Delete" button. Test that it works correctly. Signed-off-by: Nicolas Legrand <nicolas.legrand(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7923] Performance omnibus
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '22

10 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28172 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28172 [Bug 28172] Optimize Koha::Plugins::GetPlugins -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7923] Performance omnibus
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '22

10 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29517 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29517 [Bug 29517] CanItemBeReserved fetches biblio for agerestriction check if feature not enabled -- You are receiving this mail because: You are watching all bug changes.

1 0

Re: [Koha-bugs] Bug 29881 - Remove SQLite2 dependency (edit)
by Mason James 10 Mar '22

10 Mar '22

hi RMaints i think we should revert bz-29881 patch on stable (and lower), just to be safe i don't think this patch has caused a problem in production systems, as libdbd-sqlite2-perl package is preferred over libdbd-sqlite3-perl - so no accidental upgrade to libdbd-sqlite3-perl will happen the patch is safe to leave for the future 22.05 release :) cheers, Mason On 9/03/22 11:44 pm, Fridolin SOMERS wrote: > Mason, you talked on IRC reverting Bug 29881 in stable branches. > Please contact RMaints to do this for this month release. > > Best regards, > > Le 08/03/2022 à 23:25, Mason James a écrit : >> hiya >> >> bug 30209 should fix the master builds >> Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209 >> >> >> On 9/03/22 9:50 pm, Jonathan Druart wrote: >>> From IRC: >>> test suite is failing because of: DBI Connection failed: >>> install_driver(SQLite) failed: Can't locate DBD/SQLite.pm >>> mtj[m]: do we need bug 30209 to fix it? >>> >>> Le mer. 9 mars 2022 à 08:46, Fridolin SOMERS >>> <fridolin.somers(a)biblibre.com> a écrit : >>>> Hi, >>>> >>>> Test suite is failing on 16 tests, except on D12 and U_Stable. >>>> >>>> How can that be ? >>>> I dont reproduce on my D11 KTD. >>>> >>>> Thanks for your help :D >>>> Best regards, >>>> >>>> -- >>>> Fridolin SOMERS <fridolin.somers(a)biblibre.com> >>>> Software and system maintainer 🦄 >>>> BibLibre, France >> >

1 1

[Bug 23329] tracklinks.pl accepts any url from a parameter for proxying if not tracking
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '22

10 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23329 --- Comment #88 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #87) > For opac/tracklinks.pl, we changed 'print > $cgi->redirect("/cgi-bin/koha/errors/404.pl");' to 'output_error( $cgi, > '404' );', but that's wrong as that's an intranet style 404 when we need an > opac style 404. It'll never work correctly... See Bug 30261 for a fix for that. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11581] HTTP 404s generated badly in some cases
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '22

10 Mar '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11581 --- Comment #3 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Fridolin Somers from comment #1) > Indeed. > I think there should be HTML static pages for all HTTP error codes. > They should be used in both apache configuration and in GCI output (maybe > adding methods into C4::Output). I like the idea of static HTML pages. I think we've avoided them because we want to use the templating and such for a common look and feel, but I was just thinking... we could generate the static HTML pages during an app build step. I suppose that wouldn't work well for a git deployment though... -- You are receiving this mail because: You are watching all bug changes.

1 0